You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/15 07:30:02 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1140: Makefile/Application: correct libgcc PATH

pkarashchenko commented on code in PR #1140:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1140#discussion_r851115318


##########
Application.mk:
##########
@@ -54,10 +54,13 @@ endif
 ifeq ($(BUILD_MODULE),y)
   # Revisit: This only works for gcc and clang.
   # Do other compilers have similar?
-  COMPILER_RT_LIB = $(shell $(CC) $(ARCHCPUFLAGS) --print-libgcc-file-name)
-  ifneq ($(COMPILER_RT_LIB),)
-    LDLIBS += $(COMPILER_RT_LIB)
+  LIBGCC = $(shell $(CC) $(ARCHCPUFLAGS) --print-libgcc-file-name)

Review Comment:
   @anchao do you know why `--print-libgcc-file-name` fails? is it because of `ARCHCPUFLAGS` do not contain a proper flags?
   I mean that I'm not sure if we need fallback path. Do you have an example output of `$(shell $(CC) $(ARCHCPUFLAGS) --print-libgcc-file-name)` that meets  `ifeq ($(wildcard $(LIBGCC)),)` condition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org