You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yongqiao Wang <yq...@cn.ibm.com> on 2016/01/21 07:42:22 UTC

Review Request 42591: Added Framework protobufs to registry.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-1719
    https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description
-------

Define the protobufs in registry to persist some framework infoamation which do not allowed to changed when framework re-register.


Diffs
-----

  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 

Diff: https://reviews.apache.org/r/42591/diff/


Testing
-------

Make && Make check successfully


Thanks,

Yongqiao Wang


Re: Review Request 42591: Added Framework protobufs to registry.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/#review115604
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42591]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 21, 2016, 6:44 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42591/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
>     https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the protobufs in registry to persist some framework informations which do not allow to change when framework re-register.
> 
> 
> Diffs
> -----
> 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
> 
> Diff: https://reviews.apache.org/r/42591/diff/
> 
> 
> Testing
> -------
> 
> Make && Make check successfully
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Re: Review Request 42591: Added Framework protobufs to registry.

Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 6:44 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-1719
    https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description (updated)
-------

Add the protobufs in registry to persist some framework informations which do not allow to change when framework re-register.


Diffs
-----

  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 

Diff: https://reviews.apache.org/r/42591/diff/


Testing
-------

Make && Make check successfully


Thanks,

Yongqiao Wang