You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/19 01:27:20 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #6926: AuTest: enable_cache and add 'cache enabled' as a ready condition.
bneradt opened a new pull request #6926:
URL: https://github.com/apache/trafficserver/pull/6926
This is an incremental step in making the tests more robust. This adds the option to enable the cache in MakeATSProcess. By default this is true, since the default ATS configuration is to have the cache enabled, and waits upon a line in diags.log for the cache to be ready. If caching is disabled, as quite a few tests are configured, then the default ready criteria goes back to waiting on the ports being bound.
As a side effect, this
Ideally we'd wait upon both conditions. I plan to work on that next, but we'll have to extend AuTest to support this. I talked with Jason and we filed the following issue for this:
https://bitbucket.org/autestsuite/reusable-gold-testing-system/issues/5/make-ready-criteria-composable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #6926: AuTest: enable_cache and a new When condition on log content
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #6926:
URL: https://github.com/apache/trafficserver/pull/6926#issuecomment-646882699
Actually, sadly I do need the whole thing. I wanted to make a smaller PR, but the problem with just grabbing the log change and the MakeATSProcess Ready change is that the tests often mistakenly set their own ready criteria. There are a few TLS tests where explicitly setting the ready on a different port was needed for the test, but even those won't be needed now. Those need to be removed so that the default ready which will now wait upon the diags.log message will
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt closed pull request #6926: AuTest: enable_cache and a new When condition on log content
Posted by GitBox <gi...@apache.org>.
bneradt closed pull request #6926:
URL: https://github.com/apache/trafficserver/pull/6926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #6926: AuTest: enable_cache and a new When condition on log content
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #6926:
URL: https://github.com/apache/trafficserver/pull/6926#issuecomment-646878050
Sigh. This PR has developed into two PRs, one for the When condition waiting upon the new log message, the second for the enable_cache MakeATSProcess option. I'll close this and open two new ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #6926: AuTest: enable_cache and add 'cache enabled' as a ready condition.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #6926:
URL: https://github.com/apache/trafficserver/pull/6926#issuecomment-646728308
Offline, @SolidWallOfCode made the observation that we can add a message in traffic server that indicates that everything is initialized. That should be pretty easy to do and should fit into this PR nicely if it turns out as simple as it sounds. I'll be investigating this today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #6926: AuTest: enable_cache and add 'cache enabled' as a ready condition.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #6926:
URL: https://github.com/apache/trafficserver/pull/6926#issuecomment-646413118
[approve ci autest]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org