You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/10 08:03:23 UTC

[GitHub] [airflow] potiuk opened a new pull request, #22884: Fix new MyPy errors in main

potiuk opened a new pull request, #22884:
URL: https://github.com/apache/airflow/pull/22884

Those MyPe errors are side effect of some new dependencies.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #22884:
URL: https://github.com/apache/airflow/pull/22884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094291944

   It also could be that somewhere in the code len() is used and that would make it not good candidate for Iterable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094285024

   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094333474

   Yeah. Could be :) . I do not see any problem with changing it to Iterable if it passes all the tests. I


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094291492

   > Why are `template_fields` and `template_ext` now sequences and not instead `Iterable` – ?
   > 
   > If someone wants a deterministic order, then can use a list or tuple as the value.
   
   I just fixed consistency. I think there is no particular reason. I do not think it matters as long as it consistent. You can make a PR to change it ti Iterable -but it has to be consistent in all providers and code. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094213550

   BTW. A number of those errors (except the big google Retry) are because `MyPy` has quite a big problem with recognizing that for example our `airflow.providers.grpc` module is not the same as `grpc` . This is because provider's module is implicit and somehow mypy things that grpc is the top-level module (same with jenkins and few others). We will have to solve it better when we split providers from the core.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] malthe commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

malthe commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094296165

   @potiuk from the description of those attributes, I don't see why any code would do `len()` on it. It seems you've got to iterate until you find a match or keep trying.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] malthe commented on pull request #22884: Fix new MyPy errors in main

Posted by GitBox <gi...@apache.org>.

malthe commented on PR #22884:
URL: https://github.com/apache/airflow/pull/22884#issuecomment-1094290081

   Why are `template_fields` and `template_ext` now sequences and not instead `Iterable` – ?
   
   If someone wants a deterministic order, then can use a list or tuple as the value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org