You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/19 11:46:03 UTC
[GitHub] [incubator-kyuubi] zhouyifan279 commented on a diff in pull request #3665: [Subtask] Get table owner from CatalogTable #3608
zhouyifan279 commented on code in PR #3665:
URL: https://github.com/apache/incubator-kyuubi/pull/3665#discussion_r999330249
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilderSuite.scala:
##########
@@ -60,12 +60,20 @@ abstract class PrivilegesBuilderSuite extends AnyFunSuite
assert(po.actionType === PrivilegeObjectActionType.OTHER)
assert(po.privilegeObjectType === PrivilegeObjectType.TABLE_OR_VIEW)
assert(po.columns === cols)
+ checkTableOwner(po)
}
protected def checkColumns(query: String, cols: Seq[String]): Unit = {
checkColumns(sql(query).queryExecution.optimizedPlan, cols)
}
+ protected def checkTableOwner(po: PrivilegeObject): Unit = {
+ if (catalogImpl == "hive" && po.privilegeObjectType === PrivilegeObjectType.TABLE_OR_VIEW) {
Review Comment:
Support DataSourceV2 table in next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org