[jira] Closed: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

["Bruno Busco (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-3653.
------------------------------

    Resolution: Fixed

Thank you Blas,
your patch is in trunk at revision: 931618

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
>                 Key: OFBIZ-3653
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3653
>             Project: OFBiz
>          Issue Type: Bug
>          Components: themes
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Bruno Busco
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em 
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em; 
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.