You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/06 18:37:49 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #17984: Raise
toolchain requirements for MXNet 2
leezu opened a new pull request #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984
## Description ##
As per https://github.com/apache/incubator-mxnet/issues/17968, require C++17 compatible compiler.
For cuda code, use C++14 mode introduced in Cuda 9. In general there is no issue with linking together objects resulting from different standards as long as they are compiled by the same compiler.
Switch CI/CD pipeline to use gcc7
Also remove outdated references to Cuda 7 and Cuda 8 in various files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu removed a comment on issue #17984: Raise
toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
leezu removed a comment on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612649707
@marcoabreu @larroy this relies on the binfmt fix binary support of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/binfmt_misc.txt?h=linux-4.8.y#n69 There is also a small summary at https://codepyre.com/2019/12/arming-yourself/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17984: Raise toolchain
requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612649707
@larroy this relies on the binfmt fix binary support of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/binfmt_misc.txt?h=linux-4.8.y#n69 There is also a small summary at https://codepyre.com/2019/12/arming-yourself/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17984: Raise
toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612727139
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17984: Raise
toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-609966938
Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, centos-cpu, edge, centos-gpu, unix-cpu, windows-cpu, sanity, windows-gpu, unix-gpu, miscellaneous, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu edited a comment on issue #17984: Raise
toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612649707
@marcoabreu @larroy this relies on the binfmt fix binary support of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/binfmt_misc.txt?h=linux-4.8.y#n69 There is also a small summary at https://codepyre.com/2019/12/arming-yourself/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu removed a comment on issue #17984: Raise
toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
leezu removed a comment on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612727114
@mxnet-bot run ci [unix-cpu]
Due to https://github.com/apache/incubator-mxnet/issues/17067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17984: Raise toolchain
requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on a change in pull request
#17984: Raise toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#discussion_r407673780
##########
File path: src/operator/contrib/dgl_graph.cc
##########
@@ -24,6 +24,9 @@
#include <mxnet/operator_util.h>
Review comment:
@zheng-da could you help review this in #17984?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17984: Raise toolchain
requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612727114
@mxnet-bot run ci [unix-cpu]
Due to https://github.com/apache/incubator-mxnet/issues/17067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot removed a comment on issue #17984:
Raise toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
mxnet-bot removed a comment on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-612727139
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zheng-da commented on a change in pull request
#17984: Raise toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
zheng-da commented on a change in pull request #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#discussion_r408305956
##########
File path: src/operator/contrib/dgl_graph.cc
##########
@@ -24,6 +24,9 @@
#include <mxnet/operator_util.h>
Review comment:
DGL no longer depends on the contrib graph operators. I would suggest to deprecate this sampling operator and even remove it in MXNet 2.0. Please see my comment here. https://github.com/apache/incubator-mxnet/issues/16167#issuecomment-613160299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17984: Raise
toolchain requirements for MXNet 2
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17984: Raise toolchain requirements for MXNet 2
URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-610675875
Note: With this we will be able to change shared_ptr here: https://github.com/apache/incubator-mxnet/blob/master/src/engine/threaded_engine.h#L440 to `unique_ptr` (as it was supposed to be but C++11 did not allow `std::move` to lambda).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services