You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/10/19 08:31:14 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1192: refactor(metrics): drop template specialization for gauge
empiredan opened a new pull request, #1192:
URL: https://github.com/apache/incubator-pegasus/pull/1192
This PR is to solve https://github.com/apache/incubator-pegasus/issues/1191.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1192: refactor(metrics): drop template specialization for gauge
Posted by GitBox <gi...@apache.org>.
empiredan commented on code in PR #1192:
URL: https://github.com/apache/incubator-pegasus/pull/1192#discussion_r1000450129
##########
src/rdsn/src/utils/metrics.h:
##########
@@ -389,53 +389,55 @@ template <typename T, typename = typename std::enable_if<std::is_arithmetic<T>::
class gauge : public metric
Review Comment:
> Why didn't you change `typename T` to `typename value_type` in the above line?
`value_type` may be a combination of multiple template parameters. For example, in std::map, `value_type` is defined as `std::pair<const _Key, _Tp>`. Thus customarily `value_type` is used to decouple from template parameters though for `gauge` it is just the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a diff in pull request #1192: refactor(metrics): drop template specialization for gauge
Posted by GitBox <gi...@apache.org>.
levy5307 commented on code in PR #1192:
URL: https://github.com/apache/incubator-pegasus/pull/1192#discussion_r1000401709
##########
src/rdsn/src/utils/metrics.h:
##########
@@ -389,53 +389,55 @@ template <typename T, typename = typename std::enable_if<std::is_arithmetic<T>::
class gauge : public metric
Review Comment:
Why didn't you change `typename T` to `typename value_type` in the above line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 merged pull request #1192: refactor(metrics): drop template specialization for gauge
Posted by GitBox <gi...@apache.org>.
levy5307 merged PR #1192:
URL: https://github.com/apache/incubator-pegasus/pull/1192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org