You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "shalk (via GitHub)" <gi...@apache.org> on 2023/03/24 17:36:25 UTC
[GitHub] [incubator-pegasus] shalk opened a new pull request, #1416: Fix java spotbug
shalk opened a new pull request, #1416:
URL: https://github.com/apache/incubator-pegasus/pull/1416
### What problem does this PR solve? <!--add issue link with summary if exists-->
`mvn validate` will fail with generated code
### What is changed and how does it work?
uncomment maven spotbug plugin
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1416: fix(java-client): Fix java spotbug
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1416:
URL: https://github.com/apache/incubator-pegasus/pull/1416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Apache9 commented on a diff in pull request #1416: Fix java spotbug
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #1416:
URL: https://github.com/apache/incubator-pegasus/pull/1416#discussion_r1148861454
##########
java-client/dev-support/findbugs-exclude.xml:
##########
@@ -36,6 +38,7 @@
<Package name="org.apache.pegasus.tools"/>
<Package name="org.apache.pegasus.client.request"/>
<Package name="org.apache.pegasus.example"/>
+
Review Comment:
Why this empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org