You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org> on 2009/10/12 05:03:31 UTC

[jira] Created: (PIG-1015) [piggybank] DateExtractor should take into account timezones

[piggybank] DateExtractor should take into account timezones
------------------------------------------------------------

                 Key: PIG-1015
                 URL: https://issues.apache.org/jira/browse/PIG-1015
             Project: Pig
          Issue Type: Bug
            Reporter: Dmitriy V. Ryaboy


The current implementation defaults to the local timezone when parsing strings, thereby providing inconsistent results depending on the settings of the computer the program is executing on (this is causing unit test failures). We should set the timezone to a consistent default, and allow users to override this default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1015) [piggybank] DateExtractor should take into account timezones

Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-1015:
-----------------------------------

    Fix Version/s: 0.6.0
           Status: Patch Available  (was: Open)

> [piggybank] DateExtractor should take into account timezones
> ------------------------------------------------------------
>
>                 Key: PIG-1015
>                 URL: https://issues.apache.org/jira/browse/PIG-1015
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>             Fix For: 0.6.0
>
>         Attachments: date_extractor.patch
>
>
> The current implementation defaults to the local timezone when parsing strings, thereby providing inconsistent results depending on the settings of the computer the program is executing on (this is causing unit test failures). We should set the timezone to a consistent default, and allow users to override this default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1015) [piggybank] DateExtractor should take into account timezones

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1015:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

patch committed. Thanks, Dmitry!

> [piggybank] DateExtractor should take into account timezones
> ------------------------------------------------------------
>
>                 Key: PIG-1015
>                 URL: https://issues.apache.org/jira/browse/PIG-1015
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>             Fix For: 0.6.0
>
>         Attachments: date_extractor.patch
>
>
> The current implementation defaults to the local timezone when parsing strings, thereby providing inconsistent results depending on the settings of the computer the program is executing on (this is causing unit test failures). We should set the timezone to a consistent default, and allow users to override this default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1015) [piggybank] DateExtractor should take into account timezones

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764568#action_12764568 ] 

Hadoop QA commented on PIG-1015:
--------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12421836/date_extractor.patch
  against trunk revision 823693.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/71/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/71/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/71/console

This message is automatically generated.

> [piggybank] DateExtractor should take into account timezones
> ------------------------------------------------------------
>
>                 Key: PIG-1015
>                 URL: https://issues.apache.org/jira/browse/PIG-1015
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>             Fix For: 0.6.0
>
>         Attachments: date_extractor.patch
>
>
> The current implementation defaults to the local timezone when parsing strings, thereby providing inconsistent results depending on the settings of the computer the program is executing on (this is causing unit test failures). We should set the timezone to a consistent default, and allow users to override this default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-1015) [piggybank] DateExtractor should take into account timezones

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates reassigned PIG-1015:
-------------------------------

    Assignee: Dmitriy V. Ryaboy

> [piggybank] DateExtractor should take into account timezones
> ------------------------------------------------------------
>
>                 Key: PIG-1015
>                 URL: https://issues.apache.org/jira/browse/PIG-1015
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.6.0
>
>         Attachments: date_extractor.patch
>
>
> The current implementation defaults to the local timezone when parsing strings, thereby providing inconsistent results depending on the settings of the computer the program is executing on (this is causing unit test failures). We should set the timezone to a consistent default, and allow users to override this default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1015) [piggybank] DateExtractor should take into account timezones

Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-1015:
-----------------------------------

    Attachment: date_extractor.patch

Note that this changes the contract slightly, as the DateExtractor extracts dates in GMT by default, whereas before it extracted them in system's local time. 

> [piggybank] DateExtractor should take into account timezones
> ------------------------------------------------------------
>
>                 Key: PIG-1015
>                 URL: https://issues.apache.org/jira/browse/PIG-1015
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>         Attachments: date_extractor.patch
>
>
> The current implementation defaults to the local timezone when parsing strings, thereby providing inconsistent results depending on the settings of the computer the program is executing on (this is causing unit test failures). We should set the timezone to a consistent default, and allow users to override this default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.