You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/03 09:09:11 UTC
[GitHub] [airflow] turbaszek commented on a change in pull request #8265: Kubernetes on host
turbaszek commented on a change in pull request #8265:
URL: https://github.com/apache/airflow/pull/8265#discussion_r434419635
##########
File path: kubernetes_tests/test_kubernetes_executor.py
##########
@@ -20,16 +20,18 @@
import unittest
Review comment:
Why we rename this test file?
##########
File path: .github/workflows/ci.yml
##########
@@ -39,144 +38,144 @@ env:
CACHE_REGISTRY_USERNAME: ${{ github.actor }}
CACHE_REGISTRY_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
jobs:
- static-checks-1:
- timeout-minutes: 60
- name: "Checks: some checks"
- runs-on: ubuntu-latest
- env:
- MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS: "true"
- CI_JOB_TYPE: "Static checks"
- steps:
- - uses: actions/checkout@master
- - uses: actions/setup-python@v1
- with:
- python-version: '3.x'
- - name: Cache pre-commit env
- uses: actions/cache@v1
- env:
- cache-name: cache-pre-commit
- with:
- path: ~/.cache/pre-commit
- key: ${{ env.cache-name }}-${{ github.job }}-${{ hashFiles('.pre-commit-config.yaml') }}
- - name: "Free space"
- run: ./scripts/ci/ci_free_space_on_ci.sh
- - name: "Build CI image"
- run: ./scripts/ci/ci_prepare_image_on_ci.sh
- - name: "Static checks"
- if: success()
- env:
- PYTHON_VERSION: 3.6
- run: |
- python -m pip install pre-commit \
- --constraint requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt
- ./scripts/ci/ci_run_static_checks.sh pylint-tests mypy yamllint flake8
-
- static-checks-2:
- timeout-minutes: 60
- name: "Checks: all other"
- runs-on: ubuntu-latest
- env:
- SKIP: pylint-tests,mypy,yamllint,flake8
- MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS: "true"
- CI_JOB_TYPE: "Static checks"
- steps:
- - uses: actions/checkout@master
- - uses: actions/setup-python@v1
- with:
- python-version: '3.x'
- - name: Cache pre-commit env
- uses: actions/cache@v1
- env:
- cache-name: cache-pre-commit
- with:
- path: ~/.cache/pre-commit
- key: ${{ env.cache-name }}-${{ github.job }}-${{ hashFiles('.pre-commit-config.yaml') }}
- - name: "Free space"
- run: ./scripts/ci/ci_free_space_on_ci.sh
- - name: "Build CI image"
- run: ./scripts/ci/ci_prepare_image_on_ci.sh
- - name: "Static checks"
- run: |
- python -m pip install pre-commit \
- --constraint requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt
- ./scripts/ci/ci_run_static_checks.sh
-
- docs:
- timeout-minutes: 60
- name: Build docs
- runs-on: ubuntu-latest
- env:
- CI_JOB_TYPE: "Documentation"
- steps:
- - uses: actions/checkout@master
- - name: "Build CI image ${{ matrix.python-version }}"
- run: ./scripts/ci/ci_prepare_image_on_ci.sh
- - name: "Build docs"
- run: ./scripts/ci/ci_docs.sh
-
- build-prod-image:
- timeout-minutes: 60
- name: "Build prod image Py${{ matrix.python-version }}"
- runs-on: ubuntu-latest
- strategy:
- matrix:
- python-version: [3.6, 3.7]
- env:
- PYTHON_MAJOR_MINOR_VERSION: ${{ matrix.python-version }}
- CI_JOB_TYPE: "Prod image"
- steps:
- - uses: actions/checkout@master
- - name: "Build PROD image ${{ matrix.python-version }}"
- run: ./scripts/ci/ci_build_production_images.sh
-
- prepare-backport-packages:
- timeout-minutes: 60
- name: "Backport packages"
- runs-on: ubuntu-latest
- env:
- INSTALL_AIRFLOW_VERSION: "1.10.10"
- CI_JOB_TYPE: "Prepare & test packages"
- PYTHON_MAJOR_MINOR_VERSION: 3.6
- steps:
- - uses: actions/checkout@master
- with:
- fetch-depth: 0
- - uses: actions/setup-python@v1
- with:
- python-version: '3.x'
- - name: "Free space"
- run: ./scripts/ci/ci_free_space_on_ci.sh
- - name: "Build CI image ${{ matrix.python-version }}"
- run: ./scripts/ci/ci_prepare_image_on_ci.sh
- - name: "Prepare & test backport packages"
- run: |
- ./scripts/ci/ci_prepare_and_test_backport_packages.sh
-
- pyfiles:
- timeout-minutes: 10
- name: "Count changed important files"
- runs-on: ubuntu-latest
- outputs:
- count: ${{ steps.pyfiles.outputs.count }}
- steps:
- - uses: actions/checkout@master
- - name: "Get count of changed python files"
- run: |
- set +e
- ./scripts/ci/ci_count_changed_files.sh ${GITHUB_SHA} '\.py$|.github/workflows/|^Dockerfile'
- echo "::set-output name=count::$?"
- id: pyfiles
+# static-checks-1:
+# timeout-minutes: 60
+# name: "Checks: some checks"
+# runs-on: ubuntu-latest
+# env:
+# MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS: "true"
+# CI_JOB_TYPE: "Static checks"
+# steps:
+# - uses: actions/checkout@master
+# - uses: actions/setup-python@v1
+# with:
+# python-version: '3.x'
+# - name: Cache pre-commit env
+# uses: actions/cache@v2
+# env:
+# cache-name: cache-pre-commit-v2
+# with:
+# path: ~/.cache/pre-commit
+# key: ${{ env.cache-name }}-${{ github.job }}-${{ hashFiles('.pre-commit-config.yaml') }}
+# - name: "Free space"
+# run: ./scripts/ci/ci_free_space_on_ci.sh
+# - name: "Build CI image"
+# run: ./scripts/ci/ci_prepare_image_on_ci.sh
+# - name: "Static checks"
+# if: success()
+# env:
+# PYTHON_VERSION: 3.6
+# run: |
+# python -m pip install pre-commit \
+# --constraint requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt
+# ./scripts/ci/ci_run_static_checks.sh pylint-tests mypy yamllint flake8
+#
+# static-checks-2:
+# timeout-minutes: 60
+# name: "Checks: all other"
+# runs-on: ubuntu-latest
+# env:
+# SKIP: pylint-tests,mypy,yamllint,flake8
+# MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS: "true"
+# CI_JOB_TYPE: "Static checks"
+# steps:
+# - uses: actions/checkout@master
+# - uses: actions/setup-python@v1
+# with:
+# python-version: '3.x'
+# - name: Cache pre-commit env
+# uses: actions/cache@v1
+# env:
+# cache-name: cache-pre-commit
+# with:
+# path: ~/.cache/pre-commit
+# key: ${{ env.cache-name }}-${{ github.job }}-${{ hashFiles('.pre-commit-config.yaml') }}
+# - name: "Free space"
+# run: ./scripts/ci/ci_free_space_on_ci.sh
+# - name: "Build CI image"
+# run: ./scripts/ci/ci_prepare_image_on_ci.sh
+# - name: "Static checks"
+# run: |
+# python -m pip install pre-commit \
+# --constraint requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt
+# ./scripts/ci/ci_run_static_checks.sh
+#
+# docs:
+# timeout-minutes: 60
+# name: Build docs
+# runs-on: ubuntu-latest
+# env:
+# CI_JOB_TYPE: "Documentation"
+# steps:
+# - uses: actions/checkout@master
+# - name: "Build CI image ${{ matrix.python-version }}"
+# run: ./scripts/ci/ci_prepare_image_on_ci.sh
+# - name: "Build docs"
+# run: ./scripts/ci/ci_docs.sh
+#
+# build-prod-image:
+# timeout-minutes: 60
+# name: "Build prod image Py${{ matrix.python-version }}"
+# runs-on: ubuntu-latest
+# strategy:
+# matrix:
+# python-version: [3.6, 3.7]
+# env:
+# PYTHON_MAJOR_MINOR_VERSION: ${{ matrix.python-version }}
+# CI_JOB_TYPE: "Prod image"
+# steps:
+# - uses: actions/checkout@master
+# - name: "Build PROD image ${{ matrix.python-version }}"
+# run: ./scripts/ci/ci_build_production_images.sh
+#
+# prepare-backport-packages:
+# timeout-minutes: 60
+# name: "Backport packages"
+# runs-on: ubuntu-latest
+# env:
+# INSTALL_AIRFLOW_VERSION: "1.10.10"
+# CI_JOB_TYPE: "Prepare & test packages"
+# PYTHON_MAJOR_MINOR_VERSION: 3.6
+# steps:
+# - uses: actions/checkout@master
+# with:
+# fetch-depth: 0
+# - uses: actions/setup-python@v1
+# with:
+# python-version: '3.x'
+# - name: "Free space"
+# run: ./scripts/ci/ci_free_space_on_ci.sh
+# - name: "Build CI image ${{ matrix.python-version }}"
+# run: ./scripts/ci/ci_prepare_image_on_ci.sh
+# - name: "Prepare & test backport packages"
+# run: |
+# ./scripts/ci/ci_prepare_and_test_backport_packages.sh
+#
+# pyfiles:
+# timeout-minutes: 10
+# name: "Count changed important files"
+# runs-on: ubuntu-latest
+# outputs:
+# count: ${{ steps.pyfiles.outputs.count }}
+# steps:
+# - uses: actions/checkout@master
+# - name: "Get count of changed python files"
+# run: |
+# set +e
+# ./scripts/ci/ci_count_changed_files.sh ${GITHUB_SHA} '\.py$|.github/workflows/|^Dockerfile'
+# echo "::set-output name=count::$?"
+# id: pyfiles
tests-kubernetes:
timeout-minutes: 80
- name: "kubernetes-test-${{matrix.kube-mode}}-kube"
+ name: "K: ${{matrix.kube-mode}} ${{matrix.python-version}} ${{matrix.kubernetes-version}}"
Review comment:
```suggestion
name: "k8s: ${{matrix.kube-mode}} ${{matrix.python-version}} ${{matrix.kubernetes-version}}"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org