[jira] [Commented] (HADOOP-12258) Need translate java.nio.file.NoSuchFileException to FileNotFoundException to avoid regression

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650199#comment-14650199 ] 

Hadoop QA commented on HADOOP-12258:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  19m 58s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 13 new or modified test files. |
| {color:green}+1{color} | javac |   8m  8s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 42s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   2m 16s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   4m 54s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |  20m 34s | Tests failed in hadoop-common. |
| {color:red}-1{color} | hdfs tests |  64m  5s | Tests failed in hadoop-hdfs. |
| | | 133m 12s | |
\\
\\
|| Reason || Tests ||
| Timed out tests | org.apache.hadoop.io.compress.TestCodec |
|   | org.apache.hadoop.ha.TestZKFailoverControllerStress |
|   | org.apache.hadoop.metrics2.lib.TestMutableMetrics |
|   | org.apache.hadoop.hdfs.web.TestWebHDFS |
|   | org.apache.hadoop.hdfs.TestFileCreationDelete |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12748292/HADOOP-12258.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 90b5104 |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7391/artifact/patchprocess/testrun_hadoop-common.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7391/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7391/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7391/console |


This message was automatically generated.

> Need translate java.nio.file.NoSuchFileException to FileNotFoundException to avoid regression
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12258
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12258
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Critical
>         Attachments: HADOOP-12258.000.patch, HADOOP-12258.001.patch
>
>
> need translate java.nio.file.NoSuchFileException to FileNotFoundException to avoid regression.
> HADOOP-12045 adds nio to support access time, but nio will create java.nio.file.NoSuchFileException instead of FileNotFoundException.
> many hadoop codes depend on FileNotFoundException to decide whether a file exists. for example {{FileContext.util().exists()}}. 
> {code}
>     public boolean exists(final Path f) throws AccessControlException,
>       UnsupportedFileSystemException, IOException {
>       try {
>         FileStatus fs = FileContext.this.getFileStatus(f);
>         assert fs != null;
>         return true;
>       } catch (FileNotFoundException e) {
>         return false;
>       }
>     }
> {code}
> same for {{FileSystem#exists}}
> {code}
>   public boolean exists(Path f) throws IOException {
>     try {
>       return getFileStatus(f) != null;
>     } catch (FileNotFoundException e) {
>       return false;
>     }
>   }
> {code}
> NoSuchFileException will break these functions.
> Since {{exists}} is one of the most used API in FileSystem, this issue is very critical.
> Several test failures for TestDeletionService are caused by this issue:
> https://builds.apache.org/job/PreCommit-YARN-Build/8630/testReport/org.apache.hadoop.yarn.server.nodemanager/TestDeletionService/testRelativeDelete/
> https://builds.apache.org/job/PreCommit-YARN-Build/8632/testReport/org.apache.hadoop.yarn.server.nodemanager/TestDeletionService/testAbsDelete/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)