You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/18 13:22:58 UTC

[GitHub] [camel-k] nicolaferraro opened a new pull request #2582: Fix #2486: make kamelet binding scalable

nicolaferraro opened a new pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582


   <!-- Description -->
   
   Fix #2486
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   KameletBinding resources are now scalable
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] nicolaferraro edited a comment on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
nicolaferraro edited a comment on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901744229


   > > Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...
   > 
   > Hum, I would suspect the test client schema is not setup correctly somehow, possibly the KameletBinding type is not registered correctly... But I cannot find anything obvious :(
   
   Yeah, I've regenerated everything and I've also managed to install the same kind version, but nothing. I'd think to a transient error if that didn't happen on openshift (3.11) as well..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901739027


   > Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...
   
   Hum, I would suspect the test client schema is not setup correctly somehow, possibly the KameletBinding type is not registered correctly... But I cannot find anything obvious :(
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] nicolaferraro commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901744229


   > > Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...
   > 
   > Hum, I would suspect the test client schema is not setup correctly somehow, possibly the KameletBinding type is not registered correctly... But I cannot find anything obvious :(
   
   Yeah, I've regenerated everything and I've also managed to install the same kind version, but nothing. I'd think to a transient error if that didn't happen on minishift as well..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] nicolaferraro commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901717152


   > A quick _Scaling > Kamelet_ documentation entry could be worth it, along with the exiting integration scaling documentation:
   > 
   > https://camel.apache.org/camel-k/latest/scaling/integration.html
   
   Sure, I can add it.
   
   Any idea of what's happening? I'm unable to replicate on minikube. For some reason a simple (full) replace with only the "replicas" field chaned fails in the test...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901713100


   A quick _Scaling > Kamelet_ documentation entry could be worth it, along with the exiting integration scaling documentation:
   
   https://camel.apache.org/camel-k/latest/scaling/integration.html
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901747316


   > Yeah, I've regenerated everything and I've also managed to install the same kind version, but nothing. I'd think to a transient error if that didn't happen on openshift (3.11) as well..
   
   Yes, it's very strange since it's the exact same logic used for the integration scaling tests... I wonder if there is nothing specific about the way we initialise the test client, but I don't see anything obvious...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] nicolaferraro commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901974078


   > I wonder if there is something going on with the fast mapper thing, with a group having multiple versions...
   
   mmh, disabled fastmapper in previous run.. same result..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-902578755


   It may be `TestClient().Get(TestContext, key, &klb)` updates the `klb` struct with an empty Kind for some reasons. That would explain why patching works, while update fails. Still, it is troublesome the `Get` call does not work for `KameletBinding` while it works for `Integration`... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582#issuecomment-901754054


   I wonder if there is something going on with the fast mapper thing, with a group having multiple versions...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti merged pull request #2582: Fix #2486: make kamelet binding scalable

Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2582:
URL: https://github.com/apache/camel-k/pull/2582


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org