[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

[GitBox <gi...@apache.org>]

codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways
URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363275316
 
 

 ##########
 File path: conf/config.yaml
 ##########
 @@ -67,6 +67,7 @@ nginx_config:                     # config for render the template to genarate n
     client_header_timeout: 60s     # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client
     client_body_timeout: 60s       # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client
     send_timeout: 10s              # timeout for transmitting a response to the client.then the connection is closed
+    underscores_in_headers: "on"   # default enables the use of underscores in client request header fields
 
 Review comment:
   I need to validate the header name and cookie name .
   ```lua
   _M.upstream_hash_header_schema = {
       type = "string",
       pattern = [[^[a-zA-Z0-9-_]+$]]
   }
   ```
   if underscores_in_headers  not on,  header name with `_`  character is not allow.
   Maybe we can turn underscores on by default, how about this?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services