You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2015/04/21 21:56:54 UTC
[GitHub] trafficserver pull request: TS-3536: Fix memory leak in post proce...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/187
TS-3536: Fix memory leak in post processing.
With this change, we effectively undo the last of the fix for ts-2497. I would like people to take a look. Feifei and I have looked it over, and we have been running this in production for a month or so without problems. But since the deallocate_buffers was original removed to avoid a crash, I'd appreciate other people's analyses.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-3536
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit 0cb959e9d6fee20412afa8204b6159ebbfb1565b
Author: shinrich <sh...@yahoo-inc.com>
Date: 2015-04-20T23:01:46Z
TS-3536: Fix memory leak in post processing.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3536: Fix memory leak in post proce...
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/187#issuecomment-96694925
@bgaff might want to take a look here :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3536: Fix memory leak in post proce...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/187#issuecomment-96906684
I honestly don't remember what the initial issue was. If Yahoo is using this in prod w/out issues I vote land it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3536: Fix memory leak in post proce...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---