[GitHub] [druid] kfaraz commented on a diff in pull request #12759: Surface more information about task status in tests

[GitBox <gi...@apache.org>]

kfaraz commented on code in PR #12759:
URL: https://github.com/apache/druid/pull/12759#discussion_r917546590


##########
indexing-service/src/test/java/org/apache/druid/indexing/worker/shuffle/LocalIntermediaryDataManagerAutoCleanupTest.java:
##########
@@ -144,8 +146,8 @@ private boolean isCleanedUpAfter2s(String supervisorTaskId, Period timeoutPeriod
     // Start the data manager and the cleanup cycle
     intermediaryDataManager.start();
 
-    // Check the state of the partition after 2s
-    Thread.sleep(2000);
+    // Check the state of the partition after 3s
+    Thread.sleep(3000);

Review Comment:
   Thanks for fixing this, @abhishekagarwal87 . I guess the 2s was causing some flakiness if the cleanup tick was missed.



##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/AbstractMultiPhaseParallelIndexingTest.java:
##########
@@ -176,7 +176,7 @@ void runTaskAndVerifyStatus(Task task, TaskState expectedTaskStatus)
   {
     task.addToContext(Tasks.FORCE_TIME_CHUNK_LOCK_KEY, lockGranularity == LockGranularity.TIME_CHUNK);
     TaskStatus taskStatus = getIndexingServiceClient().runAndWait(task);
-    Assert.assertEquals(expectedTaskStatus, taskStatus.getStatusCode());
+    Assert.assertEquals(taskStatus.toString(), expectedTaskStatus, taskStatus.getStatusCode());

Review Comment:
   Maybe a longer message like: "Expected task status to be ..."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org