You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/07/15 05:28:28 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #624: GUACAMOLE-724: Remove duplicate injection of $rootScope (already injected via parameter).
mike-jumper opened a new pull request #624:
URL: https://github.com/apache/guacamole-client/pull/624
As of #623, visiting a deployment of the latest `master` fails with the following error in browser devtools:
```
Uncaught Error: Module parse failed: Identifier '$rootScope' has already been declared (41:10)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| const $document = $injector.get('$document');
| const $q = $injector.get('$q');
> const $rootScope = $injector.get('$rootScope');
| const $window = $injector.get('$window');
| const activeConnectionService = $injector.get('activeConnectionService');
<anonymous> http://localhost:8080/guacamole/guacamole.dc07c6323ec1d94a3644.js:306
g http://localhost:8080/guacamole/guacamole.dc07c6323ec1d94a3644.js:53
g http://localhost:8080/guacamole/guacamole.dc07c6323ec1d94a3644.js:230
<anonymous> http://localhost:8080/guacamole/guacamole.dc07c6323ec1d94a3644.js:55
<anonymous> http://localhost:8080/guacamole/guacamole.dc07c6323ec1d94a3644.js:55
g http://localhost:8080/guacamole/guacamole.dc07c6323ec1d94a3644.js:53
```
This is because `$rootScope` is being injected both through function parameters and through explicitly invoking `$injector`. Only one declaration and injection of `$rootScope` should be present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #624: GUACAMOLE-724: Remove duplicate injection of $rootScope (already injected via parameter).
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #624:
URL: https://github.com/apache/guacamole-client/pull/624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org