[GitHub] [airflow] o-nikolas commented on a diff in pull request #28817: Fix Unable to fetch logs from worker pod error in UI for k8s executor

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #28817:
URL: https://github.com/apache/airflow/pull/28817#discussion_r1106495625


##########
airflow/executors/base_executor.py:
##########
@@ -356,13 +356,13 @@ def execute_async(
         """
         raise NotImplementedError()
 
-    def get_task_log(self, ti: TaskInstance) -> tuple[list[str], list[str]]:
+    def get_task_log(self, ti: TaskInstance, try_number: int) -> tuple[list[str], list[str]]:
         """

Review Comment:
   There is some explanation in the code for `read`: https://github.com/apache/airflow/blob/c266aacf39a2f01cb3f91740f448934c7b3fd7be/airflow/utils/log/file_task_handler.py#L376-L410
   
   `try_number` is plumbed in from `read` to `_read` and then should have been sent to the executors, but it was a miss:
   https://github.com/apache/airflow/blob/c266aacf39a2f01cb3f91740f448934c7b3fd7be/airflow/utils/log/file_task_handler.py#L274-L315



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org