[GitHub] [flink] KarmaGYZ commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test

[GitBox <gi...@apache.org>]

KarmaGYZ commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363569355
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -748,7 +748,7 @@ function retry_times_with_backoff_and_cleanup() {
     local command="$3"
     local cleanup_command="$4"
 
-    for (( i = 0; i < ${retriesNumber}; i++ ))
+    for i in $(seq 1 ${retriesNumber})
 
 Review comment:
   This block of loop will only executes 1 time in this scenario. I found that there is also a for loop  in start_confluent_schema_registry function:
   ```
   for i in {1..30}; do
       if get_and_verify_schema_subjects_exist; then
           echo "Schema registry is up."
           return 0
       fi
       echo "Waiting for schema registry..."
       sleep 1
     done
   ```
   The variable i  is set to 30 after this function, which cause the loop end after only 1 execute. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services