You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jdeppe-pivotal (GitHub)" <gi...@apache.org> on 2018/11/29 23:52:48 UTC

[GitHub] [geode] jdeppe-pivotal opened pull request #2924: GEODE-6113: Unable to run geode-web http-based dunit tests in IntelliJ

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2924 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2924: GEODE-6113: Unable to run geode-web http-based dunit tests in IntelliJ

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Should `spring-core` also be excluded by the `compile` configuration in `:geode-lucene`'s `build.gradle`?

```
compile('org.springframework.shell:spring-shell:' + project.'spring-shell.version')
  {
    exclude module: 'aopalliance'
    exclude module: 'asm'
    exclude module: 'cglib'
    exclude module: 'guava'
    exclude module: 'spring-aop'
    exclude module: 'spring-context-support'
    ext.optional = true
  }
```

[ Full content available at: https://github.com/apache/geode/pull/2924 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #2924: GEODE-6113: Unable to run geode-web http-based dunit tests in IntelliJ

Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2924 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org