You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2015/08/26 15:35:11 UTC

[GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig

GitHub user mtaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/138

    Pass JNDI name in XARecoveryConfig

    Some TX managers require JNDI name for recovery purposes.  This patch
    passes JNDI name in RA to RecoveryRegistry implementations via
    XARecoveryConfig objects.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtaylor/activemq-artemis jndiNameInRecoverConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit 696ac53e31f1cb659394399f069cc27d4d21bdd8
Author: Martyn Taylor <mt...@redhat.com>
Date:   2015-08-26T12:40:55Z

    Pass JNDI name in XARecoveryConfig
    
    Some TX managers require JNDI name for recovery purposes.  This patch
    passes JNDI name in RA to RecoveryRegistry implementations via
    XARecoveryConfig objects.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig

Posted by mtaylor <gi...@git.apache.org>.

Github user mtaylor commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/138#issuecomment-135028663
  
    @clebertsuconic I'll change this so it passes in a map of properties as discussed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/138#issuecomment-135026215
  
    I just think the parameter name jndiName is a too generic name.. it's not clear if that means the connectionFactory or the TM...
    
    
    I would rename it to something else with its purpose.. such as tmRegistry, recoveryRegistry, etc...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/138#issuecomment-135510240
  
    I thought about having everything just using BeanUtils, and converting properties to avoid these constants.. but on a second thought it was more hassle than worth.
    
    I'm merging this... sorry for the confusion.. I wanted to improve things but in the end it would be a lot of work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Pass JNDI name in XARecoveryConfig

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/138#issuecomment-135451866
  
    I'm looking at this.. please don't merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---