You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/11/27 14:52:40 UTC
[08/26] hbase-site git commit: Published site at
6f15cecaed2f1f76bfe1880b7c578ed369daa5d5.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/dccdd274/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.IndexCacheEntry.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.IndexCacheEntry.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.IndexCacheEntry.html
index f8e34f2..ea22449 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.IndexCacheEntry.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.IndexCacheEntry.html
@@ -217,184 +217,188 @@
<span class="sourceLineNo">209</span> @Test<a name="line.209"></a>
<span class="sourceLineNo">210</span> public void testDisableCacheDataBlock() throws IOException {<a name="line.210"></a>
<span class="sourceLineNo">211</span> Configuration conf = HBaseConfiguration.create();<a name="line.211"></a>
-<span class="sourceLineNo">212</span> CacheConfig cacheConfig = new CacheConfig(conf);<a name="line.212"></a>
-<span class="sourceLineNo">213</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.213"></a>
-<span class="sourceLineNo">214</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.214"></a>
-<span class="sourceLineNo">215</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.215"></a>
-<span class="sourceLineNo">216</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.216"></a>
-<span class="sourceLineNo">217</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.217"></a>
-<span class="sourceLineNo">218</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.218"></a>
-<span class="sourceLineNo">219</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.219"></a>
-<span class="sourceLineNo">220</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.220"></a>
-<span class="sourceLineNo">221</span> assertFalse(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.221"></a>
-<span class="sourceLineNo">222</span> assertFalse(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.222"></a>
-<span class="sourceLineNo">223</span><a name="line.223"></a>
-<span class="sourceLineNo">224</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, true);<a name="line.224"></a>
-<span class="sourceLineNo">225</span> conf.setBoolean(CacheConfig.CACHE_DATA_BLOCKS_COMPRESSED_KEY, true);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> conf.setBoolean(CacheConfig.CACHE_BLOOM_BLOCKS_ON_WRITE_KEY, true);<a name="line.226"></a>
-<span class="sourceLineNo">227</span> conf.setBoolean(CacheConfig.CACHE_INDEX_BLOCKS_ON_WRITE_KEY, true);<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span> cacheConfig = new CacheConfig(conf);<a name="line.229"></a>
-<span class="sourceLineNo">230</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.230"></a>
-<span class="sourceLineNo">231</span> assertTrue(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.231"></a>
-<span class="sourceLineNo">232</span> assertTrue(cacheConfig.shouldCacheDataCompressed());<a name="line.232"></a>
-<span class="sourceLineNo">233</span> assertTrue(cacheConfig.shouldCacheDataOnWrite());<a name="line.233"></a>
-<span class="sourceLineNo">234</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.234"></a>
-<span class="sourceLineNo">235</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.235"></a>
-<span class="sourceLineNo">236</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.236"></a>
-<span class="sourceLineNo">237</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.237"></a>
-<span class="sourceLineNo">238</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.238"></a>
-<span class="sourceLineNo">239</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, false);<a name="line.241"></a>
-<span class="sourceLineNo">242</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.242"></a>
-<span class="sourceLineNo">243</span><a name="line.243"></a>
-<span class="sourceLineNo">244</span> cacheConfig = new CacheConfig(conf);<a name="line.244"></a>
-<span class="sourceLineNo">245</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.245"></a>
-<span class="sourceLineNo">246</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.246"></a>
-<span class="sourceLineNo">247</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.247"></a>
-<span class="sourceLineNo">248</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.248"></a>
-<span class="sourceLineNo">249</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.249"></a>
-<span class="sourceLineNo">250</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.250"></a>
-<span class="sourceLineNo">251</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.251"></a>
-<span class="sourceLineNo">252</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.252"></a>
-<span class="sourceLineNo">253</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.253"></a>
-<span class="sourceLineNo">254</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.254"></a>
-<span class="sourceLineNo">255</span><a name="line.255"></a>
-<span class="sourceLineNo">256</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, true);<a name="line.256"></a>
-<span class="sourceLineNo">257</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.257"></a>
-<span class="sourceLineNo">258</span><a name="line.258"></a>
-<span class="sourceLineNo">259</span> HColumnDescriptor family = new HColumnDescriptor("testDisableCacheDataBlock");<a name="line.259"></a>
-<span class="sourceLineNo">260</span> family.setBlockCacheEnabled(false);<a name="line.260"></a>
-<span class="sourceLineNo">261</span><a name="line.261"></a>
-<span class="sourceLineNo">262</span> cacheConfig = new CacheConfig(conf, family);<a name="line.262"></a>
-<span class="sourceLineNo">263</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.263"></a>
-<span class="sourceLineNo">264</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.264"></a>
-<span class="sourceLineNo">265</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.265"></a>
-<span class="sourceLineNo">266</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.266"></a>
-<span class="sourceLineNo">267</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.267"></a>
-<span class="sourceLineNo">268</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.268"></a>
-<span class="sourceLineNo">269</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.269"></a>
-<span class="sourceLineNo">270</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.270"></a>
-<span class="sourceLineNo">271</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.271"></a>
-<span class="sourceLineNo">272</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span> @Test<a name="line.275"></a>
-<span class="sourceLineNo">276</span> public void testCacheConfigDefaultLRUBlockCache() {<a name="line.276"></a>
-<span class="sourceLineNo">277</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.277"></a>
-<span class="sourceLineNo">278</span> assertTrue(cc.isBlockCacheEnabled());<a name="line.278"></a>
-<span class="sourceLineNo">279</span> assertTrue(CacheConfig.DEFAULT_IN_MEMORY == cc.isInMemory());<a name="line.279"></a>
-<span class="sourceLineNo">280</span> basicBlockCacheOps(cc, false, true);<a name="line.280"></a>
-<span class="sourceLineNo">281</span> assertTrue(cc.getBlockCache() instanceof LruBlockCache);<a name="line.281"></a>
-<span class="sourceLineNo">282</span> }<a name="line.282"></a>
-<span class="sourceLineNo">283</span><a name="line.283"></a>
-<span class="sourceLineNo">284</span> /**<a name="line.284"></a>
-<span class="sourceLineNo">285</span> * Assert that the caches are deployed with CombinedBlockCache and of the appropriate sizes.<a name="line.285"></a>
-<span class="sourceLineNo">286</span> */<a name="line.286"></a>
-<span class="sourceLineNo">287</span> @Test<a name="line.287"></a>
-<span class="sourceLineNo">288</span> public void testOffHeapBucketCacheConfig() {<a name="line.288"></a>
-<span class="sourceLineNo">289</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.289"></a>
-<span class="sourceLineNo">290</span> doBucketCacheConfigTest();<a name="line.290"></a>
-<span class="sourceLineNo">291</span> }<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span> @Test<a name="line.293"></a>
-<span class="sourceLineNo">294</span> public void testFileBucketCacheConfig() throws IOException {<a name="line.294"></a>
-<span class="sourceLineNo">295</span> HBaseTestingUtility htu = new HBaseTestingUtility(this.conf);<a name="line.295"></a>
-<span class="sourceLineNo">296</span> try {<a name="line.296"></a>
-<span class="sourceLineNo">297</span> Path p = new Path(htu.getDataTestDir(), "bc.txt");<a name="line.297"></a>
-<span class="sourceLineNo">298</span> FileSystem fs = FileSystem.get(this.conf);<a name="line.298"></a>
-<span class="sourceLineNo">299</span> fs.create(p).close();<a name="line.299"></a>
-<span class="sourceLineNo">300</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "file:" + p);<a name="line.300"></a>
-<span class="sourceLineNo">301</span> doBucketCacheConfigTest();<a name="line.301"></a>
-<span class="sourceLineNo">302</span> } finally {<a name="line.302"></a>
-<span class="sourceLineNo">303</span> htu.cleanupTestDir();<a name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> }<a name="line.305"></a>
-<span class="sourceLineNo">306</span><a name="line.306"></a>
-<span class="sourceLineNo">307</span> private void doBucketCacheConfigTest() {<a name="line.307"></a>
-<span class="sourceLineNo">308</span> final int bcSize = 100;<a name="line.308"></a>
-<span class="sourceLineNo">309</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.309"></a>
-<span class="sourceLineNo">310</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.310"></a>
-<span class="sourceLineNo">311</span> basicBlockCacheOps(cc, false, false);<a name="line.311"></a>
-<span class="sourceLineNo">312</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.312"></a>
-<span class="sourceLineNo">313</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.313"></a>
-<span class="sourceLineNo">314</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.314"></a>
-<span class="sourceLineNo">315</span> BlockCache [] bcs = cbc.getBlockCaches();<a name="line.315"></a>
-<span class="sourceLineNo">316</span> assertTrue(bcs[0] instanceof LruBlockCache);<a name="line.316"></a>
-<span class="sourceLineNo">317</span> LruBlockCache lbc = (LruBlockCache)bcs[0];<a name="line.317"></a>
-<span class="sourceLineNo">318</span> assertEquals(MemorySizeUtil.getOnHeapCacheSize(this.conf), lbc.getMaxSize());<a name="line.318"></a>
-<span class="sourceLineNo">319</span> assertTrue(bcs[1] instanceof BucketCache);<a name="line.319"></a>
-<span class="sourceLineNo">320</span> BucketCache bc = (BucketCache)bcs[1];<a name="line.320"></a>
-<span class="sourceLineNo">321</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.321"></a>
-<span class="sourceLineNo">322</span> assertEquals(bcSize, bc.getMaxSize() / (1024 * 1024));<a name="line.322"></a>
-<span class="sourceLineNo">323</span> }<a name="line.323"></a>
-<span class="sourceLineNo">324</span><a name="line.324"></a>
-<span class="sourceLineNo">325</span> /**<a name="line.325"></a>
-<span class="sourceLineNo">326</span> * Assert that when BUCKET_CACHE_COMBINED_KEY is false, the non-default, that we deploy<a name="line.326"></a>
-<span class="sourceLineNo">327</span> * LruBlockCache as L1 with a BucketCache for L2.<a name="line.327"></a>
-<span class="sourceLineNo">328</span> */<a name="line.328"></a>
-<span class="sourceLineNo">329</span> @Test<a name="line.329"></a>
-<span class="sourceLineNo">330</span> public void testBucketCacheConfigL1L2Setup() {<a name="line.330"></a>
-<span class="sourceLineNo">331</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.331"></a>
-<span class="sourceLineNo">332</span> // Make lru size is smaller than bcSize for sure. Need this to be true so when eviction<a name="line.332"></a>
-<span class="sourceLineNo">333</span> // from L1 happens, it does not fail because L2 can't take the eviction because block too big.<a name="line.333"></a>
-<span class="sourceLineNo">334</span> this.conf.setFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, 0.001f);<a name="line.334"></a>
-<span class="sourceLineNo">335</span> MemoryUsage mu = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();<a name="line.335"></a>
-<span class="sourceLineNo">336</span> long lruExpectedSize = MemorySizeUtil.getOnHeapCacheSize(this.conf);<a name="line.336"></a>
-<span class="sourceLineNo">337</span> final int bcSize = 100;<a name="line.337"></a>
-<span class="sourceLineNo">338</span> long bcExpectedSize = 100 * 1024 * 1024; // MB.<a name="line.338"></a>
-<span class="sourceLineNo">339</span> assertTrue(lruExpectedSize < bcExpectedSize);<a name="line.339"></a>
-<span class="sourceLineNo">340</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.340"></a>
-<span class="sourceLineNo">341</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.341"></a>
-<span class="sourceLineNo">342</span> basicBlockCacheOps(cc, false, false);<a name="line.342"></a>
-<span class="sourceLineNo">343</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.343"></a>
-<span class="sourceLineNo">344</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.344"></a>
-<span class="sourceLineNo">345</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.345"></a>
-<span class="sourceLineNo">346</span> LruBlockCache lbc = cbc.onHeapCache;<a name="line.346"></a>
-<span class="sourceLineNo">347</span> assertEquals(lruExpectedSize, lbc.getMaxSize());<a name="line.347"></a>
-<span class="sourceLineNo">348</span> BlockCache bc = cbc.l2Cache;<a name="line.348"></a>
-<span class="sourceLineNo">349</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.349"></a>
-<span class="sourceLineNo">350</span> assertEquals(bcExpectedSize, ((BucketCache) bc).getMaxSize());<a name="line.350"></a>
-<span class="sourceLineNo">351</span> // Test the L1+L2 deploy works as we'd expect with blocks evicted from L1 going to L2.<a name="line.351"></a>
-<span class="sourceLineNo">352</span> long initialL1BlockCount = lbc.getBlockCount();<a name="line.352"></a>
-<span class="sourceLineNo">353</span> long initialL2BlockCount = bc.getBlockCount();<a name="line.353"></a>
-<span class="sourceLineNo">354</span> Cacheable c = new DataCacheEntry();<a name="line.354"></a>
-<span class="sourceLineNo">355</span> BlockCacheKey bck = new BlockCacheKey("bck", 0);<a name="line.355"></a>
-<span class="sourceLineNo">356</span> lbc.cacheBlock(bck, c, false);<a name="line.356"></a>
-<span class="sourceLineNo">357</span> assertEquals(initialL1BlockCount + 1, lbc.getBlockCount());<a name="line.357"></a>
-<span class="sourceLineNo">358</span> assertEquals(initialL2BlockCount, bc.getBlockCount());<a name="line.358"></a>
-<span class="sourceLineNo">359</span> // Force evictions by putting in a block too big.<a name="line.359"></a>
-<span class="sourceLineNo">360</span> final long justTooBigSize = lbc.acceptableSize() + 1;<a name="line.360"></a>
-<span class="sourceLineNo">361</span> lbc.cacheBlock(new BlockCacheKey("bck2", 0), new DataCacheEntry() {<a name="line.361"></a>
-<span class="sourceLineNo">362</span> @Override<a name="line.362"></a>
-<span class="sourceLineNo">363</span> public long heapSize() {<a name="line.363"></a>
-<span class="sourceLineNo">364</span> return justTooBigSize;<a name="line.364"></a>
-<span class="sourceLineNo">365</span> }<a name="line.365"></a>
-<span class="sourceLineNo">366</span><a name="line.366"></a>
-<span class="sourceLineNo">367</span> @Override<a name="line.367"></a>
-<span class="sourceLineNo">368</span> public int getSerializedLength() {<a name="line.368"></a>
-<span class="sourceLineNo">369</span> return (int)heapSize();<a name="line.369"></a>
-<span class="sourceLineNo">370</span> }<a name="line.370"></a>
-<span class="sourceLineNo">371</span> });<a name="line.371"></a>
-<span class="sourceLineNo">372</span> // The eviction thread in lrublockcache needs to run.<a name="line.372"></a>
-<span class="sourceLineNo">373</span> while (initialL1BlockCount != lbc.getBlockCount()) Threads.sleep(10);<a name="line.373"></a>
-<span class="sourceLineNo">374</span> assertEquals(initialL1BlockCount, lbc.getBlockCount());<a name="line.374"></a>
-<span class="sourceLineNo">375</span> }<a name="line.375"></a>
-<span class="sourceLineNo">376</span><a name="line.376"></a>
-<span class="sourceLineNo">377</span> @Test<a name="line.377"></a>
-<span class="sourceLineNo">378</span> public void testL2CacheWithInvalidBucketSize() {<a name="line.378"></a>
-<span class="sourceLineNo">379</span> Configuration c = new Configuration(this.conf);<a name="line.379"></a>
-<span class="sourceLineNo">380</span> c.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.380"></a>
-<span class="sourceLineNo">381</span> c.set(CacheConfig.BUCKET_CACHE_BUCKETS_KEY, "256,512,1024,2048,4000,4096");<a name="line.381"></a>
-<span class="sourceLineNo">382</span> c.setFloat(HConstants.BUCKET_CACHE_SIZE_KEY, 1024);<a name="line.382"></a>
-<span class="sourceLineNo">383</span> try {<a name="line.383"></a>
-<span class="sourceLineNo">384</span> CacheConfig.getBucketCache(c);<a name="line.384"></a>
-<span class="sourceLineNo">385</span> fail("Should throw IllegalArgumentException when passing illegal value for bucket size");<a name="line.385"></a>
-<span class="sourceLineNo">386</span> } catch (IllegalArgumentException e) {<a name="line.386"></a>
-<span class="sourceLineNo">387</span> }<a name="line.387"></a>
-<span class="sourceLineNo">388</span> }<a name="line.388"></a>
-<span class="sourceLineNo">389</span>}<a name="line.389"></a>
+<span class="sourceLineNo">212</span> CacheConfig.instantiateBlockCache(conf);<a name="line.212"></a>
+<span class="sourceLineNo">213</span> CacheConfig cacheConfig = new CacheConfig(conf);<a name="line.213"></a>
+<span class="sourceLineNo">214</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.214"></a>
+<span class="sourceLineNo">215</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.215"></a>
+<span class="sourceLineNo">216</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.216"></a>
+<span class="sourceLineNo">217</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.217"></a>
+<span class="sourceLineNo">218</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.218"></a>
+<span class="sourceLineNo">219</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.219"></a>
+<span class="sourceLineNo">220</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.220"></a>
+<span class="sourceLineNo">221</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.221"></a>
+<span class="sourceLineNo">222</span> assertFalse(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.222"></a>
+<span class="sourceLineNo">223</span> assertFalse(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.223"></a>
+<span class="sourceLineNo">224</span><a name="line.224"></a>
+<span class="sourceLineNo">225</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, true);<a name="line.225"></a>
+<span class="sourceLineNo">226</span> conf.setBoolean(CacheConfig.CACHE_DATA_BLOCKS_COMPRESSED_KEY, true);<a name="line.226"></a>
+<span class="sourceLineNo">227</span> conf.setBoolean(CacheConfig.CACHE_BLOOM_BLOCKS_ON_WRITE_KEY, true);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> conf.setBoolean(CacheConfig.CACHE_INDEX_BLOCKS_ON_WRITE_KEY, true);<a name="line.228"></a>
+<span class="sourceLineNo">229</span><a name="line.229"></a>
+<span class="sourceLineNo">230</span> cacheConfig = new CacheConfig(conf);<a name="line.230"></a>
+<span class="sourceLineNo">231</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.231"></a>
+<span class="sourceLineNo">232</span> assertTrue(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.232"></a>
+<span class="sourceLineNo">233</span> assertTrue(cacheConfig.shouldCacheDataCompressed());<a name="line.233"></a>
+<span class="sourceLineNo">234</span> assertTrue(cacheConfig.shouldCacheDataOnWrite());<a name="line.234"></a>
+<span class="sourceLineNo">235</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.235"></a>
+<span class="sourceLineNo">236</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.236"></a>
+<span class="sourceLineNo">237</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.237"></a>
+<span class="sourceLineNo">238</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.238"></a>
+<span class="sourceLineNo">239</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.239"></a>
+<span class="sourceLineNo">240</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.240"></a>
+<span class="sourceLineNo">241</span><a name="line.241"></a>
+<span class="sourceLineNo">242</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, false);<a name="line.242"></a>
+<span class="sourceLineNo">243</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.243"></a>
+<span class="sourceLineNo">244</span><a name="line.244"></a>
+<span class="sourceLineNo">245</span> cacheConfig = new CacheConfig(conf);<a name="line.245"></a>
+<span class="sourceLineNo">246</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.246"></a>
+<span class="sourceLineNo">247</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.247"></a>
+<span class="sourceLineNo">248</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.248"></a>
+<span class="sourceLineNo">249</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.249"></a>
+<span class="sourceLineNo">250</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.250"></a>
+<span class="sourceLineNo">251</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.251"></a>
+<span class="sourceLineNo">252</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.252"></a>
+<span class="sourceLineNo">253</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.253"></a>
+<span class="sourceLineNo">254</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.254"></a>
+<span class="sourceLineNo">255</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.255"></a>
+<span class="sourceLineNo">256</span><a name="line.256"></a>
+<span class="sourceLineNo">257</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, true);<a name="line.257"></a>
+<span class="sourceLineNo">258</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> HColumnDescriptor family = new HColumnDescriptor("testDisableCacheDataBlock");<a name="line.260"></a>
+<span class="sourceLineNo">261</span> family.setBlockCacheEnabled(false);<a name="line.261"></a>
+<span class="sourceLineNo">262</span><a name="line.262"></a>
+<span class="sourceLineNo">263</span> cacheConfig = new CacheConfig(conf, family);<a name="line.263"></a>
+<span class="sourceLineNo">264</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.264"></a>
+<span class="sourceLineNo">265</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.265"></a>
+<span class="sourceLineNo">266</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.266"></a>
+<span class="sourceLineNo">267</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.267"></a>
+<span class="sourceLineNo">268</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.268"></a>
+<span class="sourceLineNo">269</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.269"></a>
+<span class="sourceLineNo">270</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.270"></a>
+<span class="sourceLineNo">271</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.271"></a>
+<span class="sourceLineNo">272</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.272"></a>
+<span class="sourceLineNo">273</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.273"></a>
+<span class="sourceLineNo">274</span> }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> @Test<a name="line.276"></a>
+<span class="sourceLineNo">277</span> public void testCacheConfigDefaultLRUBlockCache() {<a name="line.277"></a>
+<span class="sourceLineNo">278</span> CacheConfig.instantiateBlockCache(this.conf);<a name="line.278"></a>
+<span class="sourceLineNo">279</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.279"></a>
+<span class="sourceLineNo">280</span> assertTrue(cc.isBlockCacheEnabled());<a name="line.280"></a>
+<span class="sourceLineNo">281</span> assertTrue(CacheConfig.DEFAULT_IN_MEMORY == cc.isInMemory());<a name="line.281"></a>
+<span class="sourceLineNo">282</span> basicBlockCacheOps(cc, false, true);<a name="line.282"></a>
+<span class="sourceLineNo">283</span> assertTrue(cc.getBlockCache() instanceof LruBlockCache);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> }<a name="line.284"></a>
+<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">286</span> /**<a name="line.286"></a>
+<span class="sourceLineNo">287</span> * Assert that the caches are deployed with CombinedBlockCache and of the appropriate sizes.<a name="line.287"></a>
+<span class="sourceLineNo">288</span> */<a name="line.288"></a>
+<span class="sourceLineNo">289</span> @Test<a name="line.289"></a>
+<span class="sourceLineNo">290</span> public void testOffHeapBucketCacheConfig() {<a name="line.290"></a>
+<span class="sourceLineNo">291</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.291"></a>
+<span class="sourceLineNo">292</span> doBucketCacheConfigTest();<a name="line.292"></a>
+<span class="sourceLineNo">293</span> }<a name="line.293"></a>
+<span class="sourceLineNo">294</span><a name="line.294"></a>
+<span class="sourceLineNo">295</span> @Test<a name="line.295"></a>
+<span class="sourceLineNo">296</span> public void testFileBucketCacheConfig() throws IOException {<a name="line.296"></a>
+<span class="sourceLineNo">297</span> HBaseTestingUtility htu = new HBaseTestingUtility(this.conf);<a name="line.297"></a>
+<span class="sourceLineNo">298</span> try {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> Path p = new Path(htu.getDataTestDir(), "bc.txt");<a name="line.299"></a>
+<span class="sourceLineNo">300</span> FileSystem fs = FileSystem.get(this.conf);<a name="line.300"></a>
+<span class="sourceLineNo">301</span> fs.create(p).close();<a name="line.301"></a>
+<span class="sourceLineNo">302</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "file:" + p);<a name="line.302"></a>
+<span class="sourceLineNo">303</span> doBucketCacheConfigTest();<a name="line.303"></a>
+<span class="sourceLineNo">304</span> } finally {<a name="line.304"></a>
+<span class="sourceLineNo">305</span> htu.cleanupTestDir();<a name="line.305"></a>
+<span class="sourceLineNo">306</span> }<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span> private void doBucketCacheConfigTest() {<a name="line.309"></a>
+<span class="sourceLineNo">310</span> final int bcSize = 100;<a name="line.310"></a>
+<span class="sourceLineNo">311</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.311"></a>
+<span class="sourceLineNo">312</span> CacheConfig.instantiateBlockCache(this.conf);<a name="line.312"></a>
+<span class="sourceLineNo">313</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.313"></a>
+<span class="sourceLineNo">314</span> basicBlockCacheOps(cc, false, false);<a name="line.314"></a>
+<span class="sourceLineNo">315</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.315"></a>
+<span class="sourceLineNo">316</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.316"></a>
+<span class="sourceLineNo">317</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.317"></a>
+<span class="sourceLineNo">318</span> BlockCache [] bcs = cbc.getBlockCaches();<a name="line.318"></a>
+<span class="sourceLineNo">319</span> assertTrue(bcs[0] instanceof LruBlockCache);<a name="line.319"></a>
+<span class="sourceLineNo">320</span> LruBlockCache lbc = (LruBlockCache)bcs[0];<a name="line.320"></a>
+<span class="sourceLineNo">321</span> assertEquals(MemorySizeUtil.getOnHeapCacheSize(this.conf), lbc.getMaxSize());<a name="line.321"></a>
+<span class="sourceLineNo">322</span> assertTrue(bcs[1] instanceof BucketCache);<a name="line.322"></a>
+<span class="sourceLineNo">323</span> BucketCache bc = (BucketCache)bcs[1];<a name="line.323"></a>
+<span class="sourceLineNo">324</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.324"></a>
+<span class="sourceLineNo">325</span> assertEquals(bcSize, bc.getMaxSize() / (1024 * 1024));<a name="line.325"></a>
+<span class="sourceLineNo">326</span> }<a name="line.326"></a>
+<span class="sourceLineNo">327</span><a name="line.327"></a>
+<span class="sourceLineNo">328</span> /**<a name="line.328"></a>
+<span class="sourceLineNo">329</span> * Assert that when BUCKET_CACHE_COMBINED_KEY is false, the non-default, that we deploy<a name="line.329"></a>
+<span class="sourceLineNo">330</span> * LruBlockCache as L1 with a BucketCache for L2.<a name="line.330"></a>
+<span class="sourceLineNo">331</span> */<a name="line.331"></a>
+<span class="sourceLineNo">332</span> @Test<a name="line.332"></a>
+<span class="sourceLineNo">333</span> public void testBucketCacheConfigL1L2Setup() {<a name="line.333"></a>
+<span class="sourceLineNo">334</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.334"></a>
+<span class="sourceLineNo">335</span> // Make lru size is smaller than bcSize for sure. Need this to be true so when eviction<a name="line.335"></a>
+<span class="sourceLineNo">336</span> // from L1 happens, it does not fail because L2 can't take the eviction because block too big.<a name="line.336"></a>
+<span class="sourceLineNo">337</span> this.conf.setFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, 0.001f);<a name="line.337"></a>
+<span class="sourceLineNo">338</span> MemoryUsage mu = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();<a name="line.338"></a>
+<span class="sourceLineNo">339</span> long lruExpectedSize = MemorySizeUtil.getOnHeapCacheSize(this.conf);<a name="line.339"></a>
+<span class="sourceLineNo">340</span> final int bcSize = 100;<a name="line.340"></a>
+<span class="sourceLineNo">341</span> long bcExpectedSize = 100 * 1024 * 1024; // MB.<a name="line.341"></a>
+<span class="sourceLineNo">342</span> assertTrue(lruExpectedSize < bcExpectedSize);<a name="line.342"></a>
+<span class="sourceLineNo">343</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.343"></a>
+<span class="sourceLineNo">344</span> CacheConfig.instantiateBlockCache(this.conf);<a name="line.344"></a>
+<span class="sourceLineNo">345</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.345"></a>
+<span class="sourceLineNo">346</span> basicBlockCacheOps(cc, false, false);<a name="line.346"></a>
+<span class="sourceLineNo">347</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.347"></a>
+<span class="sourceLineNo">348</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.348"></a>
+<span class="sourceLineNo">349</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.349"></a>
+<span class="sourceLineNo">350</span> LruBlockCache lbc = cbc.onHeapCache;<a name="line.350"></a>
+<span class="sourceLineNo">351</span> assertEquals(lruExpectedSize, lbc.getMaxSize());<a name="line.351"></a>
+<span class="sourceLineNo">352</span> BlockCache bc = cbc.l2Cache;<a name="line.352"></a>
+<span class="sourceLineNo">353</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.353"></a>
+<span class="sourceLineNo">354</span> assertEquals(bcExpectedSize, ((BucketCache) bc).getMaxSize());<a name="line.354"></a>
+<span class="sourceLineNo">355</span> // Test the L1+L2 deploy works as we'd expect with blocks evicted from L1 going to L2.<a name="line.355"></a>
+<span class="sourceLineNo">356</span> long initialL1BlockCount = lbc.getBlockCount();<a name="line.356"></a>
+<span class="sourceLineNo">357</span> long initialL2BlockCount = bc.getBlockCount();<a name="line.357"></a>
+<span class="sourceLineNo">358</span> Cacheable c = new DataCacheEntry();<a name="line.358"></a>
+<span class="sourceLineNo">359</span> BlockCacheKey bck = new BlockCacheKey("bck", 0);<a name="line.359"></a>
+<span class="sourceLineNo">360</span> lbc.cacheBlock(bck, c, false);<a name="line.360"></a>
+<span class="sourceLineNo">361</span> assertEquals(initialL1BlockCount + 1, lbc.getBlockCount());<a name="line.361"></a>
+<span class="sourceLineNo">362</span> assertEquals(initialL2BlockCount, bc.getBlockCount());<a name="line.362"></a>
+<span class="sourceLineNo">363</span> // Force evictions by putting in a block too big.<a name="line.363"></a>
+<span class="sourceLineNo">364</span> final long justTooBigSize = lbc.acceptableSize() + 1;<a name="line.364"></a>
+<span class="sourceLineNo">365</span> lbc.cacheBlock(new BlockCacheKey("bck2", 0), new DataCacheEntry() {<a name="line.365"></a>
+<span class="sourceLineNo">366</span> @Override<a name="line.366"></a>
+<span class="sourceLineNo">367</span> public long heapSize() {<a name="line.367"></a>
+<span class="sourceLineNo">368</span> return justTooBigSize;<a name="line.368"></a>
+<span class="sourceLineNo">369</span> }<a name="line.369"></a>
+<span class="sourceLineNo">370</span><a name="line.370"></a>
+<span class="sourceLineNo">371</span> @Override<a name="line.371"></a>
+<span class="sourceLineNo">372</span> public int getSerializedLength() {<a name="line.372"></a>
+<span class="sourceLineNo">373</span> return (int)heapSize();<a name="line.373"></a>
+<span class="sourceLineNo">374</span> }<a name="line.374"></a>
+<span class="sourceLineNo">375</span> });<a name="line.375"></a>
+<span class="sourceLineNo">376</span> // The eviction thread in lrublockcache needs to run.<a name="line.376"></a>
+<span class="sourceLineNo">377</span> while (initialL1BlockCount != lbc.getBlockCount()) Threads.sleep(10);<a name="line.377"></a>
+<span class="sourceLineNo">378</span> assertEquals(initialL1BlockCount, lbc.getBlockCount());<a name="line.378"></a>
+<span class="sourceLineNo">379</span> }<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span> @Test<a name="line.381"></a>
+<span class="sourceLineNo">382</span> public void testL2CacheWithInvalidBucketSize() {<a name="line.382"></a>
+<span class="sourceLineNo">383</span> Configuration c = new Configuration(this.conf);<a name="line.383"></a>
+<span class="sourceLineNo">384</span> c.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.384"></a>
+<span class="sourceLineNo">385</span> c.set(CacheConfig.BUCKET_CACHE_BUCKETS_KEY, "256,512,1024,2048,4000,4096");<a name="line.385"></a>
+<span class="sourceLineNo">386</span> c.setFloat(HConstants.BUCKET_CACHE_SIZE_KEY, 1024);<a name="line.386"></a>
+<span class="sourceLineNo">387</span> try {<a name="line.387"></a>
+<span class="sourceLineNo">388</span> CacheConfig.getBucketCache(c);<a name="line.388"></a>
+<span class="sourceLineNo">389</span> fail("Should throw IllegalArgumentException when passing illegal value for bucket size");<a name="line.389"></a>
+<span class="sourceLineNo">390</span> } catch (IllegalArgumentException e) {<a name="line.390"></a>
+<span class="sourceLineNo">391</span> }<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span>}<a name="line.393"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/dccdd274/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.MetaCacheEntry.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.MetaCacheEntry.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.MetaCacheEntry.html
index f8e34f2..ea22449 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.MetaCacheEntry.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.MetaCacheEntry.html
@@ -217,184 +217,188 @@
<span class="sourceLineNo">209</span> @Test<a name="line.209"></a>
<span class="sourceLineNo">210</span> public void testDisableCacheDataBlock() throws IOException {<a name="line.210"></a>
<span class="sourceLineNo">211</span> Configuration conf = HBaseConfiguration.create();<a name="line.211"></a>
-<span class="sourceLineNo">212</span> CacheConfig cacheConfig = new CacheConfig(conf);<a name="line.212"></a>
-<span class="sourceLineNo">213</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.213"></a>
-<span class="sourceLineNo">214</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.214"></a>
-<span class="sourceLineNo">215</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.215"></a>
-<span class="sourceLineNo">216</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.216"></a>
-<span class="sourceLineNo">217</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.217"></a>
-<span class="sourceLineNo">218</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.218"></a>
-<span class="sourceLineNo">219</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.219"></a>
-<span class="sourceLineNo">220</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.220"></a>
-<span class="sourceLineNo">221</span> assertFalse(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.221"></a>
-<span class="sourceLineNo">222</span> assertFalse(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.222"></a>
-<span class="sourceLineNo">223</span><a name="line.223"></a>
-<span class="sourceLineNo">224</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, true);<a name="line.224"></a>
-<span class="sourceLineNo">225</span> conf.setBoolean(CacheConfig.CACHE_DATA_BLOCKS_COMPRESSED_KEY, true);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> conf.setBoolean(CacheConfig.CACHE_BLOOM_BLOCKS_ON_WRITE_KEY, true);<a name="line.226"></a>
-<span class="sourceLineNo">227</span> conf.setBoolean(CacheConfig.CACHE_INDEX_BLOCKS_ON_WRITE_KEY, true);<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span> cacheConfig = new CacheConfig(conf);<a name="line.229"></a>
-<span class="sourceLineNo">230</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.230"></a>
-<span class="sourceLineNo">231</span> assertTrue(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.231"></a>
-<span class="sourceLineNo">232</span> assertTrue(cacheConfig.shouldCacheDataCompressed());<a name="line.232"></a>
-<span class="sourceLineNo">233</span> assertTrue(cacheConfig.shouldCacheDataOnWrite());<a name="line.233"></a>
-<span class="sourceLineNo">234</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.234"></a>
-<span class="sourceLineNo">235</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.235"></a>
-<span class="sourceLineNo">236</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.236"></a>
-<span class="sourceLineNo">237</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.237"></a>
-<span class="sourceLineNo">238</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.238"></a>
-<span class="sourceLineNo">239</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, false);<a name="line.241"></a>
-<span class="sourceLineNo">242</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.242"></a>
-<span class="sourceLineNo">243</span><a name="line.243"></a>
-<span class="sourceLineNo">244</span> cacheConfig = new CacheConfig(conf);<a name="line.244"></a>
-<span class="sourceLineNo">245</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.245"></a>
-<span class="sourceLineNo">246</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.246"></a>
-<span class="sourceLineNo">247</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.247"></a>
-<span class="sourceLineNo">248</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.248"></a>
-<span class="sourceLineNo">249</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.249"></a>
-<span class="sourceLineNo">250</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.250"></a>
-<span class="sourceLineNo">251</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.251"></a>
-<span class="sourceLineNo">252</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.252"></a>
-<span class="sourceLineNo">253</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.253"></a>
-<span class="sourceLineNo">254</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.254"></a>
-<span class="sourceLineNo">255</span><a name="line.255"></a>
-<span class="sourceLineNo">256</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, true);<a name="line.256"></a>
-<span class="sourceLineNo">257</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.257"></a>
-<span class="sourceLineNo">258</span><a name="line.258"></a>
-<span class="sourceLineNo">259</span> HColumnDescriptor family = new HColumnDescriptor("testDisableCacheDataBlock");<a name="line.259"></a>
-<span class="sourceLineNo">260</span> family.setBlockCacheEnabled(false);<a name="line.260"></a>
-<span class="sourceLineNo">261</span><a name="line.261"></a>
-<span class="sourceLineNo">262</span> cacheConfig = new CacheConfig(conf, family);<a name="line.262"></a>
-<span class="sourceLineNo">263</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.263"></a>
-<span class="sourceLineNo">264</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.264"></a>
-<span class="sourceLineNo">265</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.265"></a>
-<span class="sourceLineNo">266</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.266"></a>
-<span class="sourceLineNo">267</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.267"></a>
-<span class="sourceLineNo">268</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.268"></a>
-<span class="sourceLineNo">269</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.269"></a>
-<span class="sourceLineNo">270</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.270"></a>
-<span class="sourceLineNo">271</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.271"></a>
-<span class="sourceLineNo">272</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span> @Test<a name="line.275"></a>
-<span class="sourceLineNo">276</span> public void testCacheConfigDefaultLRUBlockCache() {<a name="line.276"></a>
-<span class="sourceLineNo">277</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.277"></a>
-<span class="sourceLineNo">278</span> assertTrue(cc.isBlockCacheEnabled());<a name="line.278"></a>
-<span class="sourceLineNo">279</span> assertTrue(CacheConfig.DEFAULT_IN_MEMORY == cc.isInMemory());<a name="line.279"></a>
-<span class="sourceLineNo">280</span> basicBlockCacheOps(cc, false, true);<a name="line.280"></a>
-<span class="sourceLineNo">281</span> assertTrue(cc.getBlockCache() instanceof LruBlockCache);<a name="line.281"></a>
-<span class="sourceLineNo">282</span> }<a name="line.282"></a>
-<span class="sourceLineNo">283</span><a name="line.283"></a>
-<span class="sourceLineNo">284</span> /**<a name="line.284"></a>
-<span class="sourceLineNo">285</span> * Assert that the caches are deployed with CombinedBlockCache and of the appropriate sizes.<a name="line.285"></a>
-<span class="sourceLineNo">286</span> */<a name="line.286"></a>
-<span class="sourceLineNo">287</span> @Test<a name="line.287"></a>
-<span class="sourceLineNo">288</span> public void testOffHeapBucketCacheConfig() {<a name="line.288"></a>
-<span class="sourceLineNo">289</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.289"></a>
-<span class="sourceLineNo">290</span> doBucketCacheConfigTest();<a name="line.290"></a>
-<span class="sourceLineNo">291</span> }<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span> @Test<a name="line.293"></a>
-<span class="sourceLineNo">294</span> public void testFileBucketCacheConfig() throws IOException {<a name="line.294"></a>
-<span class="sourceLineNo">295</span> HBaseTestingUtility htu = new HBaseTestingUtility(this.conf);<a name="line.295"></a>
-<span class="sourceLineNo">296</span> try {<a name="line.296"></a>
-<span class="sourceLineNo">297</span> Path p = new Path(htu.getDataTestDir(), "bc.txt");<a name="line.297"></a>
-<span class="sourceLineNo">298</span> FileSystem fs = FileSystem.get(this.conf);<a name="line.298"></a>
-<span class="sourceLineNo">299</span> fs.create(p).close();<a name="line.299"></a>
-<span class="sourceLineNo">300</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "file:" + p);<a name="line.300"></a>
-<span class="sourceLineNo">301</span> doBucketCacheConfigTest();<a name="line.301"></a>
-<span class="sourceLineNo">302</span> } finally {<a name="line.302"></a>
-<span class="sourceLineNo">303</span> htu.cleanupTestDir();<a name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> }<a name="line.305"></a>
-<span class="sourceLineNo">306</span><a name="line.306"></a>
-<span class="sourceLineNo">307</span> private void doBucketCacheConfigTest() {<a name="line.307"></a>
-<span class="sourceLineNo">308</span> final int bcSize = 100;<a name="line.308"></a>
-<span class="sourceLineNo">309</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.309"></a>
-<span class="sourceLineNo">310</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.310"></a>
-<span class="sourceLineNo">311</span> basicBlockCacheOps(cc, false, false);<a name="line.311"></a>
-<span class="sourceLineNo">312</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.312"></a>
-<span class="sourceLineNo">313</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.313"></a>
-<span class="sourceLineNo">314</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.314"></a>
-<span class="sourceLineNo">315</span> BlockCache [] bcs = cbc.getBlockCaches();<a name="line.315"></a>
-<span class="sourceLineNo">316</span> assertTrue(bcs[0] instanceof LruBlockCache);<a name="line.316"></a>
-<span class="sourceLineNo">317</span> LruBlockCache lbc = (LruBlockCache)bcs[0];<a name="line.317"></a>
-<span class="sourceLineNo">318</span> assertEquals(MemorySizeUtil.getOnHeapCacheSize(this.conf), lbc.getMaxSize());<a name="line.318"></a>
-<span class="sourceLineNo">319</span> assertTrue(bcs[1] instanceof BucketCache);<a name="line.319"></a>
-<span class="sourceLineNo">320</span> BucketCache bc = (BucketCache)bcs[1];<a name="line.320"></a>
-<span class="sourceLineNo">321</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.321"></a>
-<span class="sourceLineNo">322</span> assertEquals(bcSize, bc.getMaxSize() / (1024 * 1024));<a name="line.322"></a>
-<span class="sourceLineNo">323</span> }<a name="line.323"></a>
-<span class="sourceLineNo">324</span><a name="line.324"></a>
-<span class="sourceLineNo">325</span> /**<a name="line.325"></a>
-<span class="sourceLineNo">326</span> * Assert that when BUCKET_CACHE_COMBINED_KEY is false, the non-default, that we deploy<a name="line.326"></a>
-<span class="sourceLineNo">327</span> * LruBlockCache as L1 with a BucketCache for L2.<a name="line.327"></a>
-<span class="sourceLineNo">328</span> */<a name="line.328"></a>
-<span class="sourceLineNo">329</span> @Test<a name="line.329"></a>
-<span class="sourceLineNo">330</span> public void testBucketCacheConfigL1L2Setup() {<a name="line.330"></a>
-<span class="sourceLineNo">331</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.331"></a>
-<span class="sourceLineNo">332</span> // Make lru size is smaller than bcSize for sure. Need this to be true so when eviction<a name="line.332"></a>
-<span class="sourceLineNo">333</span> // from L1 happens, it does not fail because L2 can't take the eviction because block too big.<a name="line.333"></a>
-<span class="sourceLineNo">334</span> this.conf.setFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, 0.001f);<a name="line.334"></a>
-<span class="sourceLineNo">335</span> MemoryUsage mu = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();<a name="line.335"></a>
-<span class="sourceLineNo">336</span> long lruExpectedSize = MemorySizeUtil.getOnHeapCacheSize(this.conf);<a name="line.336"></a>
-<span class="sourceLineNo">337</span> final int bcSize = 100;<a name="line.337"></a>
-<span class="sourceLineNo">338</span> long bcExpectedSize = 100 * 1024 * 1024; // MB.<a name="line.338"></a>
-<span class="sourceLineNo">339</span> assertTrue(lruExpectedSize < bcExpectedSize);<a name="line.339"></a>
-<span class="sourceLineNo">340</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.340"></a>
-<span class="sourceLineNo">341</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.341"></a>
-<span class="sourceLineNo">342</span> basicBlockCacheOps(cc, false, false);<a name="line.342"></a>
-<span class="sourceLineNo">343</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.343"></a>
-<span class="sourceLineNo">344</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.344"></a>
-<span class="sourceLineNo">345</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.345"></a>
-<span class="sourceLineNo">346</span> LruBlockCache lbc = cbc.onHeapCache;<a name="line.346"></a>
-<span class="sourceLineNo">347</span> assertEquals(lruExpectedSize, lbc.getMaxSize());<a name="line.347"></a>
-<span class="sourceLineNo">348</span> BlockCache bc = cbc.l2Cache;<a name="line.348"></a>
-<span class="sourceLineNo">349</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.349"></a>
-<span class="sourceLineNo">350</span> assertEquals(bcExpectedSize, ((BucketCache) bc).getMaxSize());<a name="line.350"></a>
-<span class="sourceLineNo">351</span> // Test the L1+L2 deploy works as we'd expect with blocks evicted from L1 going to L2.<a name="line.351"></a>
-<span class="sourceLineNo">352</span> long initialL1BlockCount = lbc.getBlockCount();<a name="line.352"></a>
-<span class="sourceLineNo">353</span> long initialL2BlockCount = bc.getBlockCount();<a name="line.353"></a>
-<span class="sourceLineNo">354</span> Cacheable c = new DataCacheEntry();<a name="line.354"></a>
-<span class="sourceLineNo">355</span> BlockCacheKey bck = new BlockCacheKey("bck", 0);<a name="line.355"></a>
-<span class="sourceLineNo">356</span> lbc.cacheBlock(bck, c, false);<a name="line.356"></a>
-<span class="sourceLineNo">357</span> assertEquals(initialL1BlockCount + 1, lbc.getBlockCount());<a name="line.357"></a>
-<span class="sourceLineNo">358</span> assertEquals(initialL2BlockCount, bc.getBlockCount());<a name="line.358"></a>
-<span class="sourceLineNo">359</span> // Force evictions by putting in a block too big.<a name="line.359"></a>
-<span class="sourceLineNo">360</span> final long justTooBigSize = lbc.acceptableSize() + 1;<a name="line.360"></a>
-<span class="sourceLineNo">361</span> lbc.cacheBlock(new BlockCacheKey("bck2", 0), new DataCacheEntry() {<a name="line.361"></a>
-<span class="sourceLineNo">362</span> @Override<a name="line.362"></a>
-<span class="sourceLineNo">363</span> public long heapSize() {<a name="line.363"></a>
-<span class="sourceLineNo">364</span> return justTooBigSize;<a name="line.364"></a>
-<span class="sourceLineNo">365</span> }<a name="line.365"></a>
-<span class="sourceLineNo">366</span><a name="line.366"></a>
-<span class="sourceLineNo">367</span> @Override<a name="line.367"></a>
-<span class="sourceLineNo">368</span> public int getSerializedLength() {<a name="line.368"></a>
-<span class="sourceLineNo">369</span> return (int)heapSize();<a name="line.369"></a>
-<span class="sourceLineNo">370</span> }<a name="line.370"></a>
-<span class="sourceLineNo">371</span> });<a name="line.371"></a>
-<span class="sourceLineNo">372</span> // The eviction thread in lrublockcache needs to run.<a name="line.372"></a>
-<span class="sourceLineNo">373</span> while (initialL1BlockCount != lbc.getBlockCount()) Threads.sleep(10);<a name="line.373"></a>
-<span class="sourceLineNo">374</span> assertEquals(initialL1BlockCount, lbc.getBlockCount());<a name="line.374"></a>
-<span class="sourceLineNo">375</span> }<a name="line.375"></a>
-<span class="sourceLineNo">376</span><a name="line.376"></a>
-<span class="sourceLineNo">377</span> @Test<a name="line.377"></a>
-<span class="sourceLineNo">378</span> public void testL2CacheWithInvalidBucketSize() {<a name="line.378"></a>
-<span class="sourceLineNo">379</span> Configuration c = new Configuration(this.conf);<a name="line.379"></a>
-<span class="sourceLineNo">380</span> c.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.380"></a>
-<span class="sourceLineNo">381</span> c.set(CacheConfig.BUCKET_CACHE_BUCKETS_KEY, "256,512,1024,2048,4000,4096");<a name="line.381"></a>
-<span class="sourceLineNo">382</span> c.setFloat(HConstants.BUCKET_CACHE_SIZE_KEY, 1024);<a name="line.382"></a>
-<span class="sourceLineNo">383</span> try {<a name="line.383"></a>
-<span class="sourceLineNo">384</span> CacheConfig.getBucketCache(c);<a name="line.384"></a>
-<span class="sourceLineNo">385</span> fail("Should throw IllegalArgumentException when passing illegal value for bucket size");<a name="line.385"></a>
-<span class="sourceLineNo">386</span> } catch (IllegalArgumentException e) {<a name="line.386"></a>
-<span class="sourceLineNo">387</span> }<a name="line.387"></a>
-<span class="sourceLineNo">388</span> }<a name="line.388"></a>
-<span class="sourceLineNo">389</span>}<a name="line.389"></a>
+<span class="sourceLineNo">212</span> CacheConfig.instantiateBlockCache(conf);<a name="line.212"></a>
+<span class="sourceLineNo">213</span> CacheConfig cacheConfig = new CacheConfig(conf);<a name="line.213"></a>
+<span class="sourceLineNo">214</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.214"></a>
+<span class="sourceLineNo">215</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.215"></a>
+<span class="sourceLineNo">216</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.216"></a>
+<span class="sourceLineNo">217</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.217"></a>
+<span class="sourceLineNo">218</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.218"></a>
+<span class="sourceLineNo">219</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.219"></a>
+<span class="sourceLineNo">220</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.220"></a>
+<span class="sourceLineNo">221</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.221"></a>
+<span class="sourceLineNo">222</span> assertFalse(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.222"></a>
+<span class="sourceLineNo">223</span> assertFalse(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.223"></a>
+<span class="sourceLineNo">224</span><a name="line.224"></a>
+<span class="sourceLineNo">225</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, true);<a name="line.225"></a>
+<span class="sourceLineNo">226</span> conf.setBoolean(CacheConfig.CACHE_DATA_BLOCKS_COMPRESSED_KEY, true);<a name="line.226"></a>
+<span class="sourceLineNo">227</span> conf.setBoolean(CacheConfig.CACHE_BLOOM_BLOCKS_ON_WRITE_KEY, true);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> conf.setBoolean(CacheConfig.CACHE_INDEX_BLOCKS_ON_WRITE_KEY, true);<a name="line.228"></a>
+<span class="sourceLineNo">229</span><a name="line.229"></a>
+<span class="sourceLineNo">230</span> cacheConfig = new CacheConfig(conf);<a name="line.230"></a>
+<span class="sourceLineNo">231</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.231"></a>
+<span class="sourceLineNo">232</span> assertTrue(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.232"></a>
+<span class="sourceLineNo">233</span> assertTrue(cacheConfig.shouldCacheDataCompressed());<a name="line.233"></a>
+<span class="sourceLineNo">234</span> assertTrue(cacheConfig.shouldCacheDataOnWrite());<a name="line.234"></a>
+<span class="sourceLineNo">235</span> assertTrue(cacheConfig.shouldCacheDataOnRead());<a name="line.235"></a>
+<span class="sourceLineNo">236</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.236"></a>
+<span class="sourceLineNo">237</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.237"></a>
+<span class="sourceLineNo">238</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.238"></a>
+<span class="sourceLineNo">239</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.239"></a>
+<span class="sourceLineNo">240</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.240"></a>
+<span class="sourceLineNo">241</span><a name="line.241"></a>
+<span class="sourceLineNo">242</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, false);<a name="line.242"></a>
+<span class="sourceLineNo">243</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.243"></a>
+<span class="sourceLineNo">244</span><a name="line.244"></a>
+<span class="sourceLineNo">245</span> cacheConfig = new CacheConfig(conf);<a name="line.245"></a>
+<span class="sourceLineNo">246</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.246"></a>
+<span class="sourceLineNo">247</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.247"></a>
+<span class="sourceLineNo">248</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.248"></a>
+<span class="sourceLineNo">249</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.249"></a>
+<span class="sourceLineNo">250</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.250"></a>
+<span class="sourceLineNo">251</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.251"></a>
+<span class="sourceLineNo">252</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.252"></a>
+<span class="sourceLineNo">253</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.253"></a>
+<span class="sourceLineNo">254</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.254"></a>
+<span class="sourceLineNo">255</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.255"></a>
+<span class="sourceLineNo">256</span><a name="line.256"></a>
+<span class="sourceLineNo">257</span> conf.setBoolean(CacheConfig.CACHE_DATA_ON_READ_KEY, true);<a name="line.257"></a>
+<span class="sourceLineNo">258</span> conf.setBoolean(CacheConfig.CACHE_BLOCKS_ON_WRITE_KEY, false);<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> HColumnDescriptor family = new HColumnDescriptor("testDisableCacheDataBlock");<a name="line.260"></a>
+<span class="sourceLineNo">261</span> family.setBlockCacheEnabled(false);<a name="line.261"></a>
+<span class="sourceLineNo">262</span><a name="line.262"></a>
+<span class="sourceLineNo">263</span> cacheConfig = new CacheConfig(conf, family);<a name="line.263"></a>
+<span class="sourceLineNo">264</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.DATA));<a name="line.264"></a>
+<span class="sourceLineNo">265</span> assertFalse(cacheConfig.shouldCacheCompressed(BlockCategory.DATA));<a name="line.265"></a>
+<span class="sourceLineNo">266</span> assertFalse(cacheConfig.shouldCacheDataCompressed());<a name="line.266"></a>
+<span class="sourceLineNo">267</span> assertFalse(cacheConfig.shouldCacheDataOnWrite());<a name="line.267"></a>
+<span class="sourceLineNo">268</span> assertFalse(cacheConfig.shouldCacheDataOnRead());<a name="line.268"></a>
+<span class="sourceLineNo">269</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.INDEX));<a name="line.269"></a>
+<span class="sourceLineNo">270</span> assertFalse(cacheConfig.shouldCacheBlockOnRead(BlockCategory.META));<a name="line.270"></a>
+<span class="sourceLineNo">271</span> assertTrue(cacheConfig.shouldCacheBlockOnRead(BlockCategory.BLOOM));<a name="line.271"></a>
+<span class="sourceLineNo">272</span> assertTrue(cacheConfig.shouldCacheBloomsOnWrite());<a name="line.272"></a>
+<span class="sourceLineNo">273</span> assertTrue(cacheConfig.shouldCacheIndexesOnWrite());<a name="line.273"></a>
+<span class="sourceLineNo">274</span> }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> @Test<a name="line.276"></a>
+<span class="sourceLineNo">277</span> public void testCacheConfigDefaultLRUBlockCache() {<a name="line.277"></a>
+<span class="sourceLineNo">278</span> CacheConfig.instantiateBlockCache(this.conf);<a name="line.278"></a>
+<span class="sourceLineNo">279</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.279"></a>
+<span class="sourceLineNo">280</span> assertTrue(cc.isBlockCacheEnabled());<a name="line.280"></a>
+<span class="sourceLineNo">281</span> assertTrue(CacheConfig.DEFAULT_IN_MEMORY == cc.isInMemory());<a name="line.281"></a>
+<span class="sourceLineNo">282</span> basicBlockCacheOps(cc, false, true);<a name="line.282"></a>
+<span class="sourceLineNo">283</span> assertTrue(cc.getBlockCache() instanceof LruBlockCache);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> }<a name="line.284"></a>
+<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">286</span> /**<a name="line.286"></a>
+<span class="sourceLineNo">287</span> * Assert that the caches are deployed with CombinedBlockCache and of the appropriate sizes.<a name="line.287"></a>
+<span class="sourceLineNo">288</span> */<a name="line.288"></a>
+<span class="sourceLineNo">289</span> @Test<a name="line.289"></a>
+<span class="sourceLineNo">290</span> public void testOffHeapBucketCacheConfig() {<a name="line.290"></a>
+<span class="sourceLineNo">291</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.291"></a>
+<span class="sourceLineNo">292</span> doBucketCacheConfigTest();<a name="line.292"></a>
+<span class="sourceLineNo">293</span> }<a name="line.293"></a>
+<span class="sourceLineNo">294</span><a name="line.294"></a>
+<span class="sourceLineNo">295</span> @Test<a name="line.295"></a>
+<span class="sourceLineNo">296</span> public void testFileBucketCacheConfig() throws IOException {<a name="line.296"></a>
+<span class="sourceLineNo">297</span> HBaseTestingUtility htu = new HBaseTestingUtility(this.conf);<a name="line.297"></a>
+<span class="sourceLineNo">298</span> try {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> Path p = new Path(htu.getDataTestDir(), "bc.txt");<a name="line.299"></a>
+<span class="sourceLineNo">300</span> FileSystem fs = FileSystem.get(this.conf);<a name="line.300"></a>
+<span class="sourceLineNo">301</span> fs.create(p).close();<a name="line.301"></a>
+<span class="sourceLineNo">302</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "file:" + p);<a name="line.302"></a>
+<span class="sourceLineNo">303</span> doBucketCacheConfigTest();<a name="line.303"></a>
+<span class="sourceLineNo">304</span> } finally {<a name="line.304"></a>
+<span class="sourceLineNo">305</span> htu.cleanupTestDir();<a name="line.305"></a>
+<span class="sourceLineNo">306</span> }<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span> private void doBucketCacheConfigTest() {<a name="line.309"></a>
+<span class="sourceLineNo">310</span> final int bcSize = 100;<a name="line.310"></a>
+<span class="sourceLineNo">311</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.311"></a>
+<span class="sourceLineNo">312</span> CacheConfig.instantiateBlockCache(this.conf);<a name="line.312"></a>
+<span class="sourceLineNo">313</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.313"></a>
+<span class="sourceLineNo">314</span> basicBlockCacheOps(cc, false, false);<a name="line.314"></a>
+<span class="sourceLineNo">315</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.315"></a>
+<span class="sourceLineNo">316</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.316"></a>
+<span class="sourceLineNo">317</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.317"></a>
+<span class="sourceLineNo">318</span> BlockCache [] bcs = cbc.getBlockCaches();<a name="line.318"></a>
+<span class="sourceLineNo">319</span> assertTrue(bcs[0] instanceof LruBlockCache);<a name="line.319"></a>
+<span class="sourceLineNo">320</span> LruBlockCache lbc = (LruBlockCache)bcs[0];<a name="line.320"></a>
+<span class="sourceLineNo">321</span> assertEquals(MemorySizeUtil.getOnHeapCacheSize(this.conf), lbc.getMaxSize());<a name="line.321"></a>
+<span class="sourceLineNo">322</span> assertTrue(bcs[1] instanceof BucketCache);<a name="line.322"></a>
+<span class="sourceLineNo">323</span> BucketCache bc = (BucketCache)bcs[1];<a name="line.323"></a>
+<span class="sourceLineNo">324</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.324"></a>
+<span class="sourceLineNo">325</span> assertEquals(bcSize, bc.getMaxSize() / (1024 * 1024));<a name="line.325"></a>
+<span class="sourceLineNo">326</span> }<a name="line.326"></a>
+<span class="sourceLineNo">327</span><a name="line.327"></a>
+<span class="sourceLineNo">328</span> /**<a name="line.328"></a>
+<span class="sourceLineNo">329</span> * Assert that when BUCKET_CACHE_COMBINED_KEY is false, the non-default, that we deploy<a name="line.329"></a>
+<span class="sourceLineNo">330</span> * LruBlockCache as L1 with a BucketCache for L2.<a name="line.330"></a>
+<span class="sourceLineNo">331</span> */<a name="line.331"></a>
+<span class="sourceLineNo">332</span> @Test<a name="line.332"></a>
+<span class="sourceLineNo">333</span> public void testBucketCacheConfigL1L2Setup() {<a name="line.333"></a>
+<span class="sourceLineNo">334</span> this.conf.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.334"></a>
+<span class="sourceLineNo">335</span> // Make lru size is smaller than bcSize for sure. Need this to be true so when eviction<a name="line.335"></a>
+<span class="sourceLineNo">336</span> // from L1 happens, it does not fail because L2 can't take the eviction because block too big.<a name="line.336"></a>
+<span class="sourceLineNo">337</span> this.conf.setFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, 0.001f);<a name="line.337"></a>
+<span class="sourceLineNo">338</span> MemoryUsage mu = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();<a name="line.338"></a>
+<span class="sourceLineNo">339</span> long lruExpectedSize = MemorySizeUtil.getOnHeapCacheSize(this.conf);<a name="line.339"></a>
+<span class="sourceLineNo">340</span> final int bcSize = 100;<a name="line.340"></a>
+<span class="sourceLineNo">341</span> long bcExpectedSize = 100 * 1024 * 1024; // MB.<a name="line.341"></a>
+<span class="sourceLineNo">342</span> assertTrue(lruExpectedSize < bcExpectedSize);<a name="line.342"></a>
+<span class="sourceLineNo">343</span> this.conf.setInt(HConstants.BUCKET_CACHE_SIZE_KEY, bcSize);<a name="line.343"></a>
+<span class="sourceLineNo">344</span> CacheConfig.instantiateBlockCache(this.conf);<a name="line.344"></a>
+<span class="sourceLineNo">345</span> CacheConfig cc = new CacheConfig(this.conf);<a name="line.345"></a>
+<span class="sourceLineNo">346</span> basicBlockCacheOps(cc, false, false);<a name="line.346"></a>
+<span class="sourceLineNo">347</span> assertTrue(cc.getBlockCache() instanceof CombinedBlockCache);<a name="line.347"></a>
+<span class="sourceLineNo">348</span> // TODO: Assert sizes allocated are right and proportions.<a name="line.348"></a>
+<span class="sourceLineNo">349</span> CombinedBlockCache cbc = (CombinedBlockCache)cc.getBlockCache();<a name="line.349"></a>
+<span class="sourceLineNo">350</span> LruBlockCache lbc = cbc.onHeapCache;<a name="line.350"></a>
+<span class="sourceLineNo">351</span> assertEquals(lruExpectedSize, lbc.getMaxSize());<a name="line.351"></a>
+<span class="sourceLineNo">352</span> BlockCache bc = cbc.l2Cache;<a name="line.352"></a>
+<span class="sourceLineNo">353</span> // getMaxSize comes back in bytes but we specified size in MB<a name="line.353"></a>
+<span class="sourceLineNo">354</span> assertEquals(bcExpectedSize, ((BucketCache) bc).getMaxSize());<a name="line.354"></a>
+<span class="sourceLineNo">355</span> // Test the L1+L2 deploy works as we'd expect with blocks evicted from L1 going to L2.<a name="line.355"></a>
+<span class="sourceLineNo">356</span> long initialL1BlockCount = lbc.getBlockCount();<a name="line.356"></a>
+<span class="sourceLineNo">357</span> long initialL2BlockCount = bc.getBlockCount();<a name="line.357"></a>
+<span class="sourceLineNo">358</span> Cacheable c = new DataCacheEntry();<a name="line.358"></a>
+<span class="sourceLineNo">359</span> BlockCacheKey bck = new BlockCacheKey("bck", 0);<a name="line.359"></a>
+<span class="sourceLineNo">360</span> lbc.cacheBlock(bck, c, false);<a name="line.360"></a>
+<span class="sourceLineNo">361</span> assertEquals(initialL1BlockCount + 1, lbc.getBlockCount());<a name="line.361"></a>
+<span class="sourceLineNo">362</span> assertEquals(initialL2BlockCount, bc.getBlockCount());<a name="line.362"></a>
+<span class="sourceLineNo">363</span> // Force evictions by putting in a block too big.<a name="line.363"></a>
+<span class="sourceLineNo">364</span> final long justTooBigSize = lbc.acceptableSize() + 1;<a name="line.364"></a>
+<span class="sourceLineNo">365</span> lbc.cacheBlock(new BlockCacheKey("bck2", 0), new DataCacheEntry() {<a name="line.365"></a>
+<span class="sourceLineNo">366</span> @Override<a name="line.366"></a>
+<span class="sourceLineNo">367</span> public long heapSize() {<a name="line.367"></a>
+<span class="sourceLineNo">368</span> return justTooBigSize;<a name="line.368"></a>
+<span class="sourceLineNo">369</span> }<a name="line.369"></a>
+<span class="sourceLineNo">370</span><a name="line.370"></a>
+<span class="sourceLineNo">371</span> @Override<a name="line.371"></a>
+<span class="sourceLineNo">372</span> public int getSerializedLength() {<a name="line.372"></a>
+<span class="sourceLineNo">373</span> return (int)heapSize();<a name="line.373"></a>
+<span class="sourceLineNo">374</span> }<a name="line.374"></a>
+<span class="sourceLineNo">375</span> });<a name="line.375"></a>
+<span class="sourceLineNo">376</span> // The eviction thread in lrublockcache needs to run.<a name="line.376"></a>
+<span class="sourceLineNo">377</span> while (initialL1BlockCount != lbc.getBlockCount()) Threads.sleep(10);<a name="line.377"></a>
+<span class="sourceLineNo">378</span> assertEquals(initialL1BlockCount, lbc.getBlockCount());<a name="line.378"></a>
+<span class="sourceLineNo">379</span> }<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span> @Test<a name="line.381"></a>
+<span class="sourceLineNo">382</span> public void testL2CacheWithInvalidBucketSize() {<a name="line.382"></a>
+<span class="sourceLineNo">383</span> Configuration c = new Configuration(this.conf);<a name="line.383"></a>
+<span class="sourceLineNo">384</span> c.set(HConstants.BUCKET_CACHE_IOENGINE_KEY, "offheap");<a name="line.384"></a>
+<span class="sourceLineNo">385</span> c.set(CacheConfig.BUCKET_CACHE_BUCKETS_KEY, "256,512,1024,2048,4000,4096");<a name="line.385"></a>
+<span class="sourceLineNo">386</span> c.setFloat(HConstants.BUCKET_CACHE_SIZE_KEY, 1024);<a name="line.386"></a>
+<span class="sourceLineNo">387</span> try {<a name="line.387"></a>
+<span class="sourceLineNo">388</span> CacheConfig.getBucketCache(c);<a name="line.388"></a>
+<span class="sourceLineNo">389</span> fail("Should throw IllegalArgumentException when passing illegal value for bucket size");<a name="line.389"></a>
+<span class="sourceLineNo">390</span> } catch (IllegalArgumentException e) {<a name="line.390"></a>
+<span class="sourceLineNo">391</span> }<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span>}<a name="line.393"></a>