You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/07/22 13:09:20 UTC

[jira] [Created] (OAK-4591) Clarify implementation and documentation of TarReader#mark

Michael Dürig created OAK-4591:
----------------------------------

             Summary: Clarify implementation and documentation of TarReader#mark
                 Key: OAK-4591
                 URL: https://issues.apache.org/jira/browse/OAK-4591
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: segment-tar
            Reporter: Michael Dürig
            Assignee: Michael Dürig
             Fix For: Segment Tar 0.0.8


There is a few peculiarities with that method:

* The Javadoc "A bulk segment is reclaimable if it is in bulkRefs" is wrong. It should be "A bulk segment is reclaimable if it is *not* in bulkRefs".
* (Why) is it necessary to iterate in reverse over the entries in tar file?
* Why the extra check for bulk references in the else branch?
* The condition {{!reclaim.remove(id)}} is always true as {{id}} can only be in {{reclaim}} it it had been added in the same iteration (as ids are unique). But this would have been in the if branch, contradicting us being in the else branch. 




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)