You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2013/10/13 11:14:57 UTC

[01/13] git commit: Fixed test. Do not use hardcoded port

Updated Branches:
  refs/heads/camel-2.11.x 464833737 -> 1765f1a2e
  refs/heads/camel-2.12.x 66cb6537f -> c4ad5ea68
  refs/heads/master 802cfbe45 -> 975964675


Fixed test. Do not use hardcoded port


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/c1340cfc
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/c1340cfc
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/c1340cfc

Branch: refs/heads/master
Commit: c1340cfc5fee5fd4cd02e05a841b8cde21499a46
Parents: 802cfbe
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 10:55:27 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 10:55:27 2013 +0200

----------------------------------------------------------------------
 .../operations/SetDataOperationTest.java        |  6 +--
 .../zookeeper/policy/ZookeeperElectionTest.java | 41 +++++++++++++-------
 2 files changed, 29 insertions(+), 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/c1340cfc/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
----------------------------------------------------------------------
diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
index 7c1d3fe..35fe314 100644
--- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
+++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
@@ -16,8 +16,6 @@
  */
 package org.apache.camel.component.zookeeper.operations;
 
-import java.util.concurrent.ExecutionException;
-
 import org.apache.camel.component.zookeeper.ZooKeeperTestSupport;
 import org.apache.zookeeper.ZooKeeper;
 import org.junit.Before;
@@ -43,7 +41,6 @@ public class SetDataOperationTest extends ZooKeeperTestSupport {
 
     @Test
     public void setSpecificVersionOfData() throws Exception {
-
         client.create("/two", testPayload);
         for (int x = 0; x < 10; x++) {
             byte[] payload = ("Updated_" + x).getBytes();
@@ -56,10 +53,9 @@ public class SetDataOperationTest extends ZooKeeperTestSupport {
     public void setWithNull() throws Exception {
         client.create("/three", testPayload);
         updateDataOnNode("/three", null, -1, 1);
-
     }
 
-    private void updateDataOnNode(String node, byte[] payload, int version, int expectedVersion) throws InterruptedException, ExecutionException, Exception {
+    private void updateDataOnNode(String node, byte[] payload, int version, int expectedVersion) throws Exception {
         SetDataOperation operation = new SetDataOperation(connection, node, payload);
         operation.setVersion(version);
         OperationResult<byte[]> result = operation.get();

http://git-wip-us.apache.org/repos/asf/camel/blob/c1340cfc/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
----------------------------------------------------------------------
diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
index e0818ed..fd63cee 100644
--- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
+++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
@@ -17,6 +17,8 @@
 package org.apache.camel.component.zookeeper.policy;
 
 import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.camel.CamelContext;
 import org.apache.camel.component.zookeeper.ZooKeeperTestSupport;
 import org.apache.camel.impl.DefaultCamelContext;
 import org.junit.After;
@@ -30,7 +32,9 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     private static final String NODE_BASE_KEY = "/someapp";
     private static final String NODE_PARTICULAR_KEY = "/someapp/somepolicy";
-    private static final String ELECTION_URI = "zookeeper:localhost:39913/someapp/somepolicy";
+
+    private CamelContext candidateOneContext;
+    private CamelContext candidateTwoContext;
 
     @Before
     public void before() throws Exception {
@@ -43,18 +47,29 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
     public void after() throws Exception {
         client.deleteAll(NODE_PARTICULAR_KEY);
         client.delete(NODE_BASE_KEY);
+
+        if (candidateOneContext != null) {
+            candidateOneContext.stop();
+        }
+        if (candidateTwoContext != null) {
+            candidateTwoContext.stop();
+        }
+    }
+
+    private String getElectionUri() {
+        return "zookeeper:localhost:" + getServerPort() + "/someapp/somepolicy";
     }
 
     @Test
     public void masterCanBeElected() throws Exception {
-        ZooKeeperElection candidate = new ZooKeeperElection(template, context, ELECTION_URI, 1);
+        ZooKeeperElection candidate = new ZooKeeperElection(template, context, getElectionUri(), 1);
         assertTrue("The only election candidate was not elected as master.", candidate.isMaster());
     }
 
     @Test
     public void masterAndSlave() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 1);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -64,8 +79,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testMasterGoesAway() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 1);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -80,8 +95,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testDualMaster() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 2);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -92,8 +107,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testWatchersAreNotified() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         final AtomicBoolean notified = new AtomicBoolean(false);
         ElectionWatcher watcher = new ElectionWatcher() {
@@ -114,13 +129,13 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
         return controlledContext;
     }
 
-    private ZooKeeperElection createElectionCandidate(final DefaultCamelContext context, int masterCount) {
-        return new ZooKeeperElection(context.createProducerTemplate(), context, ELECTION_URI, masterCount);
+    private ZooKeeperElection createElectionCandidate(final CamelContext context, int masterCount) {
+        return new ZooKeeperElection(context.createProducerTemplate(), context, getElectionUri(), masterCount);
     }
 
     private void assertIsMaster(ZooKeeperElection electionCandidate) throws InterruptedException {
         // Need to wait for a while to be elected.
-        long timeout = System.currentTimeMillis() + 10000;
+        long timeout = System.currentTimeMillis() + 20000;
         
         while (!electionCandidate.isMaster() && timeout > System.currentTimeMillis()) {
             Thread.sleep(200);


[05/13] git commit: Fixed test. Do not use hardcoded port

Posted by da...@apache.org.
Fixed test. Do not use hardcoded port


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/5d12940f
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/5d12940f
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/5d12940f

Branch: refs/heads/camel-2.11.x
Commit: 5d12940f73d8a375e72eb3e4f688d0452c6ab317
Parents: 4648337
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 10:55:27 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 10:59:13 2013 +0200

----------------------------------------------------------------------
 .../operations/SetDataOperationTest.java        |  6 +--
 .../zookeeper/policy/ZookeeperElectionTest.java | 41 +++++++++++++-------
 2 files changed, 29 insertions(+), 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/5d12940f/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
----------------------------------------------------------------------
diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
index 7c1d3fe..35fe314 100644
--- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
+++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
@@ -16,8 +16,6 @@
  */
 package org.apache.camel.component.zookeeper.operations;
 
-import java.util.concurrent.ExecutionException;
-
 import org.apache.camel.component.zookeeper.ZooKeeperTestSupport;
 import org.apache.zookeeper.ZooKeeper;
 import org.junit.Before;
@@ -43,7 +41,6 @@ public class SetDataOperationTest extends ZooKeeperTestSupport {
 
     @Test
     public void setSpecificVersionOfData() throws Exception {
-
         client.create("/two", testPayload);
         for (int x = 0; x < 10; x++) {
             byte[] payload = ("Updated_" + x).getBytes();
@@ -56,10 +53,9 @@ public class SetDataOperationTest extends ZooKeeperTestSupport {
     public void setWithNull() throws Exception {
         client.create("/three", testPayload);
         updateDataOnNode("/three", null, -1, 1);
-
     }
 
-    private void updateDataOnNode(String node, byte[] payload, int version, int expectedVersion) throws InterruptedException, ExecutionException, Exception {
+    private void updateDataOnNode(String node, byte[] payload, int version, int expectedVersion) throws Exception {
         SetDataOperation operation = new SetDataOperation(connection, node, payload);
         operation.setVersion(version);
         OperationResult<byte[]> result = operation.get();

http://git-wip-us.apache.org/repos/asf/camel/blob/5d12940f/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
----------------------------------------------------------------------
diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
index e0818ed..fd63cee 100644
--- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
+++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
@@ -17,6 +17,8 @@
 package org.apache.camel.component.zookeeper.policy;
 
 import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.camel.CamelContext;
 import org.apache.camel.component.zookeeper.ZooKeeperTestSupport;
 import org.apache.camel.impl.DefaultCamelContext;
 import org.junit.After;
@@ -30,7 +32,9 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     private static final String NODE_BASE_KEY = "/someapp";
     private static final String NODE_PARTICULAR_KEY = "/someapp/somepolicy";
-    private static final String ELECTION_URI = "zookeeper:localhost:39913/someapp/somepolicy";
+
+    private CamelContext candidateOneContext;
+    private CamelContext candidateTwoContext;
 
     @Before
     public void before() throws Exception {
@@ -43,18 +47,29 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
     public void after() throws Exception {
         client.deleteAll(NODE_PARTICULAR_KEY);
         client.delete(NODE_BASE_KEY);
+
+        if (candidateOneContext != null) {
+            candidateOneContext.stop();
+        }
+        if (candidateTwoContext != null) {
+            candidateTwoContext.stop();
+        }
+    }
+
+    private String getElectionUri() {
+        return "zookeeper:localhost:" + getServerPort() + "/someapp/somepolicy";
     }
 
     @Test
     public void masterCanBeElected() throws Exception {
-        ZooKeeperElection candidate = new ZooKeeperElection(template, context, ELECTION_URI, 1);
+        ZooKeeperElection candidate = new ZooKeeperElection(template, context, getElectionUri(), 1);
         assertTrue("The only election candidate was not elected as master.", candidate.isMaster());
     }
 
     @Test
     public void masterAndSlave() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 1);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -64,8 +79,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testMasterGoesAway() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 1);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -80,8 +95,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testDualMaster() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 2);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -92,8 +107,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testWatchersAreNotified() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         final AtomicBoolean notified = new AtomicBoolean(false);
         ElectionWatcher watcher = new ElectionWatcher() {
@@ -114,13 +129,13 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
         return controlledContext;
     }
 
-    private ZooKeeperElection createElectionCandidate(final DefaultCamelContext context, int masterCount) {
-        return new ZooKeeperElection(context.createProducerTemplate(), context, ELECTION_URI, masterCount);
+    private ZooKeeperElection createElectionCandidate(final CamelContext context, int masterCount) {
+        return new ZooKeeperElection(context.createProducerTemplate(), context, getElectionUri(), masterCount);
     }
 
     private void assertIsMaster(ZooKeeperElection electionCandidate) throws InterruptedException {
         // Need to wait for a while to be elected.
-        long timeout = System.currentTimeMillis() + 10000;
+        long timeout = System.currentTimeMillis() + 20000;
         
         while (!electionCandidate.isMaster() && timeout > System.currentTimeMillis()) {
             Thread.sleep(200);


[13/13] git commit: CAMEL-6859: AvailablePortFinder should allow max at IPv4 range.

Posted by da...@apache.org.
CAMEL-6859: AvailablePortFinder should allow max at IPv4 range.


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/1765f1a2
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/1765f1a2
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/1765f1a2

Branch: refs/heads/camel-2.11.x
Commit: 1765f1a2e9b7ef17b3ba51a55dff62c178d207da
Parents: 6e33f34
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:13:01 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:14:40 2013 +0200

----------------------------------------------------------------------
 .../org/apache/camel/test/AvailablePortFinder.java     | 10 ++++------
 .../org/apache/camel/testng/AvailablePortFinder.java   | 13 ++++++-------
 2 files changed, 10 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/1765f1a2/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
----------------------------------------------------------------------
diff --git a/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java b/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
index 3253edd..57a1218 100644
--- a/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
+++ b/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
@@ -27,21 +27,19 @@ import org.slf4j.LoggerFactory;
 
 /**
  * Finds currently available server ports.
- *
- * @see <a href="http://www.iana.org/assignments/currentMinPort-numbers">IANA.org</a>
  */
 public final class AvailablePortFinder {
 
     /**
-     * The minimum server currentMinPort number. Set at 1100 to avoid returning privileged
-     * currentMinPort numbers.
+     * The minimum server currentMinPort number for IPv4.
+     * Set at 1100 to avoid returning privileged currentMinPort numbers.
      */
     public static final int MIN_PORT_NUMBER = 1100;
 
     /**
-     * The maximum server currentMinPort number.
+     * The maximum server currentMinPort number for IPv4.
      */
-    public static final int MAX_PORT_NUMBER = 49151;
+    public static final int MAX_PORT_NUMBER = 65535;
 
     private static final Logger LOG = LoggerFactory.getLogger(AvailablePortFinder.class);
 

http://git-wip-us.apache.org/repos/asf/camel/blob/1765f1a2/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
----------------------------------------------------------------------
diff --git a/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java b/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
index 5479c42..0f586e6 100644
--- a/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
+++ b/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
@@ -23,20 +23,19 @@ import java.util.NoSuchElementException;
 
 /**
  * Finds currently available server ports.
- *
- * @see <a href="http://www.iana.org/assignments/port-numbers">IANA.org</a>
  */
 public final class AvailablePortFinder {
+
     /**
-     * The minimum server port number. Set at 1024 to avoid returning privileged
-     * port numbers.
+     * The minimum server currentMinPort number for IPv4.
+     * Set at 1100 to avoid returning privileged currentMinPort numbers.
      */
-    public static final int MIN_PORT_NUMBER = 1024;
+    public static final int MIN_PORT_NUMBER = 1100;
 
     /**
-     * The maximum server port number.
+     * The maximum server currentMinPort number for IPv4.
      */
-    public static final int MAX_PORT_NUMBER = 49151;
+    public static final int MAX_PORT_NUMBER = 65535;
 
     /**
      * Creates a new instance.


[12/13] git commit: Use dynamic port number for testing.

Posted by da...@apache.org.
Use dynamic port number for testing.


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/c4ad5ea6
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/c4ad5ea6
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/c4ad5ea6

Branch: refs/heads/camel-2.12.x
Commit: c4ad5ea68a545da439e49be1fd2986240da9532b
Parents: 5a274ea
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:14:06 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:14:29 2013 +0200

----------------------------------------------------------------------
 .../java/org/apache/camel/component/stomp/StompBaseTest.java  | 6 +++++-
 .../org/apache/camel/component/stomp/StompConsumerTest.java   | 2 +-
 .../apache/camel/component/stomp/StompConsumerUriTest.java    | 7 +------
 .../org/apache/camel/component/stomp/StompProducerTest.java   | 2 +-
 4 files changed, 8 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/c4ad5ea6/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
index 3193c86..643787b 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
@@ -17,19 +17,23 @@
 package org.apache.camel.component.stomp;
 
 import org.apache.activemq.broker.BrokerService;
+import org.apache.camel.test.AvailablePortFinder;
 import org.apache.camel.test.junit4.CamelTestSupport;
 
 public abstract class StompBaseTest extends CamelTestSupport {
 
     protected BrokerService brokerService;
     protected int numberOfMessages = 100;
+    protected int port;
 
     protected int getPort() {
-        return 61613;
+        return port;
     }
 
     @Override
     public void setUp() throws Exception {
+        port = AvailablePortFinder.getNextAvailable(61613);
+
         brokerService = new BrokerService();
         brokerService.setPersistent(false);
         brokerService.setAdvisorySupport(false);

http://git-wip-us.apache.org/repos/asf/camel/blob/c4ad5ea6/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
index a2def8c..894cc4c 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
@@ -34,7 +34,7 @@ public class StompConsumerTest extends StompBaseTest {
 
     @Test
     public void testConsume() throws Exception {
-        Stomp stomp = new Stomp("tcp://localhost:61613");
+        Stomp stomp = new Stomp("tcp://localhost:" + getPort());
         final BlockingConnection producerConnection = stomp.connectBlocking();
 
         MockEndpoint mock = getMockEndpoint("mock:result");

http://git-wip-us.apache.org/repos/asf/camel/blob/c4ad5ea6/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
index a87e943..fa3aa08 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
@@ -32,11 +32,6 @@ import static org.fusesource.stomp.client.Constants.SEND;
 
 public class StompConsumerUriTest extends StompBaseTest {
 
-    @Override
-    protected int getPort() {
-        return 61614;
-    }
-
     @Test
     public void testConsume() throws Exception {
         Stomp stomp = new Stomp("tcp://localhost:" + getPort());
@@ -60,7 +55,7 @@ public class StompConsumerUriTest extends StompBaseTest {
     protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             public void configure() {
-                from("stomp:queue:test?brokerURL=tcp://localhost:61614")
+                from("stomp:queue:test?brokerURL=tcp://localhost:" + getPort())
                         .transform(body().convertToString())
                         .to("mock:result");
             }

http://git-wip-us.apache.org/repos/asf/camel/blob/c4ad5ea6/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
index fc878ea..f933423 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
@@ -35,7 +35,7 @@ public class StompProducerTest extends StompBaseTest {
 
     @Test
     public void testProduce() throws Exception {
-        Stomp stomp = new Stomp("tcp://localhost:61613");
+        Stomp stomp = new Stomp("tcp://localhost:" + getPort());
         final BlockingConnection subscribeConnection = stomp.connectBlocking();
 
         StompFrame frame = new StompFrame(SUBSCRIBE);


[03/13] git commit: Fixed test. Do not use hardcoded port

Posted by da...@apache.org.
Fixed test. Do not use hardcoded port


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/1547ed6c
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/1547ed6c
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/1547ed6c

Branch: refs/heads/camel-2.12.x
Commit: 1547ed6ca788fef302dfdcd0d2c94025cc5af4c3
Parents: 66cb653
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 10:55:27 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 10:58:49 2013 +0200

----------------------------------------------------------------------
 .../operations/SetDataOperationTest.java        |  6 +--
 .../zookeeper/policy/ZookeeperElectionTest.java | 41 +++++++++++++-------
 2 files changed, 29 insertions(+), 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/1547ed6c/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
----------------------------------------------------------------------
diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
index 7c1d3fe..35fe314 100644
--- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
+++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/SetDataOperationTest.java
@@ -16,8 +16,6 @@
  */
 package org.apache.camel.component.zookeeper.operations;
 
-import java.util.concurrent.ExecutionException;
-
 import org.apache.camel.component.zookeeper.ZooKeeperTestSupport;
 import org.apache.zookeeper.ZooKeeper;
 import org.junit.Before;
@@ -43,7 +41,6 @@ public class SetDataOperationTest extends ZooKeeperTestSupport {
 
     @Test
     public void setSpecificVersionOfData() throws Exception {
-
         client.create("/two", testPayload);
         for (int x = 0; x < 10; x++) {
             byte[] payload = ("Updated_" + x).getBytes();
@@ -56,10 +53,9 @@ public class SetDataOperationTest extends ZooKeeperTestSupport {
     public void setWithNull() throws Exception {
         client.create("/three", testPayload);
         updateDataOnNode("/three", null, -1, 1);
-
     }
 
-    private void updateDataOnNode(String node, byte[] payload, int version, int expectedVersion) throws InterruptedException, ExecutionException, Exception {
+    private void updateDataOnNode(String node, byte[] payload, int version, int expectedVersion) throws Exception {
         SetDataOperation operation = new SetDataOperation(connection, node, payload);
         operation.setVersion(version);
         OperationResult<byte[]> result = operation.get();

http://git-wip-us.apache.org/repos/asf/camel/blob/1547ed6c/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
----------------------------------------------------------------------
diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
index e0818ed..fd63cee 100644
--- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
+++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/policy/ZookeeperElectionTest.java
@@ -17,6 +17,8 @@
 package org.apache.camel.component.zookeeper.policy;
 
 import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.camel.CamelContext;
 import org.apache.camel.component.zookeeper.ZooKeeperTestSupport;
 import org.apache.camel.impl.DefaultCamelContext;
 import org.junit.After;
@@ -30,7 +32,9 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     private static final String NODE_BASE_KEY = "/someapp";
     private static final String NODE_PARTICULAR_KEY = "/someapp/somepolicy";
-    private static final String ELECTION_URI = "zookeeper:localhost:39913/someapp/somepolicy";
+
+    private CamelContext candidateOneContext;
+    private CamelContext candidateTwoContext;
 
     @Before
     public void before() throws Exception {
@@ -43,18 +47,29 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
     public void after() throws Exception {
         client.deleteAll(NODE_PARTICULAR_KEY);
         client.delete(NODE_BASE_KEY);
+
+        if (candidateOneContext != null) {
+            candidateOneContext.stop();
+        }
+        if (candidateTwoContext != null) {
+            candidateTwoContext.stop();
+        }
+    }
+
+    private String getElectionUri() {
+        return "zookeeper:localhost:" + getServerPort() + "/someapp/somepolicy";
     }
 
     @Test
     public void masterCanBeElected() throws Exception {
-        ZooKeeperElection candidate = new ZooKeeperElection(template, context, ELECTION_URI, 1);
+        ZooKeeperElection candidate = new ZooKeeperElection(template, context, getElectionUri(), 1);
         assertTrue("The only election candidate was not elected as master.", candidate.isMaster());
     }
 
     @Test
     public void masterAndSlave() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 1);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -64,8 +79,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testMasterGoesAway() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 1);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -80,8 +95,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testDualMaster() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         ZooKeeperElection electionCandidate1 = createElectionCandidate(candidateOneContext, 2);
         assertTrue("The first candidate was not elected.", electionCandidate1.isMaster());
@@ -92,8 +107,8 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
 
     @Test
     public void testWatchersAreNotified() throws Exception {
-        final DefaultCamelContext candidateOneContext = createNewContext();
-        final DefaultCamelContext candidateTwoContext = createNewContext();
+        candidateOneContext = createNewContext();
+        candidateTwoContext = createNewContext();
 
         final AtomicBoolean notified = new AtomicBoolean(false);
         ElectionWatcher watcher = new ElectionWatcher() {
@@ -114,13 +129,13 @@ public class ZookeeperElectionTest extends ZooKeeperTestSupport {
         return controlledContext;
     }
 
-    private ZooKeeperElection createElectionCandidate(final DefaultCamelContext context, int masterCount) {
-        return new ZooKeeperElection(context.createProducerTemplate(), context, ELECTION_URI, masterCount);
+    private ZooKeeperElection createElectionCandidate(final CamelContext context, int masterCount) {
+        return new ZooKeeperElection(context.createProducerTemplate(), context, getElectionUri(), masterCount);
     }
 
     private void assertIsMaster(ZooKeeperElection electionCandidate) throws InterruptedException {
         // Need to wait for a while to be elected.
-        long timeout = System.currentTimeMillis() + 10000;
+        long timeout = System.currentTimeMillis() + 20000;
         
         while (!electionCandidate.isMaster() && timeout > System.currentTimeMillis()) {
             Thread.sleep(200);


[07/13] git commit: Fixed test

Posted by da...@apache.org.
Fixed test


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/d36d36d8
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/d36d36d8
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/d36d36d8

Branch: refs/heads/master
Commit: d36d36d806709f09519416786583d17cdad48230
Parents: 9386ce1
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:01:41 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:01:41 2013 +0200

----------------------------------------------------------------------
 .../apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java  | 2 +-
 .../java/org/apache/camel/test/blueprint/PropertyInjectTest.java   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/d36d36d8/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
----------------------------------------------------------------------
diff --git a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
index 2f1959c..230aaa8 100644
--- a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
+++ b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
@@ -26,7 +26,7 @@ public class BlueprintPropertyInjectRoute extends RouteBuilder {
 
     @Override
     public void configure() throws Exception {
-        from("direct:start")
+        from("seda:start")
                 .transform().constant(greeting)
                 .to("{{destination}}");
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/d36d36d8/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
----------------------------------------------------------------------
diff --git a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
index 6336f7c..615edd1 100644
--- a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
+++ b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
@@ -29,7 +29,7 @@ public class PropertyInjectTest extends CamelBlueprintTestSupport {
     public void testPropertyInject() throws Exception {
         getMockEndpoint("mock:result").expectedBodiesReceived("Hello");
 
-        template.sendBody("direct:start", "Camel");
+        template.sendBody("seda:start", "Camel");
 
         assertMockEndpointsSatisfied();
     }


[10/13] git commit: Use dynamic port number for testing.

Posted by da...@apache.org.
Use dynamic port number for testing.


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/97596467
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/97596467
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/97596467

Branch: refs/heads/master
Commit: 9759646756048b94a9e93be50962723980188da2
Parents: 41afc93
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:14:06 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:14:06 2013 +0200

----------------------------------------------------------------------
 .../java/org/apache/camel/component/stomp/StompBaseTest.java  | 6 +++++-
 .../org/apache/camel/component/stomp/StompConsumerTest.java   | 2 +-
 .../apache/camel/component/stomp/StompConsumerUriTest.java    | 7 +------
 .../org/apache/camel/component/stomp/StompProducerTest.java   | 2 +-
 4 files changed, 8 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/97596467/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
index 3193c86..643787b 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompBaseTest.java
@@ -17,19 +17,23 @@
 package org.apache.camel.component.stomp;
 
 import org.apache.activemq.broker.BrokerService;
+import org.apache.camel.test.AvailablePortFinder;
 import org.apache.camel.test.junit4.CamelTestSupport;
 
 public abstract class StompBaseTest extends CamelTestSupport {
 
     protected BrokerService brokerService;
     protected int numberOfMessages = 100;
+    protected int port;
 
     protected int getPort() {
-        return 61613;
+        return port;
     }
 
     @Override
     public void setUp() throws Exception {
+        port = AvailablePortFinder.getNextAvailable(61613);
+
         brokerService = new BrokerService();
         brokerService.setPersistent(false);
         brokerService.setAdvisorySupport(false);

http://git-wip-us.apache.org/repos/asf/camel/blob/97596467/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
index a2def8c..894cc4c 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerTest.java
@@ -34,7 +34,7 @@ public class StompConsumerTest extends StompBaseTest {
 
     @Test
     public void testConsume() throws Exception {
-        Stomp stomp = new Stomp("tcp://localhost:61613");
+        Stomp stomp = new Stomp("tcp://localhost:" + getPort());
         final BlockingConnection producerConnection = stomp.connectBlocking();
 
         MockEndpoint mock = getMockEndpoint("mock:result");

http://git-wip-us.apache.org/repos/asf/camel/blob/97596467/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
index a87e943..fa3aa08 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompConsumerUriTest.java
@@ -32,11 +32,6 @@ import static org.fusesource.stomp.client.Constants.SEND;
 
 public class StompConsumerUriTest extends StompBaseTest {
 
-    @Override
-    protected int getPort() {
-        return 61614;
-    }
-
     @Test
     public void testConsume() throws Exception {
         Stomp stomp = new Stomp("tcp://localhost:" + getPort());
@@ -60,7 +55,7 @@ public class StompConsumerUriTest extends StompBaseTest {
     protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             public void configure() {
-                from("stomp:queue:test?brokerURL=tcp://localhost:61614")
+                from("stomp:queue:test?brokerURL=tcp://localhost:" + getPort())
                         .transform(body().convertToString())
                         .to("mock:result");
             }

http://git-wip-us.apache.org/repos/asf/camel/blob/97596467/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
----------------------------------------------------------------------
diff --git a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
index fc878ea..f933423 100644
--- a/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
+++ b/components/camel-stomp/src/test/java/org/apache/camel/component/stomp/StompProducerTest.java
@@ -35,7 +35,7 @@ public class StompProducerTest extends StompBaseTest {
 
     @Test
     public void testProduce() throws Exception {
-        Stomp stomp = new Stomp("tcp://localhost:61613");
+        Stomp stomp = new Stomp("tcp://localhost:" + getPort());
         final BlockingConnection subscribeConnection = stomp.connectBlocking();
 
         StompFrame frame = new StompFrame(SUBSCRIBE);


[04/13] git commit: Fixed tests on CI servers

Posted by da...@apache.org.
Fixed tests on CI servers


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/f2c48af8
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/f2c48af8
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/f2c48af8

Branch: refs/heads/camel-2.12.x
Commit: f2c48af8d9169829259deba01d06a33340e41d74
Parents: 1547ed6
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 10:58:29 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 10:58:54 2013 +0200

----------------------------------------------------------------------
 .../file/FilerConsumerShouldSkipDoneFileSuffixTest.java          | 4 +++-
 .../RecipientListParallelAggregateThreadPoolIssueTest.java       | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/f2c48af8/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
index e6ab1d3..258b98a 100644
--- a/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
+++ b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
@@ -67,7 +67,9 @@ public class FilerConsumerShouldSkipDoneFileSuffixTest extends ContextTestSuppor
         return new RouteBuilder() {
             @Override
             public void configure() throws Exception {
-                from("file:target/done?doneFileName=${file:name}.ready&initialDelay=0&delay=10").to("mock:result");
+                from("file:target/done?doneFileName=${file:name}.ready&initialDelay=0")
+                    .convertBodyTo(String.class)
+                    .to("mock:result");
             }
         };
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/f2c48af8/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
index 7040251..078c4a1 100644
--- a/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
+++ b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
@@ -42,9 +42,9 @@ public class RecipientListParallelAggregateThreadPoolIssueTest extends ContextTe
         int num1 = context.getTypeConverter().convertTo(int.class, before);
         int num2 = context.getTypeConverter().convertTo(int.class, after);
         int diff = num2 - num1;
-        // should be 10 + 1 other threads (10 in parallel pool + 1 in aggregate pool)
+        // should be at least 10 + 1 other threads (10 in parallel pool + 1 in aggregate pool)
         // we run unit test per jmv fork, so there may be a hanging thread
-        assertTrue("There should be 12 threads in diff, was: " + diff, diff >= 12 && diff <= 13);
+        assertTrue("There should be 12 or more threads in use, was: " + diff, diff >= 11);
     }
 
     @Override


[06/13] git commit: Fixed tests on CI servers

Posted by da...@apache.org.
Fixed tests on CI servers


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/6e33f34b
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/6e33f34b
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/6e33f34b

Branch: refs/heads/camel-2.11.x
Commit: 6e33f34b3b9ccfcb6626fff9a9cdd135539dc067
Parents: 5d12940
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 10:58:29 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 10:59:22 2013 +0200

----------------------------------------------------------------------
 .../file/FilerConsumerShouldSkipDoneFileSuffixTest.java          | 4 +++-
 .../RecipientListParallelAggregateThreadPoolIssueTest.java       | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/6e33f34b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
index e6ab1d3..258b98a 100644
--- a/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
+++ b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
@@ -67,7 +67,9 @@ public class FilerConsumerShouldSkipDoneFileSuffixTest extends ContextTestSuppor
         return new RouteBuilder() {
             @Override
             public void configure() throws Exception {
-                from("file:target/done?doneFileName=${file:name}.ready&initialDelay=0&delay=10").to("mock:result");
+                from("file:target/done?doneFileName=${file:name}.ready&initialDelay=0")
+                    .convertBodyTo(String.class)
+                    .to("mock:result");
             }
         };
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/6e33f34b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
index 7040251..078c4a1 100644
--- a/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
+++ b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
@@ -42,9 +42,9 @@ public class RecipientListParallelAggregateThreadPoolIssueTest extends ContextTe
         int num1 = context.getTypeConverter().convertTo(int.class, before);
         int num2 = context.getTypeConverter().convertTo(int.class, after);
         int diff = num2 - num1;
-        // should be 10 + 1 other threads (10 in parallel pool + 1 in aggregate pool)
+        // should be at least 10 + 1 other threads (10 in parallel pool + 1 in aggregate pool)
         // we run unit test per jmv fork, so there may be a hanging thread
-        assertTrue("There should be 12 threads in diff, was: " + diff, diff >= 12 && diff <= 13);
+        assertTrue("There should be 12 or more threads in use, was: " + diff, diff >= 11);
     }
 
     @Override


[02/13] git commit: Fixed tests on CI servers

Posted by da...@apache.org.
Fixed tests on CI servers


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/9386ce16
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/9386ce16
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/9386ce16

Branch: refs/heads/master
Commit: 9386ce16e53c07aeed7f0901db61565170d813bb
Parents: c1340cf
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 10:58:29 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 10:58:29 2013 +0200

----------------------------------------------------------------------
 .../file/FilerConsumerShouldSkipDoneFileSuffixTest.java          | 4 +++-
 .../RecipientListParallelAggregateThreadPoolIssueTest.java       | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/9386ce16/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
index e6ab1d3..258b98a 100644
--- a/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
+++ b/camel-core/src/test/java/org/apache/camel/component/file/FilerConsumerShouldSkipDoneFileSuffixTest.java
@@ -67,7 +67,9 @@ public class FilerConsumerShouldSkipDoneFileSuffixTest extends ContextTestSuppor
         return new RouteBuilder() {
             @Override
             public void configure() throws Exception {
-                from("file:target/done?doneFileName=${file:name}.ready&initialDelay=0&delay=10").to("mock:result");
+                from("file:target/done?doneFileName=${file:name}.ready&initialDelay=0")
+                    .convertBodyTo(String.class)
+                    .to("mock:result");
             }
         };
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/9386ce16/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
index 7040251..078c4a1 100644
--- a/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
+++ b/camel-core/src/test/java/org/apache/camel/processor/RecipientListParallelAggregateThreadPoolIssueTest.java
@@ -42,9 +42,9 @@ public class RecipientListParallelAggregateThreadPoolIssueTest extends ContextTe
         int num1 = context.getTypeConverter().convertTo(int.class, before);
         int num2 = context.getTypeConverter().convertTo(int.class, after);
         int diff = num2 - num1;
-        // should be 10 + 1 other threads (10 in parallel pool + 1 in aggregate pool)
+        // should be at least 10 + 1 other threads (10 in parallel pool + 1 in aggregate pool)
         // we run unit test per jmv fork, so there may be a hanging thread
-        assertTrue("There should be 12 threads in diff, was: " + diff, diff >= 12 && diff <= 13);
+        assertTrue("There should be 12 or more threads in use, was: " + diff, diff >= 11);
     }
 
     @Override


[11/13] git commit: CAMEL-6859: AvailablePortFinder should allow max at IPv4 range.

Posted by da...@apache.org.
CAMEL-6859: AvailablePortFinder should allow max at IPv4 range.


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/5a274ea9
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/5a274ea9
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/5a274ea9

Branch: refs/heads/camel-2.12.x
Commit: 5a274ea95dc65f2b455336cdbcdcbb0b384d0bca
Parents: 3a8e576
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:13:01 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:14:21 2013 +0200

----------------------------------------------------------------------
 .../org/apache/camel/test/AvailablePortFinder.java     | 10 ++++------
 .../org/apache/camel/testng/AvailablePortFinder.java   | 13 ++++++-------
 2 files changed, 10 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/5a274ea9/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
----------------------------------------------------------------------
diff --git a/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java b/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
index 3253edd..57a1218 100644
--- a/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
+++ b/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
@@ -27,21 +27,19 @@ import org.slf4j.LoggerFactory;
 
 /**
  * Finds currently available server ports.
- *
- * @see <a href="http://www.iana.org/assignments/currentMinPort-numbers">IANA.org</a>
  */
 public final class AvailablePortFinder {
 
     /**
-     * The minimum server currentMinPort number. Set at 1100 to avoid returning privileged
-     * currentMinPort numbers.
+     * The minimum server currentMinPort number for IPv4.
+     * Set at 1100 to avoid returning privileged currentMinPort numbers.
      */
     public static final int MIN_PORT_NUMBER = 1100;
 
     /**
-     * The maximum server currentMinPort number.
+     * The maximum server currentMinPort number for IPv4.
      */
-    public static final int MAX_PORT_NUMBER = 49151;
+    public static final int MAX_PORT_NUMBER = 65535;
 
     private static final Logger LOG = LoggerFactory.getLogger(AvailablePortFinder.class);
 

http://git-wip-us.apache.org/repos/asf/camel/blob/5a274ea9/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
----------------------------------------------------------------------
diff --git a/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java b/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
index 5479c42..0f586e6 100644
--- a/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
+++ b/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
@@ -23,20 +23,19 @@ import java.util.NoSuchElementException;
 
 /**
  * Finds currently available server ports.
- *
- * @see <a href="http://www.iana.org/assignments/port-numbers">IANA.org</a>
  */
 public final class AvailablePortFinder {
+
     /**
-     * The minimum server port number. Set at 1024 to avoid returning privileged
-     * port numbers.
+     * The minimum server currentMinPort number for IPv4.
+     * Set at 1100 to avoid returning privileged currentMinPort numbers.
      */
-    public static final int MIN_PORT_NUMBER = 1024;
+    public static final int MIN_PORT_NUMBER = 1100;
 
     /**
-     * The maximum server port number.
+     * The maximum server currentMinPort number for IPv4.
      */
-    public static final int MAX_PORT_NUMBER = 49151;
+    public static final int MAX_PORT_NUMBER = 65535;
 
     /**
      * Creates a new instance.


[08/13] git commit: Fixed test

Posted by da...@apache.org.
Fixed test


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/3a8e5764
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/3a8e5764
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/3a8e5764

Branch: refs/heads/camel-2.12.x
Commit: 3a8e5764d801edb2ffedb7fa88d412539a4141ea
Parents: f2c48af
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:01:41 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:01:57 2013 +0200

----------------------------------------------------------------------
 .../apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java  | 2 +-
 .../java/org/apache/camel/test/blueprint/PropertyInjectTest.java   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/3a8e5764/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
----------------------------------------------------------------------
diff --git a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
index 2f1959c..230aaa8 100644
--- a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
+++ b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/BlueprintPropertyInjectRoute.java
@@ -26,7 +26,7 @@ public class BlueprintPropertyInjectRoute extends RouteBuilder {
 
     @Override
     public void configure() throws Exception {
-        from("direct:start")
+        from("seda:start")
                 .transform().constant(greeting)
                 .to("{{destination}}");
     }

http://git-wip-us.apache.org/repos/asf/camel/blob/3a8e5764/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
----------------------------------------------------------------------
diff --git a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
index 6336f7c..615edd1 100644
--- a/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
+++ b/components/camel-test-blueprint/src/test/java/org/apache/camel/test/blueprint/PropertyInjectTest.java
@@ -29,7 +29,7 @@ public class PropertyInjectTest extends CamelBlueprintTestSupport {
     public void testPropertyInject() throws Exception {
         getMockEndpoint("mock:result").expectedBodiesReceived("Hello");
 
-        template.sendBody("direct:start", "Camel");
+        template.sendBody("seda:start", "Camel");
 
         assertMockEndpointsSatisfied();
     }


[09/13] git commit: CAMEL-6859: AvailablePortFinder should allow max at IPv4 range.

Posted by da...@apache.org.
CAMEL-6859: AvailablePortFinder should allow max at IPv4 range.


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/41afc936
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/41afc936
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/41afc936

Branch: refs/heads/master
Commit: 41afc93661d5bc1b7c926dbc3edc356eb8251065
Parents: d36d36d
Author: Claus Ibsen <da...@apache.org>
Authored: Sun Oct 13 11:13:01 2013 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Sun Oct 13 11:13:01 2013 +0200

----------------------------------------------------------------------
 .../org/apache/camel/test/AvailablePortFinder.java     | 10 ++++------
 .../org/apache/camel/testng/AvailablePortFinder.java   | 13 ++++++-------
 2 files changed, 10 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/41afc936/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
----------------------------------------------------------------------
diff --git a/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java b/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
index 3253edd..57a1218 100644
--- a/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
+++ b/components/camel-test/src/main/java/org/apache/camel/test/AvailablePortFinder.java
@@ -27,21 +27,19 @@ import org.slf4j.LoggerFactory;
 
 /**
  * Finds currently available server ports.
- *
- * @see <a href="http://www.iana.org/assignments/currentMinPort-numbers">IANA.org</a>
  */
 public final class AvailablePortFinder {
 
     /**
-     * The minimum server currentMinPort number. Set at 1100 to avoid returning privileged
-     * currentMinPort numbers.
+     * The minimum server currentMinPort number for IPv4.
+     * Set at 1100 to avoid returning privileged currentMinPort numbers.
      */
     public static final int MIN_PORT_NUMBER = 1100;
 
     /**
-     * The maximum server currentMinPort number.
+     * The maximum server currentMinPort number for IPv4.
      */
-    public static final int MAX_PORT_NUMBER = 49151;
+    public static final int MAX_PORT_NUMBER = 65535;
 
     private static final Logger LOG = LoggerFactory.getLogger(AvailablePortFinder.class);
 

http://git-wip-us.apache.org/repos/asf/camel/blob/41afc936/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
----------------------------------------------------------------------
diff --git a/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java b/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
index 5479c42..0f586e6 100644
--- a/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
+++ b/components/camel-testng/src/main/java/org/apache/camel/testng/AvailablePortFinder.java
@@ -23,20 +23,19 @@ import java.util.NoSuchElementException;
 
 /**
  * Finds currently available server ports.
- *
- * @see <a href="http://www.iana.org/assignments/port-numbers">IANA.org</a>
  */
 public final class AvailablePortFinder {
+
     /**
-     * The minimum server port number. Set at 1024 to avoid returning privileged
-     * port numbers.
+     * The minimum server currentMinPort number for IPv4.
+     * Set at 1100 to avoid returning privileged currentMinPort numbers.
      */
-    public static final int MIN_PORT_NUMBER = 1024;
+    public static final int MIN_PORT_NUMBER = 1100;
 
     /**
-     * The maximum server port number.
+     * The maximum server currentMinPort number for IPv4.
      */
-    public static final int MAX_PORT_NUMBER = 49151;
+    public static final int MAX_PORT_NUMBER = 65535;
 
     /**
      * Creates a new instance.