You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/11 18:28:57 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8809: factor
out DatasourceAccessRequest model
codecov-io commented on issue #8809: factor out DatasourceAccessRequest model
URL: https://github.com/apache/incubator-superset/pull/8809#issuecomment-564673394
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=h1) Report
> Merging [#8809](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/60914fa76a4309036b91b932fea91e7236b408cb?src=pr&el=desc) will **increase** coverage by `0.32%`.
> The diff coverage is `57.62%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8809/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8809 +/- ##
==========================================
+ Coverage 65.9% 66.22% +0.32%
==========================================
Files 483 484 +1
Lines 24165 24507 +342
Branches 2770 2770
==========================================
+ Hits 15926 16230 +304
- Misses 8061 8099 +38
Partials 178 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.58% <ø> (+2.48%)` | :arrow_up: |
| [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.15% <100%> (+0.01%)` | :arrow_up: |
| [superset/models/datasource\_access\_request.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2RhdGFzb3VyY2VfYWNjZXNzX3JlcXVlc3QucHk=) | `55.35% <55.35%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `97.74% <0%> (+1.61%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `77.35% <0%> (+2.61%)` | :arrow_up: |
| [superset/translations/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | `90.9% <0%> (+3.4%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/8809/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=footer). Last update [60914fa...c0ef8d5](https://codecov.io/gh/apache/incubator-superset/pull/8809?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org