You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/01/12 02:43:38 UTC

[GitHub] spark pull request: [SPARK-12385] [SQL] [WIP] Push Projection into...

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10476#discussion_r49406403
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -287,6 +288,17 @@ object ColumnPruning extends Rule[LogicalPlan] {
     }
     
     /**
    + * Combines the adjacent [[Project]] and [[Join]] operators, iff their output sets are the same.
    + */
    +object CombineProjectJoin extends Rule[LogicalPlan] {
    +
    +  def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
    +    case p @ Project(_, j: Join)
    +      if j.outputSet == p.outputSet => j
    --- End diff --
    
    why is this specific to join?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org