You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/10 11:52:51 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4578: Output sqllogictests with arrow display

alamb commented on code in PR #4578:
URL: https://github.com/apache/arrow-datafusion/pull/4578#discussion_r1045076391


##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -52,7 +52,7 @@ SELECT var_pop(c2) FROM aggregate_test_100
 query R
 SELECT var_pop(c6) FROM aggregate_test_100
 ----
-2.615633434202189e37
+26156334342021890000000000000000000000

Review Comment:
   these differences are due the difference in `arrow::util::display::array_value_to_string` and the CSV writer. I think the changes are an improvement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org