You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2023/12/07 18:52:29 UTC

[PR] NIFI-12492 Move QuestDB Status Repository to Separate NAR [nifi]

exceptionfactory opened a new pull request, #8141:
URL: https://github.com/apache/nifi/pull/8141

   # Summary
   
   [NIFI-12492](https://issues.apache.org/jira/browse/NIFI-12492) Moves the QuestDB implementation of the Status History Repository from `nifi-framework-core` to a new `nifi-framework-questdb-nar` bundle for improved maintainability. This also provides a clear separation for the 8 MB QuestDB library from the standard framework NAR.
   
   The changes introduce a new `nifi-framework-status-history-shared` module, which is limited to API dependencies that can be shared between the standard volatile implementation and the QuestDB implementation.
   
   The change introduces a new `include-questdb` build profile for the `nifi-framework-questdb-nar` and also upgrades QuestDB from 7.2 to 7.3.7, addressing [NIFI-12435](https://issues.apache.org/jira/browse/NIFI-12435).
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12492 Move QuestDB Status Repository to Separate NAR [nifi]

Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.

exceptionfactory commented on PR #8141:
URL: https://github.com/apache/nifi/pull/8141#issuecomment-1847122208

> I reviewed the code and tested the changes. It looks good to me and I am willing to merge it. The only question I have is in this case what is the benefit of using a "nar" instead of a "jar" for `nifi-framework-questdb-status-history`? It contains no pluggable services at this point and based on my tests it should work as a simple jar. I see that the other profiles are refering to nars as well but I assume they contain some processors and controller services. What is the resason for that in this case?

Thanks for the feedback @simonbence.

The extension point class is `org.apache.nifi.controller.status.history.EmbeddedQuestDbStatusHistoryRepository`, which implements the `StatusHistoryRepository` interfaces, as enumerated in the file under `META-INF/services`. This follows the same pattern as Processors and Controller Services, and is also similar to other framework extension points like the Kubernetes State Manager and Leader Election implementations. With the NAR packaging, this has the standard benefits of ClassLoader isolation and discrete packaging.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-12492 Move QuestDB Status Repository to Separate NAR [nifi]

Posted by "simonbence (via GitHub)" <gi...@apache.org>.

simonbence closed pull request #8141: NIFI-12492 Move QuestDB Status Repository to Separate NAR
URL: https://github.com/apache/nifi/pull/8141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org