You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/10 18:00:00 UTC

[jira] [Commented] (NIFI-5113) Add XML record writer

    [ https://issues.apache.org/jira/browse/NIFI-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470862#comment-16470862 ] 

ASF GitHub Bot commented on NIFI-5113:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2675#discussion_r187395204
  
    --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/pom.xml ---
    @@ -86,12 +86,23 @@
                 <artifactId>avro</artifactId>
                 <version>1.8.1</version>
             </dependency>
    +        <dependency>
    --- End diff --
    
    I think the more appropriate dependency to use here is
    ```
    <dependency>
        <groupId>net.java.dev.stax-utils</groupId>
        <artifactId>stax-utils</artifactId>
        <version>20070216</version>
    </dependency>
    ```
    No?
    
    Either way, both have a dependency on BEA's JSR173, which has the following license: https://www.calculate-linux.org/packages/licenses/bea.ri.jsr173 - I'm not entirely sure if this is permissible in Apache land and if it is, how to properly document it. That said, it appears that jsr 173 is now part of java and so that dependency I think can be excluded. I changed the pom as follows:
    
    ```
    <dependency>
                <groupId>net.java.dev.stax-utils</groupId>
                <artifactId>stax-utils</artifactId>
                <version>20070216</version>
                <exclusions>
                    <exclusion>
                        <groupId>com.bea.xml</groupId>
                        <artifactId>jsr173-ri</artifactId>
                    </exclusion>
                </exclusions>
            </dependency>
    ```
    And all appears to work just fine. Thoughts?


> Add XML record writer
> ---------------------
>
>                 Key: NIFI-5113
>                 URL: https://issues.apache.org/jira/browse/NIFI-5113
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Johannes Peter
>            Assignee: Johannes Peter
>            Priority: Major
>
> Corresponding writer for the XML record reader



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)