[GitHub] [spark] gatorsmile commented on a change in pull request #24784: [SPARK-27938][SQL] Turn on LEGACY_PASS_PARTITION_BY_AS_OPTIONS by default

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #24784: [SPARK-27938][SQL] Turn on LEGACY_PASS_PARTITION_BY_AS_OPTIONS by default
URL: https://github.com/apache/spark/pull/24784#discussion_r291305525
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1718,7 +1718,7 @@ object SQLConf {
         "Data source V1 now silently drops partitionBy columns for non-file-format sources; " +
         "turning the flag on provides a way for these sources to see these partitionBy columns.")
       .booleanConf
-      .createWithDefault(false)
+      .createWithDefault(true)
 
 Review comment:
   +1 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org