You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/26 20:21:18 UTC
Review Request 61929: Parameterized the volume host path tests on
executor type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61929/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Joseph Wu.
Bugs: MESOS-7306
https://issues.apache.org/jira/browse/MESOS-7306
Repository: mesos
Description
-------
This allows us to test the isolator when the container is a normal
container (command executor) or a nested container (default executor).
Diffs
-----
src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION
src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e
Diff: https://reviews.apache.org/r/61929/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 61929: Parameterized the volume host path tests on
executor type.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61929/#review183899
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61899, 61900, 61901, 61902, 61903, 61904, 61905, 61906, 61907, 61908, 61919, 61929]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 26, 2017, 8:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61929/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2017, 8:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Joseph Wu.
>
>
> Bugs: MESOS-7306
> https://issues.apache.org/jira/browse/MESOS-7306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to test the isolator when the container is a normal
> container (command executor) or a nested container (default executor).
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION
> src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e
>
>
> Diff: https://reviews.apache.org/r/61929/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 61929: Parameterized the volume host path tests on
executor type.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61929/#review184004
-----------------------------------------------------------
Ship it!
None of our other test parameterization goes this far, but this certainly looks more neat than parameterizing on a `bool` or `string`.
- Joseph Wu
On Aug. 26, 2017, 1:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61929/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2017, 1:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Joseph Wu.
>
>
> Bugs: MESOS-7306
> https://issues.apache.org/jira/browse/MESOS-7306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to test the isolator when the container is a normal
> container (command executor) or a nested container (default executor).
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION
> src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e
>
>
> Diff: https://reviews.apache.org/r/61929/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 61929: Parameterized the volume host path tests on
executor type.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61929/#review183916
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61899, 61900, 61901, 61902, 61903, 61904, 61905, 61906, 61907, 61908, 61919, 61929]
Logs available here: http://104.210.40.105/logs/master/61929
- Mesos Reviewbot Windows
On Aug. 26, 2017, 8:21 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61929/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2017, 8:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Joseph Wu.
>
>
> Bugs: MESOS-7306
> https://issues.apache.org/jira/browse/MESOS-7306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to test the isolator when the container is a normal
> container (command executor) or a nested container (default executor).
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION
> src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e
>
>
> Diff: https://reviews.apache.org/r/61929/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>