You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/28 20:53:52 UTC
[GitHub] [tvm] Lunderberg opened a new pull request #9391: [TIR] Implement BufferPointer node
Lunderberg opened a new pull request #9391:
URL: https://github.com/apache/tvm/pull/9391
This is intended to simplify transformations that impact BufferStore and BufferLoad nodes. As this impacts the TIR definitions, an RFC will be posted shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-989921710
Closing following discussion on [RFC#0042](https://github.com/apache/tvm-rfcs/pull/42).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-965775124
on second look, it looks like we're not adding a new TIR datatype which is a pointer, so nevermind about my previous concern about liveness analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-956925440
We should have more discussions on RFC before merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-956925440
We should have more discussions on RFC before merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-956925440
We should have more discussions on RFC before merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-954733755
Rebase on main to resolve conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9391:
URL: https://github.com/apache/tvm/pull/9391#issuecomment-964747728
@tqchen @jroesch @manupa-arm i think there were some concerns about escape analysis if pointer semantics are introduced to TIR. I think this has to do with USMP's inability to detect liveness by refcounting. i didn't take a deep look at the impl here, but could we resolve whether this is a problem before merging here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg closed pull request #9391: [TIR] Implement BufferPointer node
Posted by GitBox <gi...@apache.org>.
Lunderberg closed pull request #9391:
URL: https://github.com/apache/tvm/pull/9391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org