[jira] Commented: (WICKET-1010) Contract of Session.attach() and Session.detach()

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903860#action_12903860 ] 

Hudson commented on WICKET-1010:
--------------------------------

Integrated in Apache Wicket 1.4.x #129 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/129/])
    

> Contract of Session.attach() and Session.detach()
> -------------------------------------------------
>
>                 Key: WICKET-1010
>                 URL: https://issues.apache.org/jira/browse/WICKET-1010
>             Project: Wicket
>          Issue Type: Bug
>            Reporter: Martin Funk
>            Assignee: Igor Vaynberg
>             Fix For: 1.5-M1
>
>
> What is the contract of Session.attach() and Session.detach() ?
> Especially, is it intended that after a call to attach() that there will
> be at least one call to detach() before the request goes back to the client?
> If that's the case, then there might be a bug in Session and I propose
> the following patch on org.apache.wicket.Session 
> Index: .
> ===================================================================
> --- .    (revision 579354)
> +++ .    (working copy)
> @@ -305,6 +305,11 @@
>      */
>     public static void unset()
>     {
> +        Session session = (Session)current.get();
> +        if (session != null)
> +    {
> +        session.detach();
> +    }
>         current.set(null);
>     }
> In my current project well fell over this looking at:
> WicketFilter.getLastModified(final HttpServletRequest servletRequest)
> where cachable resources lead over Session.findOrCreate to Session.set(Session) to Session.attach()
> but the Session.unset() doesn't lead to a Session.detach()
> Martin 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.