You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/02 06:42:07 UTC

[GitHub] [airflow] FanatoniQ commented on a diff in pull request #25412: Fixing JdbcOperator non-SELECT statement run

FanatoniQ commented on code in PR #25412:
URL: https://github.com/apache/airflow/pull/25412#discussion_r935171435


##########
airflow/providers/jdbc/operators/jdbc.py:
##########
@@ -57,16 +57,21 @@ def __init__(
         jdbc_conn_id: str = 'jdbc_default',
         autocommit: bool = False,
         parameters: Optional[Union[Iterable, Mapping]] = None,
+        handler: Callable = fetch_all_handler,

Review Comment:
   I dont think we should type hint here since the fetchall handler must not be sqlalchemy but bdapi2 compliant (`DbApiHook.run` does not use sqlalchemy).
   
   Does the `CursorResult` import comes from `jaydebeapi` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org