You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/04/10 02:44:12 UTC

[jira] Created: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Thrift server doesnt know about atomicIncrement
-----------------------------------------------

                 Key: HBASE-1318
                 URL: https://issues.apache.org/jira/browse/HBASE-1318
             Project: Hadoop HBase
          Issue Type: Bug
    Affects Versions: 0.19.1, 0.20.0
            Reporter: ryan rawson
             Fix For: 0.19.2, 0.20.0


the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by Ryan Rawson <ry...@gmail.com>.
I used the last official release, then gened into a side dir, diffed and
applied patched by hand.

Ugly but I wanted to reduce risk and errors. There'l be some whitespace
diffs.

On Apr 22, 2009 9:11 PM, "stack (JIRA)" <ji...@apache.org> wrote:

[
https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuet.
..

[jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701805#action_12701805 ] 

stack commented on HBASE-1318:
------------------------------

I applied patch to trunk and got this:
{code}
compile:
    [javac] Compiling 284 source files to /home/stack/checkouts/hbase/trunk/build/classes
    [javac] /home/stack/checkouts/hbase/trunk/src/java/org/apache/hadoop/hbase/thrift/ThriftServer.java:415: cannot find symbol
    [javac] symbol  : method incrementColumnValue(byte[],byte[],long)
    [javac] location: class org.apache.hadoop.hbase.client.HTable
    [javac]         return table.incrementColumnValue(row, column, amount);
    [javac]                     ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
{code}

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1318:
-------------------------------

    Attachment: HBASE-1318-191.patch

this version compiles against 0.19.1 in my own SVN checkout.

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318-191.patch, HBASE-1318-trunk.patch, HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1318:
-------------------------------

    Attachment:     (was: HBASE-1322.patch)

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318-191.patch, HBASE-1318-trunk.patch, HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701796#action_12701796 ] 

stack commented on HBASE-1318:
------------------------------

Ryan, what version of thrift did you use generating code?

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson reassigned HBASE-1318:
----------------------------------

    Assignee: Tim Sell  (was: ryan rawson)

Tim, do you mind giving this a shot?

Thanks!

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701797#action_12701797 ] 

stack commented on HBASE-1318:
------------------------------

What it this: 20080411p1?

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson reassigned HBASE-1318:
----------------------------------

    Assignee: ryan rawson

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1318:
-------------------------------

    Attachment: HBASE-1318.patch

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1318:
-------------------------------

    Attachment: HBASE-1318-trunk.patch

this one compiles on a trunk version.

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318-191.patch, HBASE-1318-trunk.patch, HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701804#action_12701804 ] 

stack commented on HBASE-1318:
------------------------------

04:41 < St^Ack> dj_ryan: on 1318, was it the posted version of thrift?
04:42 < dj_ryan> yes


> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1318:
-------------------------------

    Attachment: HBASE-1322.patch

this builds against 0.19.1 (a SVN checkout I have).  I'm running tests, but I dont know why it doesn't work.

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch, HBASE-1322.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704931#action_12704931 ] 

Tim Sell commented on HBASE-1318:
---------------------------------

Sure thing

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1318:
-------------------------------

    Status: Patch Available  (was: Open)

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1318:
-------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed to branch and trunk (I presume the 'right' version of thrift was used generating classes).  Thanks for the patch Ryan.

> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: Tim Sell
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318-191.patch, HBASE-1318-trunk.patch, HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1318) Thrift server doesnt know about atomicIncrement

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701801#action_12701801 ] 

ryan rawson commented on HBASE-1318:
------------------------------------

Yes exactly.




> Thrift server doesnt know about atomicIncrement
> -----------------------------------------------
>
>                 Key: HBASE-1318
>                 URL: https://issues.apache.org/jira/browse/HBASE-1318
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.1, 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HBASE-1318.patch
>
>
> the thrift server needs the atomicIncrement API implemented

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.