You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Musachy Barroso (JIRA)" <ji...@apache.org> on 2007/07/27 21:53:05 UTC
[jira] Created: (WW-2072) DefaultWorkflowInterceptor should not
perform any validation, just direct flow based on validation errors
available in the ValidationAware instance
DefaultWorkflowInterceptor should not perform any validation, just direct flow based on validation errors available in the ValidationAware instance
---------------------------------------------------------------------------------------------------------------------------------------------------
Key: WW-2072
URL: https://issues.apache.org/struts/browse/WW-2072
Project: Struts 2
Issue Type: Bug
Reporter: Musachy Barroso
Fix For: 2.1.0
The validation logic in DefaultWorkflowInterceptor should be moved to the "validation" interceptor. So other interceptors that depend on validation errors don't miss validation errors added by Validatable instances.
As it is right now, there is no place to put the "jsonValidationInterceptor" in an stack, so it caches validation errors coming from Validatable instances
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2072) DefaultWorkflowInterceptor should not
perform any validation, just direct flow based on validation errors
available in the ValidationAware instance
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42156 ]
Musachy Barroso commented on WW-2072:
-------------------------------------
Will be fixed in Xwork:
https://issues.apache.org/struts/browse/WW-2072
I will leave this ticket open as I'm not sure if I need to modify something in struts-default.xml for backward compatibility.
> DefaultWorkflowInterceptor should not perform any validation, just direct flow based on validation errors available in the ValidationAware instance
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WW-2072
> URL: https://issues.apache.org/struts/browse/WW-2072
> Project: Struts 2
> Issue Type: Improvement
> Reporter: Musachy Barroso
> Assignee: Musachy Barroso
> Fix For: 2.1.0
>
>
> The validation logic in DefaultWorkflowInterceptor should be moved to the "validation" interceptor. So other interceptors that depend on validation errors don't miss validation errors added by Validatable instances.
> As it is right now, there is no place to put the "jsonValidationInterceptor" in an stack, so it caches validation errors coming from Validatable instances
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2072) DefaultWorkflowInterceptor should not
perform any validation, just direct flow based on validation errors
available in the ValidationAware instance
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-2072.
---------------------------------
Resolution: Fixed
> DefaultWorkflowInterceptor should not perform any validation, just direct flow based on validation errors available in the ValidationAware instance
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WW-2072
> URL: https://issues.apache.org/struts/browse/WW-2072
> Project: Struts 2
> Issue Type: Improvement
> Reporter: Musachy Barroso
> Assignee: Musachy Barroso
> Fix For: 2.1.0
>
>
> The validation logic in DefaultWorkflowInterceptor should be moved to the "validation" interceptor. So other interceptors that depend on validation errors don't miss validation errors added by Validatable instances.
> As it is right now, there is no place to put the "jsonValidationInterceptor" in an stack, so it caches validation errors coming from Validatable instances
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2072) DefaultWorkflowInterceptor should not
perform any validation, just direct flow based on validation errors
available in the ValidationAware instance
Posted by "Rene Gielen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42055 ]
Rene Gielen commented on WW-2072:
---------------------------------
Sounds good to me.
I think the original intent for having that code in workflow rather than validation was to be able to have programmatic validation in place while omitting declarative validation.
Therefore, we might want to think of adding a parameter then, say "validationStrategy" with possible values declarative, programmatic, both.
> DefaultWorkflowInterceptor should not perform any validation, just direct flow based on validation errors available in the ValidationAware instance
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WW-2072
> URL: https://issues.apache.org/struts/browse/WW-2072
> Project: Struts 2
> Issue Type: Bug
> Reporter: Musachy Barroso
> Fix For: 2.1.0
>
>
> The validation logic in DefaultWorkflowInterceptor should be moved to the "validation" interceptor. So other interceptors that depend on validation errors don't miss validation errors added by Validatable instances.
> As it is right now, there is no place to put the "jsonValidationInterceptor" in an stack, so it caches validation errors coming from Validatable instances
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2072) DefaultWorkflowInterceptor should not
perform any validation, just direct flow based on validation errors
available in the ValidationAware instance
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2072:
--------------------------
Issue Type: Improvement (was: Bug)
> DefaultWorkflowInterceptor should not perform any validation, just direct flow based on validation errors available in the ValidationAware instance
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WW-2072
> URL: https://issues.apache.org/struts/browse/WW-2072
> Project: Struts 2
> Issue Type: Improvement
> Reporter: Musachy Barroso
> Fix For: 2.1.0
>
>
> The validation logic in DefaultWorkflowInterceptor should be moved to the "validation" interceptor. So other interceptors that depend on validation errors don't miss validation errors added by Validatable instances.
> As it is right now, there is no place to put the "jsonValidationInterceptor" in an stack, so it caches validation errors coming from Validatable instances
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2072) DefaultWorkflowInterceptor should not
perform any validation, just direct flow based on validation errors
available in the ValidationAware instance
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso reassigned WW-2072:
-----------------------------------
Assignee: Musachy Barroso
> DefaultWorkflowInterceptor should not perform any validation, just direct flow based on validation errors available in the ValidationAware instance
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WW-2072
> URL: https://issues.apache.org/struts/browse/WW-2072
> Project: Struts 2
> Issue Type: Improvement
> Reporter: Musachy Barroso
> Assignee: Musachy Barroso
> Fix For: 2.1.0
>
>
> The validation logic in DefaultWorkflowInterceptor should be moved to the "validation" interceptor. So other interceptors that depend on validation errors don't miss validation errors added by Validatable instances.
> As it is right now, there is no place to put the "jsonValidationInterceptor" in an stack, so it caches validation errors coming from Validatable instances
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.