You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/01 14:47:47 UTC
[GitHub] [incubator-devlake] e2corporation opened a new issue, #2923: [Bug][Config-UI] All Providers are Unable to Add Connections (Refactor Bug)
e2corporation opened a new issue, #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
**Unable to add a New Connection** for any provider. Users are redirected to the Manage Connections Screen without the connection successfully saving.
### What you expected to happen
A New Connection is Added successfully. User receives a successful Toast warning Stating as such.
### How to reproduce
Try adding a NEW Connection for Any Provider.
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234424020
If I go to "Add New Connection" for any provider, enter a Connection Name that already exists and click Save. I get redirected to Manage Connections with no error or a new connection added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234407855
@likyh I think it has to do with adding connection of the same name, User gets no error and is immediately redirected to Manage Connections page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234425757
Partially relates to #2892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234439280
Toast I know. But why you can't create new connections? Line 300-302 as before: https://github.com/apache/incubator-devlake/blob/v0.13.0/config-ui/src/hooks/useConnectionManager.jsx#L291-L293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234422247
@likyh Will keep testing, something is still off with regards to the ToastNotifications and changes in timeout behavior. User never gets to see a success Toast anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234412787
> @likyh我认为这与添加同名连接有关，用户没有错误并立即重定向到管理连接页面。感觉有些不对劲，将继续测试以找出问题所在并添加详细信息。
Yes, It show error when duplicate name. Any other idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234454139
> I am going to get rid of this timeout completely and replace it with an effect which is what I originally planned to do. In which case I can remove the promise at this layer and use the original code flow. Will keep you posted.
Of course, I also think we should not use setTimeout here. I think it uses setTimeout only because it cannot display tips correctly. Toast is cleared by fetch or other requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234403451
I create success. Would you add more info for what situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234392688
The only Provider that seems to partially work is Jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234432431
I am trying to Screen record it GiFox not capturing correctly. Part of the problem with ToastNotifications is that since the savePromise was added you need to move the setTimeout to inside the promise. This is causing conflicts with Toast behavior.
Lines 300 - 302 should get deleted, the timeout should not be calling these setters since it's now being handled in the promise. setShowError, setIsSaving, setSaveComplete shouldnt be in the Timeout anymore.
```
setTimeout(() => {
if (!saveResponse.success || errors.length !== 0) {
ToastNotification.show({
message: 'Connection failed to save, please try again.',
intent: 'danger',
icon: 'error',
})
// DELETE These 3 lines
setShowError(true)
setIsSaving(false)
setSaveComplete(false)
}
}, 2000)
```
<img width="748" alt="Screen Shot 2022-09-01 at 11 20 19 AM" src="https://user-images.githubusercontent.com/1742233/187951210-e8041438-1243-43c7-bc13-ad16a9b62d1c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234443415
I am going to get rid of this timeout completely and replace it with an effect which is what I originally planned to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234585537
Partially relates to #2892 (BE returning false positives when adding a connection of the same name, and during connection add a POST of the same named connection overwrites the original connection)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234446194
I also want to remove the need for Testing a connection inside the save operation, if anything we need to test before save happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234440193
> I have to do more refactoring to this area this new logic is not behaving correctly.
Ok, If you find out why it is, please record here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234410092
Previously if there's any failure in the Add process user is kept on the Add Connection page, no redirection happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234406015
> @likyh Try Adding more than 1 connection to an existing provider
Yes, I have many existing connectoins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed issue #2923: [Bug][Config-UI] Data Integrations - Toast Notifications odd behavior on Add Connections
Posted by GitBox <gi...@apache.org>.
klesh closed issue #2923: [Bug][Config-UI] Data Integrations - Toast Notifications odd behavior on Add Connections
URL: https://github.com/apache/incubator-devlake/issues/2923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234404971
@likyh Try Adding more than 1 connection to an existing provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234437192
I have to do more refactoring to this area this new logic is not behaving correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2923: [Bug][Config-UI] Data Integrations - All Providers are Unable to Add Connections (Refactor Bug)
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2923:
URL: https://github.com/apache/incubator-devlake/issues/2923#issuecomment-1234426763
> If I go to "Add New Connection" for any provider, enter a Connection Name that already exists and click Save. I get redirected to Manage Connections with no error or a new connection added.
Would you like to record a video of your actions? I try it but not get your error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org