You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/03/12 09:24:56 UTC
[GitHub] [celix] Oipo opened a new pull request #331: Feature/async rsa
Oipo opened a new pull request #331:
URL: https://github.com/apache/celix/pull/331
Aggregrate work done by multiple people.
- Add new C++17 async admin based on celix promises
- Add new C++17 topology manager for said admin
- Add example on how to use it
- Fix some ZMQ v2 bugs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo merged pull request #331: Feature/async rsa
Posted by GitBox <gi...@apache.org>.
Oipo merged pull request #331:
URL: https://github.com/apache/celix/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on a change in pull request #331: Feature/async rsa
Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #331:
URL: https://github.com/apache/celix/pull/331#discussion_r609765051
##########
File path: bundles/remote_services/remote_service_admin_dfi/gtest/CMakeLists.txt
##########
@@ -52,7 +52,7 @@ target_link_libraries(test_rsa_dfi PRIVATE
get_property(rsa_bundle_file TARGET rsa_dfi PROPERTY BUNDLE_FILE)
get_property(calc_bundle_file TARGET calculator PROPERTY BUNDLE_FILE)
get_property(calculator_shell_bundle_file TARGET calculator_shell PROPERTY BUNDLE_FILE)
-get_property(discovery_configured_bundle_file TARGET rsa_discovery_configured PROPERTY BUNDLE_FILE)
+get_property(discovery_bundle_file TARGET rsa_discovery PROPERTY BUNDLE_FILE)
Review comment:
Change of this property name is not udpated in the config, client and server.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #331: Feature/async rsa
Posted by GitBox <gi...@apache.org>.
pnoltes commented on pull request #331:
URL: https://github.com/apache/celix/pull/331#issuecomment-800031992
@rlenferink
Roy, do you know if this PR should go through a IP clearance procedure?
The development is done on a fork of Michael (Apache Celix committer) and the work is done by Michael, Robert and Michiel. Robert & Michiel both have signed a ICLA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on a change in pull request #331: Feature/async rsa
Posted by GitBox <gi...@apache.org>.
Oipo commented on a change in pull request #331:
URL: https://github.com/apache/celix/pull/331#discussion_r609768243
##########
File path: bundles/remote_services/remote_service_admin_dfi/gtest/CMakeLists.txt
##########
@@ -52,7 +52,7 @@ target_link_libraries(test_rsa_dfi PRIVATE
get_property(rsa_bundle_file TARGET rsa_dfi PROPERTY BUNDLE_FILE)
get_property(calc_bundle_file TARGET calculator PROPERTY BUNDLE_FILE)
get_property(calculator_shell_bundle_file TARGET calculator_shell PROPERTY BUNDLE_FILE)
-get_property(discovery_configured_bundle_file TARGET rsa_discovery_configured PROPERTY BUNDLE_FILE)
+get_property(discovery_bundle_file TARGET rsa_discovery PROPERTY BUNDLE_FILE)
Review comment:
Nice find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink commented on pull request #331: Feature/async rsa
Posted by GitBox <gi...@apache.org>.
rlenferink commented on pull request #331:
URL: https://github.com/apache/celix/pull/331#issuecomment-804308381
> @rlenferink
>
> Roy, do you know if this PR should go through a IP clearance procedure?
>
> The development is done on a fork of Michael (Apache Celix committer) and the work is done by Michael, Robert and Michiel. Robert & Michiel both have signed a ICLA.
I think an IP clearance is not necessary here. Last time we had a big chunk of work a summary of the reasoning was: "Thales already signed a CCLA, $contributor already signed an ICLA and the work already contains Apache License v2 headers, so no IP clearance is necessary". To rephrase from back then:
> I would think that if the person who submits the PR has the rights to make that contribution, then their ICLA should cover that. See https://www.apache.org/licenses/contributor-agreements.html for more info.
And 'the rights to make that contribution' being that Thales already has a CCLA submitted and $contributor being allowed to submit contributions. From the ASF its perspective I'd say we are okay here.
Thread when starting an IP clearance procedure for the websocket admin:
https://lists.apache.org/thread.html/73449b847569e69760e3260dd4ad6d90ed1ffb83ce817f82a8177be4%40%3Cgeneral.incubator.apache.org%3E
In this thread:
- Justin Mclean is VP incubator (new projects entering the ASF and learning how to be an Apache project)
- Matt Sicker is Secretary for the ASF (archiving legal documents like ICLAs, CCLAs and SGAs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink edited a comment on pull request #331: Feature/async rsa
Posted by GitBox <gi...@apache.org>.
rlenferink edited a comment on pull request #331:
URL: https://github.com/apache/celix/pull/331#issuecomment-804308381
> @rlenferink
>
> Roy, do you know if this PR should go through a IP clearance procedure?
>
> The development is done on a fork of Michael (Apache Celix committer) and the work is done by Michael, Robert and Michiel. Robert & Michiel both have signed a ICLA.
I think an IP clearance is not necessary here. Last time we had a big chunk of work a summary of the reasoning was: "Thales already signed a CCLA, $contributor already signed an ICLA and the work already contains Apache License v2 headers, so no IP clearance is necessary". To rephrase from back then:
> I would think that if the person who submits the PR has the rights to make that contribution, then their ICLA should cover that. See https://www.apache.org/licenses/contributor-agreements.html for more info.
And 'the rights to make that contribution' being that Thales already has a CCLA submitted and $contributor being allowed to submit contributions. From the ASF its perspective I'd say we are okay here.
Thread when starting an IP clearance procedure for the websocket admin:
https://lists.apache.org/thread.html/73449b847569e69760e3260dd4ad6d90ed1ffb83ce817f82a8177be4%40%3Cgeneral.incubator.apache.org%3E
In the thread above:
- Justin Mclean is VP incubator (new projects entering the ASF and learning how to be an Apache project)
- Matt Sicker is Secretary for the ASF (archiving legal documents like ICLAs, CCLAs and SGAs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org