You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2012/03/24 01:29:26 UTC
[jira] [Created] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
hbck should disable the balancer using synchronousBalanceSwitch.
----------------------------------------------------------------
Key: HBASE-5630
URL: https://issues.apache.org/jira/browse/HBASE-5630
Project: HBase
Issue Type: Improvement
Affects Versions: 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
Priority: Minor
hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399101#comment-13399101 ]
Anoop Sam John commented on HBASE-5630:
---------------------------------------
{code}
finally {
- admin.balanceSwitch(oldBalancer);
+ admin.setBalancerRunning(oldBalancer,true);
}
{code}
This change of code is necessary? Any way balancer turned off before. So no problem with old code. Any way turn ON balancer in SYNC way might not have any difference.
setBalancerRunning(final boolean on, final boolean synchronous)
Here do we better go with similar API in HMaster? We already have one API which sets the state in ASYNC way [HBaseAdmin#balanceSwitch(final boolean b)] Similar way API which takes only one arg is enough?
Or else we keep the API in HBaseAdmin with 2 params and may be deprecate the old API with one param?
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399775#comment-13399775 ]
Hudson commented on HBASE-5630:
-------------------------------
Integrated in HBase-TRUNK #3061 (See [https://builds.apache.org/job/HBase-TRUNK/3061/])
HBASE-5630 hbck should disable the balancer using synchronousBalanceSwitch (Gregory Chanan) (Revision 1353053)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan reassigned HBASE-5630:
-------------------------------------
Assignee: Gregory Chanan
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399713#comment-13399713 ]
Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------
{code}
+ }
+ else {
+ return getMaster().synchronousBalanceSwitch(on);
+ }
{code}
There is no need for else. If else were to be kept, it should stay on the previous line after right brace.
For TestSplitTransactionOnCluster.java:
{code}
// Turn off balancer so it doesn't cut in and mess up our placements.
- this.admin.balanceSwitch(false);
+ this.admin.setBalancerRunning(false, false);
{code}
I think the second parameter should be true. TestSplitTransactionOnCluster fails on Jenkins occassionally - I wonder if this could be the cause.
Will attach new 0.94 patch soon.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399685#comment-13399685 ]
Jonathan Hsieh commented on HBASE-5630:
---------------------------------------
LGTM once ted's comments are addressed.
I concur with Ted's comments about deprecation -- it is OK to deprecate in the current major version (0.94) and remove from trunk.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5630:
------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5630:
----------------------------------
Attachment: HBASE-5630-94.patch
* Attached HBASE-5630-94.patch *
Patch for 0.94
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-5630:
----------------------------------
Fix Version/s: 0.94.1
0.96.0
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-5630) hbck should disable the
balancer using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399713#comment-13399713 ]
Zhihong Ted Yu edited comment on HBASE-5630 at 6/22/12 11:29 PM:
-----------------------------------------------------------------
{code}
+ }
+ else {
+ return getMaster().synchronousBalanceSwitch(on);
+ }
{code}
There is no need for else. If 'else' were to be kept, it should stay on the previous line after right brace.
For TestSplitTransactionOnCluster.java:
{code}
// Turn off balancer so it doesn't cut in and mess up our placements.
- this.admin.balanceSwitch(false);
+ this.admin.setBalancerRunning(false, false);
{code}
I think the second parameter should be true. TestSplitTransactionOnCluster fails on Jenkins occassionally - I wonder if this could be the cause.
Will attach new 0.94 patch soon.
was (Author: zhihyu@ebaysf.com):
{code}
+ }
+ else {
+ return getMaster().synchronousBalanceSwitch(on);
+ }
{code}
There is no need for else. If else were to be kept, it should stay on the previous line after right brace.
For TestSplitTransactionOnCluster.java:
{code}
// Turn off balancer so it doesn't cut in and mess up our placements.
- this.admin.balanceSwitch(false);
+ this.admin.setBalancerRunning(false, false);
{code}
I think the second parameter should be true. TestSplitTransactionOnCluster fails on Jenkins occassionally - I wonder if this could be the cause.
Will attach new 0.94 patch soon.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: 5630-0.94-v3.txt, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399806#comment-13399806 ]
Hudson commented on HBASE-5630:
-------------------------------
Integrated in HBase-0.94 #273 (See [https://builds.apache.org/job/HBase-0.94/273/])
HBASE-5630 hbck should disable the balancer using synchronousBalanceSwitch (Gregory Chanan) (Revision 1353054)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.94/src/main/ruby/hbase/admin.rb
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400022#comment-13400022 ]
Hudson commented on HBASE-5630:
-------------------------------
Integrated in HBase-0.94-security #37 (See [https://builds.apache.org/job/HBase-0.94-security/37/])
HBASE-5630 hbck should disable the balancer using synchronousBalanceSwitch (Gregory Chanan) (Revision 1353054)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.94/src/main/ruby/hbase/admin.rb
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5630:
----------------------------------
Attachment: HBASE-5630-94-v2.patch
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399225#comment-13399225 ]
Anoop Sam John commented on HBASE-5630:
---------------------------------------
@Gregory
Do we have a seperate JIRA to keep the balancer state (ON or OFF)in zookeeper? To handle the Master restart we need this.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-5630:
----------------------------------
Status: Open (was: Patch Available)
Canceling so that the next 0.94 patch wouldn't run through QA.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5630:
----------------------------------
Attachment: HBASE-5630.patch
* Attached HBASE-5630.patch *
Patch for trunk
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399580#comment-13399580 ]
Gregory Chanan commented on HBASE-5630:
---------------------------------------
Thanks for the reviews, Ted and Anoop.
@Ted:
What is our deprecation story? I thought we don't remove something until the next major version after it has been deprecated. So if balancerSwitch is not deprecated in 0.94.0 it should not be removed in 0.96.x? Is this written down anywhere?
@Anoop:
I filed HBASE-6260 for moving the balancer state to ZK
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5630:
----------------------------------
Status: Patch Available (was: Open)
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399740#comment-13399740 ]
Hadoop QA commented on HBASE-5630:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533127/HBASE-5630-trunk-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2226//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2226//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2226//console
This message is automatically generated.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399109#comment-13399109 ]
Anoop Sam John commented on HBASE-5630:
---------------------------------------
Oh yes Ted. I have just checked the 94 patch only. My comment above was seeing only that patch.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399784#comment-13399784 ]
Hadoop QA commented on HBASE-5630:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533133/5630-trunk-v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2228//console
This message is automatically generated.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399035#comment-13399035 ]
Hadoop QA commented on HBASE-5630:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532970/HBASE-5630.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2218//console
This message is automatically generated.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5630:
----------------------------------
Attachment: HBASE-5630-trunk-v2.patch
Attached new versions of patches for trunk and 94.
Thanks for reviews Anoop, Ted, and Jon.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399077#comment-13399077 ]
Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------
Patch looks good.
{code}
+ return setBalancerRunning(b,false);
{code}
Please insert space after comma.
{code}
+ public SetBalancerRunningResponse setBalancerRunning(RpcController controller, SetBalancerRunningRequest req)
{code}
Wrap long line above.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-5630:
----------------------------------
Attachment: 5630-trunk-v3.patch
Patch v3 for trunk changes second parameter of setBalancerRunning() to true for TestSplitTransactionOnCluster.java
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399717#comment-13399717 ]
Gregory Chanan commented on HBASE-5630:
---------------------------------------
@Ted:
I just put the else for symmetry. Either way is fine with me.
It seems reasonable to me to make the balancer calls blocking. I just did a straight translation.
Greg
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: 5630-0.94-v3.txt, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399759#comment-13399759 ]
Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------
The failed tests were not related to latest patch.
I ran them manually and they passed.
Patch integrated to 0.94 and trunk.
Thanks for the patch Gregory.
Thanks for the review, Anoop.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-5630:
----------------------------------
Attachment: 5630-0.94-v3.txt
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: 5630-0.94-v3.txt, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399919#comment-13399919 ]
Hudson commented on HBASE-5630:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #66 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/66/])
HBASE-5630 hbck should disable the balancer using synchronousBalanceSwitch (Gregory Chanan) (Revision 1353053)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94-v2.patch, HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Anoop Sam John (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397444#comment-13397444 ]
Anoop Sam John commented on HBASE-5630:
---------------------------------------
The old balanceSwith() in Master only is exposed via HBaseAdmin now.
So for this we need to expose the new way of balance switch in HBaseAdmin right?
Also one more thing. A Master restart in between the HBCK run will have some impacts on the HBCK?
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Priority: Minor
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399106#comment-13399106 ]
Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------
HBaseAdmin#balanceSwitch(final boolean b) is deprecated in the patch:
{code}
+ @Deprecated
public boolean balanceSwitch(final boolean b)
{code}
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5630) hbck should disable the balancer
using synchronousBalanceSwitch.
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399570#comment-13399570 ]
Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------
@Gregory:
How about deprecating the following in 0.94 ?
{code}
public boolean balanceSwitch(final boolean b)
{code}
For 0.94 patch:
We can remove it in trunk.
{code}
+ if(synchronous == false) {
{code}
A space between if and (.
{code}
+ boolean oldBalancer = admin.setBalancerRunning(false,true);
{code}
A space between comma and 'true'.
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-5630) hbck should disable the balancer using
synchronousBalanceSwitch.
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-5630.
--------------------------------
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
> Key: HBASE-5630
> URL: https://issues.apache.org/jira/browse/HBASE-5630
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.94.1, 0.96.0
>
> Attachments: 5630-0.94-v3.txt, 5630-trunk-v3.patch, HBASE-5630-94.patch, HBASE-5630-94-v2.patch, HBASE-5630.patch, HBASE-5630-trunk-v2.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be preferable to use the newer synchronusBalanceSwitch method found in 0.94 and trunk branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira