You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Stefan <lu...@posteo.de> on 2016/11/08 08:54:25 UTC

Re: [PATCH] Testcase for issue #4642

On 10/18/2016 12:14, Daniel Shahaf wrote:
> Stefan Hett wrote on Tue, Oct 18, 2016 at 11:56:29 +0200:
>> Thanks for the review Daniel. Just a quick heads up that I'll get back to
>> this asap. Might take a few days until I can free up some time though.
> Thanks for coordinating our expectations.

Finally got to incorporate your feedback into a revised patch (see
attached).

I tested it against current trunk on Windows.

Regards,
Stefan

Re: [PATCH] Testcase for issue #4642

Posted by Stefan <lu...@posteo.de>.

On 11/17/2016 12:19, Stefan Sperling wrote:
> On Thu, Nov 17, 2016 at 12:58:48AM +0100, Stefan wrote:
>> Is there something else I'd do to improve the patch, or does anybody
>> feel like approving it for commit?
> +1

Thanks. Committed in r1770295.

Re: [PATCH] Testcase for issue #4642

Posted by Stefan Sperling <st...@elego.de>.

On Thu, Nov 17, 2016 at 12:58:48AM +0100, Stefan wrote:
> Is there something else I'd do to improve the patch, or does anybody
> feel like approving it for commit?

+1

Re: [PATCH] Testcase for issue #4642

Posted by Stefan <lu...@posteo.de>.

On 11/8/2016 09:54, Stefan wrote:
> On 10/18/2016 12:14, Daniel Shahaf wrote:
>> Stefan Hett wrote on Tue, Oct 18, 2016 at 11:56:29 +0200:
>>> Thanks for the review Daniel. Just a quick heads up that I'll get back to
>>> this asap. Might take a few days until I can free up some time though.
>> Thanks for coordinating our expectations.
> Finally got to incorporate your feedback into a revised patch (see
> attached).
>
> I tested it against current trunk on Windows.
>
Is there something else I'd do to improve the patch, or does anybody
feel like approving it for commit?

Regards,
Stefan