You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Jakob Korherr <ja...@gmail.com> on 2011/12/23 23:58:26 UTC
separate parent module - why not use the pom.xml from the main folder
as parent?
Hi,
I just checked the initial code in our git repo and found out that we
have a separate parent module. Is there a reason why this module was
created (I couldn't find a discussion about it)?
IMO it is a lot better and easier to simply use the pom.xml in the
main folder as the parent-pom for each module rather than having an
own parent module. In MyFaces we have had quite a lot of problems with
confused developers and confused tools (e.g. maven site generation),
because we used the separate parent-module (e.g. in MyFaces ExtVal).
That's the reason why we did this differently in CODI (I remember
having a parent module in the very first draft of CODI too, but then
changing it to the way it is now).
This way we could also get rid of the relativePath declarations in the
poms of our modules (e.g.
<relativePath>../parent/pom.xml</relativePath>).
WDYT?
Regards,
Jakob
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: separate parent module - why not use the pom.xml from the main
folder as parent?
Posted by Jakob Korherr <ja...@gmail.com>.
Hi,
Oh, I did not know that. I am using IntelliJ, no problems here ;)
Regards,
Jakob
2011/12/24 Dan Allen <da...@gmail.com>:
> I agree that it potentially puts some bumps in the road, but the benefit is
> that you can import that parent into the IDE when it's adjacent to the
> other modules. When it's above the modules, at least in Eclipse, it can't
> be imported without having all the submodules as resources inside the
> parent project. But perhaps that is just because Eclipse is goofy when it
> comes to this project layout.
>
> -Dan
>
> On Fri, Dec 23, 2011 at 17:58, Jakob Korherr <ja...@gmail.com>wrote:
>
>> Hi,
>>
>> I just checked the initial code in our git repo and found out that we
>> have a separate parent module. Is there a reason why this module was
>> created (I couldn't find a discussion about it)?
>>
>> IMO it is a lot better and easier to simply use the pom.xml in the
>> main folder as the parent-pom for each module rather than having an
>> own parent module. In MyFaces we have had quite a lot of problems with
>> confused developers and confused tools (e.g. maven site generation),
>> because we used the separate parent-module (e.g. in MyFaces ExtVal).
>> That's the reason why we did this differently in CODI (I remember
>> having a parent module in the very first draft of CODI too, but then
>> changing it to the way it is now).
>>
>> This way we could also get rid of the relativePath declarations in the
>> poms of our modules (e.g.
>> <relativePath>../parent/pom.xml</relativePath>).
>>
>> WDYT?
>>
>> Regards,
>> Jakob
>>
>> --
>> Jakob Korherr
>>
>> blog: http://www.jakobk.com
>> twitter: http://twitter.com/jakobkorherr
>> work: http://www.irian.at
>>
>
>
>
> --
> Dan Allen
> Principal Software Engineer, Red Hat | Author of Seam in Action
> Registered Linux User #231597
>
> http://google.com/profiles/dan.j.allen
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: separate parent module - why not use the pom.xml from the main folder as parent?
Posted by Pete Muir <pm...@redhat.com>.
This is no longer true, Eclipse (m2e) supports both approaches nowadays.
On 23 Dec 2011, at 23:02, Dan Allen wrote:
> I agree that it potentially puts some bumps in the road, but the benefit is
> that you can import that parent into the IDE when it's adjacent to the
> other modules. When it's above the modules, at least in Eclipse, it can't
> be imported without having all the submodules as resources inside the
> parent project. But perhaps that is just because Eclipse is goofy when it
> comes to this project layout.
>
> -Dan
>
> On Fri, Dec 23, 2011 at 17:58, Jakob Korherr <ja...@gmail.com>wrote:
>
>> Hi,
>>
>> I just checked the initial code in our git repo and found out that we
>> have a separate parent module. Is there a reason why this module was
>> created (I couldn't find a discussion about it)?
>>
>> IMO it is a lot better and easier to simply use the pom.xml in the
>> main folder as the parent-pom for each module rather than having an
>> own parent module. In MyFaces we have had quite a lot of problems with
>> confused developers and confused tools (e.g. maven site generation),
>> because we used the separate parent-module (e.g. in MyFaces ExtVal).
>> That's the reason why we did this differently in CODI (I remember
>> having a parent module in the very first draft of CODI too, but then
>> changing it to the way it is now).
>>
>> This way we could also get rid of the relativePath declarations in the
>> poms of our modules (e.g.
>> <relativePath>../parent/pom.xml</relativePath>).
>>
>> WDYT?
>>
>> Regards,
>> Jakob
>>
>> --
>> Jakob Korherr
>>
>> blog: http://www.jakobk.com
>> twitter: http://twitter.com/jakobkorherr
>> work: http://www.irian.at
>>
>
>
>
> --
> Dan Allen
> Principal Software Engineer, Red Hat | Author of Seam in Action
> Registered Linux User #231597
>
> http://google.com/profiles/dan.j.allen
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
Re: separate parent module - why not use the pom.xml from the main
folder as parent?
Posted by Dan Allen <da...@gmail.com>.
I agree that it potentially puts some bumps in the road, but the benefit is
that you can import that parent into the IDE when it's adjacent to the
other modules. When it's above the modules, at least in Eclipse, it can't
be imported without having all the submodules as resources inside the
parent project. But perhaps that is just because Eclipse is goofy when it
comes to this project layout.
-Dan
On Fri, Dec 23, 2011 at 17:58, Jakob Korherr <ja...@gmail.com>wrote:
> Hi,
>
> I just checked the initial code in our git repo and found out that we
> have a separate parent module. Is there a reason why this module was
> created (I couldn't find a discussion about it)?
>
> IMO it is a lot better and easier to simply use the pom.xml in the
> main folder as the parent-pom for each module rather than having an
> own parent module. In MyFaces we have had quite a lot of problems with
> confused developers and confused tools (e.g. maven site generation),
> because we used the separate parent-module (e.g. in MyFaces ExtVal).
> That's the reason why we did this differently in CODI (I remember
> having a parent module in the very first draft of CODI too, but then
> changing it to the way it is now).
>
> This way we could also get rid of the relativePath declarations in the
> poms of our modules (e.g.
> <relativePath>../parent/pom.xml</relativePath>).
>
> WDYT?
>
> Regards,
> Jakob
>
> --
> Jakob Korherr
>
> blog: http://www.jakobk.com
> twitter: http://twitter.com/jakobkorherr
> work: http://www.irian.at
>
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://google.com/profiles/dan.j.allen
http://mojavelinux.com
http://mojavelinux.com/seaminaction
Re: separate parent module - why not use the pom.xml from the main folder as parent?
Posted by Mark Struberg <st...@yahoo.de>.
Hi Jakob!
This was needed as we don't maintain the checkstyle plugin as separat project (because of using GIT).
Thus we did need to move the 'parent' for the code projects one layer deeper...
LieGrue,
strub
----- Original Message -----
> From: Jakob Korherr <ja...@gmail.com>
> To: deltaspike-dev@incubator.apache.org
> Cc:
> Sent: Friday, December 23, 2011 11:58 PM
> Subject: separate parent module - why not use the pom.xml from the main folder as parent?
>
> Hi,
>
> I just checked the initial code in our git repo and found out that we
> have a separate parent module. Is there a reason why this module was
> created (I couldn't find a discussion about it)?
>
> IMO it is a lot better and easier to simply use the pom.xml in the
> main folder as the parent-pom for each module rather than having an
> own parent module. In MyFaces we have had quite a lot of problems with
> confused developers and confused tools (e.g. maven site generation),
> because we used the separate parent-module (e.g. in MyFaces ExtVal).
> That's the reason why we did this differently in CODI (I remember
> having a parent module in the very first draft of CODI too, but then
> changing it to the way it is now).
>
> This way we could also get rid of the relativePath declarations in the
> poms of our modules (e.g.
> <relativePath>../parent/pom.xml</relativePath>).
>
> WDYT?
>
> Regards,
> Jakob
>
> --
> Jakob Korherr
>
> blog: http://www.jakobk.com
> twitter: http://twitter.com/jakobkorherr
> work: http://www.irian.at
>