You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/30 16:05:06 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3750:
[test/plugin]validator enhancement
wu-sheng commented on a change in pull request #3750: [test/plugin]validator enhancement
URL: https://github.com/apache/skywalking/pull/3750#discussion_r340711559
##########
File path: test/plugin/scenarios/apm-toolkit-trace-scenario/src/main/java/test/org/apache/skywalking/apm/testcase/toolkit/controller/TestController.java
##########
@@ -52,12 +52,12 @@ public String toolKitCase() {
testService.testErrorMsg();
testService.testErrorThrowable();
testService.asyncCallable(() -> {
- visit("http://localhost:8080/apm-toolkit-trace-scenario/case/asyncVisit/callable");
+ visit("http://localhost:8080/apm-toolkit-trace-scenario/case/asyncVisit?from=callable");
Review comment:
Why change to the parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services