You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2015/12/09 20:47:44 UTC
spark git commit: [SPARK-11824][WEBUI] WebUI does not render
descriptions with 'bad' HTML, throws console error
Repository: spark
Updated Branches:
refs/heads/master aec5ea000 -> 1eb7c22ce
[SPARK-11824][WEBUI] WebUI does not render descriptions with 'bad' HTML, throws console error
Don't warn when description isn't valid HTML since it may properly be like "SELECT ... where foo <= 1"
The tests for this code indicate that it's normal to handle strings like this that don't contain HTML as a string rather than markup. Hence logging every such instance as a warning is too noisy since it's not a problem. this is an issue for stages whose name contain SQL like the above
CC tdas as author of this bit of code
Author: Sean Owen <so...@cloudera.com>
Closes #10159 from srowen/SPARK-11824.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/1eb7c22c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/1eb7c22c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/1eb7c22c
Branch: refs/heads/master
Commit: 1eb7c22ce72a1b82ed194a51bbcf0da9c771605a
Parents: aec5ea0
Author: Sean Owen <so...@cloudera.com>
Authored: Wed Dec 9 19:47:38 2015 +0000
Committer: Sean Owen <so...@cloudera.com>
Committed: Wed Dec 9 19:47:38 2015 +0000
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/ui/UIUtils.scala | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/1eb7c22c/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
index 1e8194f..81a6f07 100644
--- a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
+++ b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
@@ -448,7 +448,6 @@ private[spark] object UIUtils extends Logging {
new RuleTransformer(rule).transform(xml)
} catch {
case NonFatal(e) =>
- logWarning(s"Invalid job description: $desc ", e)
<span class="description-input">{desc}</span>
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org