[GitHub] [hudi] danny0405 commented on a diff in pull request #9364: [HUDI-6645] Relax the restriction for Spark MDT rollback

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9364:
URL: https://github.com/apache/hudi/pull/9364#discussion_r1284957893


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1022,22 +1020,6 @@ public void update(HoodieRollbackMetadata rollbackMetadata, String instantTime)
     }
   }
 
-  protected void validateRollback(

Review Comment:
   > Why should this be relaxed? Does not look safe for Spark.
   
   It should be safe now, because the MDT log reader can filter out invalid commits based on DT timeline, we need to do this, because Flink has relax the compaction now, if people uses Spark to write into Flink table, then the error throws.
   
   Another choice is to disable the MDT for Flink again, I don't think MDT is production ready for long running MOR job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org