You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/22 23:24:03 UTC

[GitHub] [beam] reuvenlax commented on pull request #14302: [BEAM-11886] Sickbay unsupported MapState, SetState, committed metrics for Dataflow streaming

reuvenlax commented on pull request #14302:
URL: https://github.com/apache/beam/pull/14302#issuecomment-804460308


   I think I see the problem. The test was testing something that wasn't
   really part of the API contract, as a way of trying to validate internal
   details. I believe a subsequent PR (changing how the Dataflow runner caches
   data) broke that assumption. I think we should remove that line from the
   test.
   
   On Mon, Mar 22, 2021 at 3:51 PM Kenn Knowles ***@***.***>
   wrote:
   
   > Merged #14302 <https://github.com/apache/beam/pull/14302> into master.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/beam/pull/14302#event-4492885243>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AFAYJVMQNBSY2LJB5L26GOLTE7CVZANCNFSM4ZT7V53A>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org