You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/11/13 00:21:44 UTC

[jira] Created: (ZOOKEEPER-221) log message in ZkWatchManager.materialize missing conditional

log message in ZkWatchManager.materialize missing conditional
-------------------------------------------------------------

                 Key: ZOOKEEPER-221
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-221
             Project: Zookeeper
          Issue Type: Bug
          Components: java client
    Affects Versions: 3.0.0
            Reporter: Patrick Hunt
            Assignee: Patrick Hunt
             Fix For: 3.0.1, 3.1.0


the following code is missing conditional log call based on result of remove call (size > 0)

    // XXX This shouldn't be needed, but just in case
>     synchronized (existWatches) {
>         addTo(existWatches.remove(path), result);
>         LOG.warn("We are triggering an exists watch for delete! Shouldn't happen!");
>     }
> 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-221) log message in ZkWatchManager.materialize missing conditional

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-221:
-----------------------------------

    Status: Patch Available  (was: Open)

> log message in ZkWatchManager.materialize missing conditional
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-221
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-221
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-221.patch
>
>
> the following code is missing conditional log call based on result of remove call (size > 0)
>     // XXX This shouldn't be needed, but just in case
> >     synchronized (existWatches) {
> >         addTo(existWatches.remove(path), result);
> >         LOG.warn("We are triggering an exists watch for delete! Shouldn't happen!");
> >     }
> > 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-221) log message in ZkWatchManager.materialize missing conditional

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648802#action_12648802 ] 

Mahadev konar commented on ZOOKEEPER-221:
-----------------------------------------

Looks like ZOOKEEPER-204 has the fix already.. can you verify?

> log message in ZkWatchManager.materialize missing conditional
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-221
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-221
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-221.patch
>
>
> the following code is missing conditional log call based on result of remove call (size > 0)
>     // XXX This shouldn't be needed, but just in case
> >     synchronized (existWatches) {
> >         addTo(existWatches.remove(path), result);
> >         LOG.warn("We are triggering an exists watch for delete! Shouldn't happen!");
> >     }
> > 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-221) log message in ZkWatchManager.materialize missing conditional

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-221:
-----------------------------------

    Attachment: ZOOKEEPER-221.patch

wrap log message in conditional base on remove result.

> log message in ZkWatchManager.materialize missing conditional
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-221
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-221
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-221.patch
>
>
> the following code is missing conditional log call based on result of remove call (size > 0)
>     // XXX This shouldn't be needed, but just in case
> >     synchronized (existWatches) {
> >         addTo(existWatches.remove(path), result);
> >         LOG.warn("We are triggering an exists watch for delete! Shouldn't happen!");
> >     }
> > 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-221) log message in ZkWatchManager.materialize missing conditional

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-221:
------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

this is fixed in ZOOKEEPER-204.

> log message in ZkWatchManager.materialize missing conditional
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-221
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-221
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-221.patch
>
>
> the following code is missing conditional log call based on result of remove call (size > 0)
>     // XXX This shouldn't be needed, but just in case
> >     synchronized (existWatches) {
> >         addTo(existWatches.remove(path), result);
> >         LOG.warn("We are triggering an exists watch for delete! Shouldn't happen!");
> >     }
> > 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.