You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/04/30 15:13:17 UTC
[GitHub] [airflow] pankajastro commented on a diff in pull request #30961: implement gcs_schema_object for BigQueryCreateExternalTableOperator
pankajastro commented on code in PR #30961:
URL: https://github.com/apache/airflow/pull/30961#discussion_r1181247299
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1429,8 +1428,9 @@ class BigQueryCreateExternalTableOperator(GoogleCloudBaseOperator):
:param table_resource: Table resource as described in documentation:
https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#Table
If provided all other parameters are ignored. External schema from object will be resolved.
- :param schema_object: If set, a GCS object path pointing to a .json file that
- contains the schema for the table. (templated)
+ :param gcs_schema_object: Full path to the JSON file containing
Review Comment:
we should not rename it directly otherwise this would be a breaking change.
@attilaszombati if really want to make this change, shall we deprecate it first wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org