You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/18 07:29:48 UTC
[GitHub] [flink] vthinkxie opened a new pull request #11433:
[FLINK-15953][web] fix restarting status in web
vthinkxie opened a new pull request #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433
## What is the purpose of the change
fix https://issues.apache.org/jira/browse/FLINK-15787
## Brief change log
support more metric display at once
## Verifying this change
- *Submit a restarting job*
- *Go to the dashboard*
- *check if the restarting status correct*
before:
after:
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #11433: [FLINK-15953][web] fix
restarting status in web
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #11433:
[FLINK-15953][web] fix restarting status in web
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#discussion_r394212327
##########
File path: flink-runtime-web/web-dashboard/src/app/app.config.ts
##########
@@ -29,6 +29,7 @@ export const COLOR_MAP = {
RECONCILING: '#eb2f96',
IN_PROGRESS: '#faad14',
SCHEDULED: '#722ed1',
- COMPLETED : '#1890ff'
+ COMPLETED: '#1890ff',
+ RESTARTING: '#13c2c2'
Review comment:
How did you chose the color?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11433:
[FLINK-15953][web] fix restarting status in web
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#issuecomment-600470082
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153867366",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
}, {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6349",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76199dca7dfc6288319ed005f7afd22b0e57857f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153867366) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6349)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #11433:
[FLINK-15953][web] fix restarting status in web
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#discussion_r394223646
##########
File path: flink-runtime-web/web-dashboard/src/app/app.config.ts
##########
@@ -29,6 +29,7 @@ export const COLOR_MAP = {
RECONCILING: '#eb2f96',
IN_PROGRESS: '#faad14',
SCHEDULED: '#722ed1',
- COMPLETED : '#1890ff'
+ COMPLETED: '#1890ff',
+ RESTARTING: '#13c2c2'
Review comment:
there is a design system here
https://github.com/apache/flink/blob/76199dca7dfc6288319ed005f7afd22b0e57857f/flink-runtime-web/web-dashboard/src/styles/theme.less#L18
and for ant design 3.x version, the color is cyan-6 from https://github.com/NG-ZORRO/ng-zorro-antd/blob/45e84e8b99cd3cedb6face42538ae4faaf6dacf5/components/style/color/colors.less#L31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11433:
[FLINK-15953][web] fix restarting status in web
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#issuecomment-600470082
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153867366",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
}, {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6349",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76199dca7dfc6288319ed005f7afd22b0e57857f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153867366) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6349)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11433: [FLINK-15953][web] fix
restarting status in web
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#issuecomment-600467307
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 76199dca7dfc6288319ed005f7afd22b0e57857f (Wed Mar 18 07:32:04 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11433: [FLINK-15953][web] fix
restarting status in web
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#issuecomment-600470082
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76199dca7dfc6288319ed005f7afd22b0e57857f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11433:
[FLINK-15953][web] fix restarting status in web
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11433: [FLINK-15953][web] fix restarting status in web
URL: https://github.com/apache/flink/pull/11433#issuecomment-600470082
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153867366",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
}, {
"hash" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6349",
"triggerID" : "76199dca7dfc6288319ed005f7afd22b0e57857f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76199dca7dfc6288319ed005f7afd22b0e57857f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153867366) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6349)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services