[jira] [Commented] (MYNEWT-881) SensorAPI: LIS2DH12 set threshold callback cannot get called multiple times

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYNEWT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314239#comment-16314239 ] 

ASF GitHub Bot commented on MYNEWT-881:
---------------------------------------

vrahane opened a new pull request #718: MYNEWT-881 SensorAPI: LIS2DH12 set thresh cb fix
URL: https://github.com/apache/mynewt-core/pull/718
 
 
   There are two issues for calling lis2dh12_sensor_set_trigger_thresh() multiple times:
   
   1. gpio irq was not being released before doing a re-initialization
   2. srec was malloced and calling the function multiple times would have
   malloced additional memory without freeing it.
   
   Solution:
   1. Release the gpio irq
   2. Remove the malloc and add a ptr for the sensor in each type trait so
   that a sensor read could be performed in the irq handler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SensorAPI: LIS2DH12 set threshold callback cannot get called multiple times
> ---------------------------------------------------------------------------
>
>                 Key: MYNEWT-881
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-881
>             Project: Mynewt
>          Issue Type: Bug
>      Security Level: Public(Viewable by anyone) 
>          Components: Sensor Framework
>    Affects Versions: v1_3_0_rel
>         Environment: ruuvitag-revb2
>            Reporter: Vipul Rahane
>            Assignee: Vipul Rahane
>             Fix For: v1_4_0_rel
>
>
> There are two issues for calling the lis2dh12_sensor_set_trigger_thresh():
> 1. gpio irq was not being released before doing a re-initialization
> 2. srec was malloced and calling the function multiple times would have malloced additional memory without freeing it. 
> Solution:
> 1. Release the gpio irq
> 2. Remove the malloc and add a ptr for the sensor in each type trait so that a sensor read could be performed in the irq handler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)