You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/09 23:51:50 UTC
[GitHub] [servicecomb-service-center] humingcheng opened a new pull request
#630: Change etcd client MaxCallSendMsgSize to 10MB
humingcheng opened a new pull request #630: Change etcd client MaxCallSendMsgSize to 10MB
URL: https://github.com/apache/servicecomb-service-center/pull/630
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #630:
Change etcd client MaxCallSendMsgSize to 10MB
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #630: Change etcd client MaxCallSendMsgSize to 10MB
URL: https://github.com/apache/servicecomb-service-center/pull/630#issuecomment-583911128
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=h1) Report
> Merging [#630](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/b63555bb32c3325bc69455b5fc3d816228adddec?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
- Coverage 57.13% 57.09% -0.04%
==========================================
Files 207 207
Lines 16068 16069 +1
==========================================
- Hits 9180 9175 -5
- Misses 6220 6228 +8
+ Partials 668 666 -2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.37% <100%> (+0.02%)` | :arrow_up: |
| [server/handler/accesslog/handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-c2VydmVyL2hhbmRsZXIvYWNjZXNzbG9nL2hhbmRsZXIuZ28=) | `29.09% <0%> (-21.82%)` | :arrow_down: |
| [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `71.42% <0%> (-2.39%)` | :arrow_down: |
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `81.14% <0%> (+0.57%)` | :arrow_up: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: |
| [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: |
| [syncer/pkg/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/630/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy90aWNrZXIvdGlja2VyLmdv) | `100% <0%> (+19.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=footer). Last update [b63555b...eba68c6](https://codecov.io/gh/apache/servicecomb-service-center/pull/630?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #630:
Change etcd client MaxCallSendMsgSize to 10MB
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #630: Change etcd client MaxCallSendMsgSize to 10MB
URL: https://github.com/apache/servicecomb-service-center/pull/630#issuecomment-583911102
[](https://coveralls.io/builds/28619918)
Coverage increased (+0.04%) to 59.584% when pulling **eba68c6e43fa3fb617d58943cf43a7a63fec6735 on humingcheng:master** into **b63555bb32c3325bc69455b5fc3d816228adddec on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] little-cui merged pull request #630:
Change etcd client MaxCallSendMsgSize to 10MB
Posted by GitBox <gi...@apache.org>.
little-cui merged pull request #630: Change etcd client MaxCallSendMsgSize to 10MB
URL: https://github.com/apache/servicecomb-service-center/pull/630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services